Skip to contentSkip to conversation

blk-mq: fix the blk_mq_add_to_requeue_list call in blk_kick_flush

PATCH Applied Christoph Hellwig 2 participants 2 messages Apr 16, 2023 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blk-mq: fix the blk_mq_add_to_requeue_list call in blk_kick_flush

Commit b12e5c6c755a accidentally changes blk_kick_flush to do a head insert into the requeue list, fix this up.

Fixes b12e5c6c755a ("blk-mq: pass a flags argument to blk_mq_add_to_requeue_list")
---
 block/blk-flush.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-flush.c +1 -1
index 00dd2f61312d89..04698ed9bcd4a9 100644
@@ -346,7 +346,7 @@ static void blk_kick_flush(struct request_queue *q, struct blk_flush_queue *fq,
 	smp_wmb();
 	req_ref_set(flush_rq, 1);
 
-	blk_mq_add_to_requeue_list(flush_rq, BLK_MQ_INSERT_AT_HEAD);
+	blk_mq_add_to_requeue_list(flush_rq, 0);
 	blk_mq_kick_requeue_list(q);
 }
 
Signature · 1 line
2.39.2
maintainer Applied
#1 lore raw
Quoted 4 lines · Christoph Hellwig

Commit b12e5c6c755a accidentally changes blk_kick_flush to do a head insert into the requeue list, fix this up.

Applied, thanks!

[1/1] blk-mq: fix the blk_mq_add_to_requeue_list call in blk_kick_flush

      commit: 26a42b614eb934f400cd3d1cc0b7fa1955ae3320

Best regards,

Signature · 1 line
Jens Axboe