lib/show_mem.c: Use for_each_populated_zone() simplify code
PATCH 1/1 lib/show_mem.c: Use for_each_populated_zone() simplify code
The __show_mem() needs to iterate over all zones that have memory, we can simplify the code by using for_each_populated_zone().
Signed-off-by Yajun Deng <[email protected]>
--- lib/show_mem.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-)
lib/show_mem.c +6 -13
@@ -10,26 +10,19 @@void __show_mem (unsigned int filter,nodemask_t *nodemask,int max_zone_idx) { -pg_data_t *pgdat;unsigned long total =0 , reserved =0 , highmem =0 ; +struct zone *zone;printk ("Mem-Info:\n" );__show_free_areas (filter, nodemask, max_zone_idx); -for_each_online_pgdat (pgdat) { -int zoneid; +for_each_populated_zone (zone) { -for (zoneid =0 ; zoneid <MAX_NR_ZONES ; zoneid++) { -struct zone *zone = &pgdat->node_zones[zoneid]; -if (!populated_zone (zone)) -continue ; + total += zone->present_pages; + reserved += zone->present_pages -zone_managed_pages (zone); - total += zone->present_pages; - reserved += zone->present_pages -zone_managed_pages (zone); - -if (is_highmem_idx (zoneid)) - highmem += zone->present_pages; - } +if (is_highmem (zone)) + highmem += zone->present_pages; }printk ("%lu pages RAM\n" , total);
Signature · 1 line
2.25.1
Quoted 4 lines · Yajun Deng
The
__show_mem()needs to iterate over all zones that have memory, we can simplify the code by usingfor_each_populated_zone().Signed-off-by Yajun Deng <[email protected]>
Acked-by Vlastimil Babka <[email protected]>
Quoted 41 lines
--- lib/show_mem.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-)lib/show_mem.c +6
-13@@ -10,26 +10,19 @@void __show_mem (unsigned int filter,nodemask_t *nodemask,int max_zone_idx) { -pg_data_t *pgdat;unsigned long total =0 , reserved =0 , highmem =0 ; +struct zone *zone;printk ("Mem-Info:\n" );__show_free_areas (filter, nodemask, max_zone_idx); -for_each_online_pgdat (pgdat) { -int zoneid; +for_each_populated_zone (zone) { -for (zoneid =0 ; zoneid <MAX_NR_ZONES ; zoneid++) { -struct zone *zone = &pgdat->node_zones[zoneid]; -if (!populated_zone (zone)) -continue ; + total += zone->present_pages; + reserved += zone->present_pages -zone_managed_pages (zone); - total += zone->present_pages; - reserved += zone->present_pages -zone_managed_pages (zone); - -if (is_highmem_idx (zoneid)) - highmem += zone->present_pages; - } +if (is_highmem (zone)) + highmem += zone->present_pages; }printk ("%lu pages RAM\n" , total);
Quoted 4 lines · Yajun Deng
The
__show_mem()needs to iterate over all zones that have memory, we can simplify the code by usingfor_each_populated_zone().Signed-off-by Yajun Deng <[email protected]>
Acked-by Michal Hocko <[email protected]>
Thanks!
Quoted 43 lines
--- lib/show_mem.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-)lib/show_mem.c +6
-13@@ -10,26 +10,19 @@void __show_mem (unsigned int filter,nodemask_t *nodemask,int max_zone_idx) { -pg_data_t *pgdat;unsigned long total =0 , reserved =0 , highmem =0 ; +struct zone *zone;printk ("Mem-Info:\n" );__show_free_areas (filter, nodemask, max_zone_idx); -for_each_online_pgdat (pgdat) { -int zoneid; +for_each_populated_zone (zone) { -for (zoneid =0 ; zoneid <MAX_NR_ZONES ; zoneid++) { -struct zone *zone = &pgdat->node_zones[zoneid]; -if (!populated_zone (zone)) -continue ; + total += zone->present_pages; + reserved += zone->present_pages -zone_managed_pages (zone); - total += zone->present_pages; - reserved += zone->present_pages -zone_managed_pages (zone); - -if (is_highmem_idx (zoneid)) - highmem += zone->present_pages; - } +if (is_highmem (zone)) + highmem += zone->present_pages; }printk ("%lu pages RAM\n" , total);Signature · 1 line
2.25.1
Signature · 2 lines
Michal Hocko SUSE Labs