Skip to contentSkip to conversation

docs: f2fs: specify extent cache for read explicitly

PATCH Superseded Yangtao Li 3 participants 3 messages Apr 17, 2023 – Apr 18, 2023

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH v2 1/1 docs: f2fs: specify extent cache for read explicitly

Let's descrbie it's read extent cache.

---
v2:
-s/an/a

 Documentation/filesystems/f2fs.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/filesystems/f2fs.rst +3 -3
index c57745375edb..84911b7aff25 100644
@@ -163,11 +163,11 @@ barrier			 If this option is set, cache_flush commands are allowed to be
 fastboot		 This option is used when a system wants to reduce mount
 			 time as much as possible, even though normal performance
 			 can be sacrificed.
-extent_cache		 Enable an extent cache based on rb-tree, it can cache
-			 as many as extent which map between contiguous logical
+extent_cache		 Enable a read extent cache based on rb-tree, it can cache
+			 many extents which map between contiguous logical
 			 address and physical address per inode, resulting in
 			 increasing the cache hit ratio. Set by default.
-noextent_cache		 Disable an extent cache based on rb-tree explicitly, see
+noextent_cache		 Disable a read extent cache based on rb-tree explicitly, see
 			 the above extent_cache mount option.
 noinline_data		 Disable the inline data feature, inline data feature is
 			 enabled by default.
Signature · 8 lines
2.35.1



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
#1 lore raw
Quoted 1 line · Yangtao Li

Let's descrbie it's read extent cache.

"Clarify the fact that extent_cache and noextent_cache toggle read extent cache on or off."

Documentation/filesystems/f2fs.rst barrier If this option is set, cache_flush commands are allowed to be · line 166

Quoted 3 lines
Documentation/filesystems/f2fs.rst +1 -2
-extent_cache		 Enable an extent cache based on rb-tree, it can cache
-			 as many as extent which map between contiguous logical
+extent_cache		 Enable a read extent cache based on rb-tree, it can cache

"... . It can cache ..."

Quoted 2 lines

noinline_data Disable the inline data feature, inline data feature is
enabled by default.

"Disable inline data feature, for which the feature is enabled by default." (submit as separate patch).

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
maintainer
#2 lore raw
Quoted 5 lines · Bagas Sanjaya
Quoted 1 line · Yangtao Li

Let's descrbie it's read extent cache.

"Clarify the fact that extent_cache and noextent_cache toggle read extent cache on or off."

Please stop nit-picking patches. This is good enough, though I might fix the "describe" typo on the way in.

Quoted 4 lines

Documentation/filesystems/f2fs.rst barrier If this option is set, cache_flush commands are allowed to be · line 166

Quoted 3 lines
Documentation/filesystems/f2fs.rst +1 -2
-extent_cache		 Enable an extent cache based on rb-tree, it can cache
-			 as many as extent which map between contiguous logical
+extent_cache		 Enable a read extent cache based on rb-tree, it can cache

"... . It can cache ..."

Bagas. Enough. Seriously.

Quoted 5 lines
Quoted 2 lines

noinline_data Disable the inline data feature, inline data feature is
enabled by default.

"Disable inline data feature, for which the feature is enabled by default." (submit as separate patch).

And please stop trying to make additional work for others. If you want to improve something, submit a patch yourself.

jon