wifi: iwlwifi: updates intended for v6.4 2023-04-17
cover wifi: iwlwifi: updates intended for v6.4 2023-04-17
From: Gregory Greenman <[email protected]>
Hi,
Here's an additional set of iwlwifi patches for v6.4. Same as few patch sets before, this set contains the ususal developement, small improvements, cleanups and bugfixes. It bumps FW API to 78.
Thanks,
Gregory
Emmanuel Grumbach (1):
wifi: iwlwifi: mvm: adopt the latest firmware API
Gregory Greenman (2):
wifi: iwlwifi: mvm: update mac id management
wifi: iwlwifi: bump FW API to 78 for AX devices
Johannes Berg (12):
wifi: iwlwifi: mvm: use BSSID when building probe requests
wifi: iwlwifi: mvm: allow NL80211_EXT_FEATURE_SCAN_MIN_PREQ_CONTENT
wifi: iwlwifi: mvm: remove per-STA MFP setting
wifi: iwlwifi: mvm: fix iwl_mvm_sta_rc_update for MLO
wifi: iwlwifi: mvm: only clients can be 20MHz-only
wifi: iwlwifi: mvm: rs-fw: properly access sband->iftype_data
wifi: iwlwifi: mvm: initialize per-link STA ratescale data
wifi: iwlwifi: mvm: remove RS rate init update argument
wifi: iwlwifi: fix iwl_mvm_max_amsdu_size() for MLO
wifi: iwlwifi: mvm: configure TLC on link activation
wifi: iwlwifi: mvm: add MLO support to SF - use sta pointer
wifi: iwlwifi: mvm: check firmware response size
.../net/wireless/intel/iwlwifi/cfg/22000.c | 2 +- .../wireless/intel/iwlwifi/fw/api/mac-cfg.h | 10 --- .../net/wireless/intel/iwlwifi/mvm/debugfs.c | 10 +++ .../net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 22 ++--- .../net/wireless/intel/iwlwifi/mvm/mac80211.c | 31 +++---- .../net/wireless/intel/iwlwifi/mvm/mld-mac.c | 7 -- .../wireless/intel/iwlwifi/mvm/mld-mac80211.c | 24 ++++++ .../net/wireless/intel/iwlwifi/mvm/mld-sta.c | 3 +- .../net/wireless/intel/iwlwifi/mvm/rs-fw.c | 81 +++++++++++-------- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 13 +-- drivers/net/wireless/intel/iwlwifi/mvm/rs.h | 21 +++-- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 5 +- drivers/net/wireless/intel/iwlwifi/mvm/sf.c | 29 ++----- drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 2 + drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 37 ++++++++- 15 files changed, 185 insertions(+), 112 deletions(-)
Signature · 1 line
2.38.1
PATCH 1/15 wifi: iwlwifi: mvm: adopt the latest firmware API
From: Emmanuel Grumbach <[email protected]>
The firmware no longer wants the beacon template inside the MAC command.
--- drivers/net/wireless/intel/iwlwifi/fw/api/mac-cfg.h | 10 ---------- drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c | 7 ------- 2 files changed, 17 deletions(-)
drivers/net/wireless/intel/iwlwifi/fw/api/mac-cfg.h +0 -10
@@ -223,15 +223,6 @@ struct iwl_mac_client_data {__le32 ctwin; } __packed;/* MAC_CONTEXT_CONFIG_CLIENT_DATA_API_S_VER_1 */ -/** -* struct iwl_mac_go_ibss_data - configuration data for GO and IBSS MAC context -* -* @beacon_template: beacon template ID -*/ -struct iwl_mac_go_ibss_data { -__le32 beacon_template; -} __packed;/* MAC_CONTEXT_CONFIG_GO_IBSS_DATA_API_S_VER_1 */ -/** * struct iwl_mac_p2p_dev_data - configuration data for P2P device MAC context *
@@ -304,7 +295,6 @@ struct iwl_mac_config_cmd {/* MAC_CONTEXT_CONFIG_SPECIFIC_DATA_API_U_VER_1 */ union {struct iwl_mac_client_data client; -struct iwl_mac_go_ibss_data go_ibss;struct iwl_mac_p2p_dev_data p2p_dev; }; } __packed;/* MAC_CONTEXT_CONFIG_CMD_API_S_VER_1 */
drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c +0 -7
@@ -167,7 +167,6 @@ static int iwl_mvm_mld_mac_ctxt_cmd_ibss(struct iwl_mvm *mvm, struct ieee80211_vif *vif, u32 action) { -struct iwl_mvm_vif *mvmvif =iwl_mvm_vif_from_mac80211 (vif);struct iwl_mac_config_cmd cmd = {};WARN_ON (vif->type !=NL80211_IFTYPE_ADHOC );
@@ -178,9 +177,6 @@ static int iwl_mvm_mld_mac_ctxt_cmd_ibss(struct iwl_mvm *mvm,MAC_CFG_FILTER_ACCEPT_PROBE_REQ | MAC_CFG_FILTER_ACCEPT_GRP); -/* TODO: Assumes that the beacon id == mac context id */ - cmd.go_ibss.beacon_template =cpu_to_le32 (mvmvif->id); -return iwl_mvm_mld_mac_ctxt_send_cmd (mvm, &cmd); }
@@ -220,9 +216,6 @@ static int iwl_mvm_mld_mac_ctxt_cmd_ap_go(struct iwl_mvm *mvm,MAC_CFG_FILTER_ACCEPT_PROBE_REQ , MAC_CFG_FILTER_ACCEPT_BEACON); -/* TODO: Assume that the beacon id == mac context id */ - cmd.go_ibss.beacon_template =cpu_to_le32 (mvmvif->id); -return iwl_mvm_mld_mac_ctxt_send_cmd (mvm, &cmd); }
Signature · 1 line
2.38.1
PATCH 2/15 wifi: iwlwifi: mvm: update mac id management
In reply to [email protected]From: Gregory Greenman <[email protected]>
The restriction where MAC ID 0 could be used only for the managed/IBSS vif is not required when using the new MLO FW API. Update the driver.
--- .../net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c +13 -9
@@ -225,16 +225,20 @@ int iwl_mvm_mac_ctxt_init(struct iwl_mvm *mvm, struct ieee80211_vif *vif)* that we should share it with another interface. */ -/* Currently, MAC ID 0 should be used only for the managed/IBSS vif */ -switch (vif->type) { -case NL80211_IFTYPE_ADHOC : -break ; -case NL80211_IFTYPE_STATION : -if (!vif->p2p) +/* MAC ID 0 should be used only for the managed/IBSS vif with non-MLO +* FW API +*/ +if (!mvm->mld_api_is_used) { +switch (vif->type) { +case NL80211_IFTYPE_ADHOC :break ; - fallthrough; -default : -__clear_bit (0 , data.available_mac_ids); +case NL80211_IFTYPE_STATION : +if (!vif->p2p) +break ; + fallthrough; +default : +__clear_bit (0 , data.available_mac_ids); + } } ieee80211_iterate_active_interfaces_atomic(
Signature · 1 line
2.38.1
PATCH 3/15 wifi: iwlwifi: mvm: use BSSID when building probe requests
In reply to [email protected]From: Johannes Berg <[email protected]>
A long time, ago in commit 818965d39177 ("cfg80211: Allow a scan request for a specific BSSID"), the stack started passing the BSSID that should be scanned for. Use it in iwlwifi for the intended optimisation, and to also allow the use of this for an implementation sending multi-link probe requests.
--- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/mvm/scan.c +4 -1
@@ -98,6 +98,7 @@ struct iwl_mvm_scan_params {bool scan_6ghz;bool enable_6ghz_passive;bool respect_p2p_go, respect_p2p_go_hb; +u8 bssid[ETH_ALEN ]__aligned(2) ; };static inline void *iwl_mvm_get_scan_req_umac_data (struct iwl_mvm *mvm)
@@ -760,7 +761,7 @@ iwl_mvm_build_scan_probe(struct iwl_mvm *mvm, struct ieee80211_vif *vif, frame->frame_control =cpu_to_le16 (IEEE80211_STYPE_PROBE_REQ );eth_broadcast_addr (frame->da); -eth_broadcast_addr (frame->bssid); +ether_addr_copy (frame->bssid, params->bssid); frame->seq_ctrl =0 ; pos = frame->u.probe_req.variable;
@@ -2801,6 +2802,7 @@ int iwl_mvm_reg_scan_start(struct iwl_mvm *mvm, struct ieee80211_vif *vif, params.pass_all = true; params.n_match_sets =0 ; params.match_sets =NULL ; +ether_addr_copy (params.bssid, req->bssid); params.scan_plans = &scan_plan; params.n_scan_plans =1 ;
@@ -2894,6 +2896,7 @@ int iwl_mvm_sched_scan_start(struct iwl_mvm *mvm, params.pass_all =iwl_mvm_scan_pass_all (mvm, req); params.n_match_sets = req->n_match_sets; params.match_sets = req->match_sets; +eth_broadcast_addr (params.bssid);if (!req->n_scan_plans)return -EINVAL ;
Signature · 1 line
2.38.1
PATCH 4/15 wifi: iwlwifi: mvm: allow NL80211_EXT_FEATURE_SCAN_MIN_PREQ_CONTENT
In reply to [email protected]From: Johannes Berg <[email protected]>
We can allow NL80211_EXT_FEATURE_SCAN_MIN_PREQ_CONTENT since we just use the elements from mac80211.
--- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +2 -0
@@ -413,6 +413,8 @@ int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm)wiphy_ext_feature_set (hw->wiphy,NL80211_EXT_FEATURE_BEACON_RATE_LEGACY ); +wiphy_ext_feature_set (hw->wiphy, +NL80211_EXT_FEATURE_SCAN_MIN_PREQ_CONTENT );if (fw_has_capa (&mvm->fw->ucode_capa,IWL_UCODE_TLV_CAPA_FTM_CALIBRATED )) {
Signature · 1 line
2.38.1
PATCH 5/15 wifi: iwlwifi: mvm: remove per-STA MFP setting
In reply to [email protected]From: Johannes Berg <[email protected]>
When we first add the STA before sending an authentication frame this is false. However, in some cases such as FT or certainly in MLO link switch scenarios, it will be true.
If it happens to be true, it causes a firmware assert (in LMAC, 0x2528), because the same bit is used by the firmware for tracking this setting as well as for tracking if the management key has been installed, and then we get this assert from the firmware when installing the MFP key as it thinks it has already been installed.
Remove the setting for now, until the firmware disentangles the two. We should be able to set it, in fact we should be setting it speculatively before authentication/association, to avoid processing management frames that should have been protected/encrypted before the key is set.
--- drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +0 -1
@@ -427,7 +427,6 @@ static int iwl_mvm_mld_cfg_sta(struct iwl_mvm *mvm, struct ieee80211_sta *sta,struct iwl_mvm_sta_cfg_cmd cmd = { .sta_id =cpu_to_le32 (mvm_link_sta->sta_id), .station_type =cpu_to_le32 (mvm_sta->sta_type), - .mfp =cpu_to_le32 (sta->mfp), };u32 agg_size =0 , mpdu_dens =0 ;
Signature · 1 line
2.38.1
PATCH 6/15 wifi: iwlwifi: mvm: fix iwl_mvm_sta_rc_update for MLO
In reply to [email protected]From: Johannes Berg <[email protected]>
When this is called it might crash due to the use of deflink's phy context, update all links instead. It really shouldn't be called right now though, but it's better to have safer code until we update this to be with a link parameter.
--- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +3 -7
@@ -3585,9 +3585,9 @@ static void iwl_mvm_rs_rate_init_all_links(struct iwl_mvm *mvm,for_each_mvm_vif_valid_link (mvmvif, link_id) {struct ieee80211_bss_conf *conf = -link_conf_dereference_protected (vif, link_id); +link_conf_dereference_check (vif, link_id);struct ieee80211_link_sta *link_sta = -link_sta_dereference_protected (sta, link_id); +link_sta_dereference_check (sta, link_id);if (!conf || !link_sta || !mvmvif->link[link_id]->phy_ctxt)continue ;
@@ -3983,15 +3983,11 @@ void iwl_mvm_sta_rc_update(struct ieee80211_hw *hw, struct ieee80211_vif *vif, struct ieee80211_sta *sta, u32 changed) {struct iwl_mvm *mvm =IWL_MAC80211_GET_MVM (hw); -struct iwl_mvm_vif *mvmvif =iwl_mvm_vif_from_mac80211 (vif);if (changed & (IEEE80211_RC_BW_CHANGED |IEEE80211_RC_SUPP_RATES_CHANGED |IEEE80211_RC_NSS_CHANGED )) -iwl_mvm_rs_rate_init (mvm, sta, - &vif->bss_conf, &sta->deflink, - mvmvif->deflink.phy_ctxt->channel->band, - true); +iwl_mvm_rs_rate_init_all_links (mvm, vif, sta, true);if (vif->type ==NL80211_IFTYPE_STATION && changed &IEEE80211_RC_NSS_CHANGED )
Signature · 1 line
2.38.1
PATCH 7/15 wifi: iwlwifi: mvm: only clients can be 20MHz-only
In reply to [email protected]From: Johannes Berg <[email protected]>
Since only clients to an AP can be 20MHz-only STAs, adjust the code to not make the use of EHT capabilities depend on only the bandwidth, but also the type of interface.
--- .../net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c | 17 +++++++++++------ drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 9 ++++++--- drivers/net/wireless/intel/iwlwifi/mvm/rs.h | 8 ++++++-- 4 files changed, 24 insertions(+), 12 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +1 -1
@@ -3592,7 +3592,7 @@ static void iwl_mvm_rs_rate_init_all_links(struct iwl_mvm *mvm,if (!conf || !link_sta || !mvmvif->link[link_id]->phy_ctxt)continue ; -iwl_mvm_rs_rate_init (mvm, sta, conf, link_sta, +iwl_mvm_rs_rate_init (mvm, vif, sta, conf, link_sta, mvmvif->link[link_id]->phy_ctxt->channel->band, update); }
drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c +11 -6
@@ -283,7 +283,8 @@ rs_fw_rs_mcs2eht_mcs(enum IWL_TLC_MCS_PER_BW bw, }static void -rs_fw_eht_set_enabled_rates (const struct ieee80211_link_sta *link_sta, +rs_fw_eht_set_enabled_rates (struct ieee80211_vif *vif, +const struct ieee80211_link_sta *link_sta,struct ieee80211_supported_band *sband,struct iwl_tlc_config_cmd_v4 *cmd) {
@@ -299,7 +300,8 @@ rs_fw_eht_set_enabled_rates(const struct ieee80211_link_sta *link_sta,struct ieee80211_eht_mcs_nss_supp_20mhz_only mcs_tx_20;/* peer is 20Mhz only */ -if (!(link_sta->he_cap.he_cap_elem.phy_cap_info[0 ] & +if (vif->type ==NL80211_IFTYPE_AP && + !(link_sta->he_cap.he_cap_elem.phy_cap_info[0 ] &IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_MASK_ALL )) { mcs_rx_20 = eht_rx_mcs->only_20mhz; }else {
@@ -361,7 +363,8 @@ rs_fw_eht_set_enabled_rates(const struct ieee80211_link_sta *link_sta, sizeof(cmd->ht_rates[IWL_TLC_NSS_2])); } -static void rs_fw_set_supp_rates (struct ieee80211_link_sta *link_sta, +static void rs_fw_set_supp_rates (struct ieee80211_vif *vif, +struct ieee80211_link_sta *link_sta,struct ieee80211_supported_band *sband,struct iwl_tlc_config_cmd_v4 *cmd) {
@@ -383,7 +386,7 @@ static void rs_fw_set_supp_rates(struct ieee80211_link_sta *link_sta,/* HT/VHT rates */ if (link_sta->eht_cap.has_eht) { cmd->mode =IWL_TLC_MNG_MODE_EHT ; -rs_fw_eht_set_enabled_rates (link_sta, sband, cmd); +rs_fw_eht_set_enabled_rates (vif, link_sta, sband, cmd); }else if (he_cap->has_he) { cmd->mode =IWL_TLC_MNG_MODE_HE ;rs_fw_he_set_enabled_rates (link_sta, sband, cmd);
@@ -557,7 +560,9 @@ u16 rs_fw_get_max_amsdu_len(struct ieee80211_sta *sta,return 0 ; } -void rs_fw_rate_init (struct iwl_mvm *mvm,struct ieee80211_sta *sta, +void rs_fw_rate_init (struct iwl_mvm *mvm, +struct ieee80211_vif *vif, +struct ieee80211_sta *sta,struct ieee80211_bss_conf *link_conf,struct ieee80211_link_sta *link_sta,enum nl80211_band band,bool update)
@@ -601,7 +606,7 @@ void rs_fw_rate_init(struct iwl_mvm *mvm, struct ieee80211_sta *sta,#ifdef CONFIG_IWLWIFI_DEBUGFS iwl_mvm_reset_frame_stats (mvm);#endif -rs_fw_set_supp_rates (link_sta, sband, &cfg_cmd); +rs_fw_set_supp_rates (vif, link_sta, sband, &cfg_cmd);/* * since TLC offload works with one mode we can assume
drivers/net/wireless/intel/iwlwifi/mvm/rs.c +6 -3
@@ -3015,7 +3015,7 @@ static void rs_drv_rate_update(void *mvm_r,for (tid =0 ; tid <IWL_MAX_TID_COUNT ; tid++)ieee80211_stop_tx_ba_session (sta, tid); -iwl_mvm_rs_rate_init (mvm, sta, +iwl_mvm_rs_rate_init (mvm, mvmsta->vif, sta, &mvmsta->vif->bss_conf, &sta->deflink, sband->band, true); }
@@ -4101,13 +4101,16 @@ static const struct rate_control_ops rs_mvm_ops_drv = { .capa = RATE_CTRL_CAPA_VHT_EXT_NSS_BW, }; -void iwl_mvm_rs_rate_init (struct iwl_mvm *mvm,struct ieee80211_sta *sta, +void iwl_mvm_rs_rate_init (struct iwl_mvm *mvm, +struct ieee80211_vif *vif, +struct ieee80211_sta *sta,struct ieee80211_bss_conf *link_conf,struct ieee80211_link_sta *link_sta,enum nl80211_band band,bool update) {if (iwl_mvm_has_tlc_offload (mvm)) { -rs_fw_rate_init (mvm, sta, link_conf, link_sta, band, update); +rs_fw_rate_init (mvm, vif, sta, link_conf, + link_sta, band, update); }else {struct iwl_mvm_sta *mvmsta =iwl_mvm_sta_from_mac80211 (sta);
drivers/net/wireless/intel/iwlwifi/mvm/rs.h +6 -2
@@ -394,7 +394,9 @@ struct iwl_lq_sta { ((_c) << RS_DRV_DATA_LQ_COLOR_POS)))/* Initialize station's rate scaling information after adding station */ -void iwl_mvm_rs_rate_init (struct iwl_mvm *mvm,struct ieee80211_sta *sta, +void iwl_mvm_rs_rate_init (struct iwl_mvm *mvm, +struct ieee80211_vif *vif, +struct ieee80211_sta *sta,struct ieee80211_bss_conf *link_conf,struct ieee80211_link_sta *link_sta,enum nl80211_band band,bool update);
@@ -433,7 +435,9 @@ void iwl_mvm_reset_frame_stats(struct iwl_mvm *mvm);#endif void iwl_mvm_rs_add_sta (struct iwl_mvm *mvm,struct iwl_mvm_sta *mvmsta); -void rs_fw_rate_init (struct iwl_mvm *mvm,struct ieee80211_sta *sta, +void rs_fw_rate_init (struct iwl_mvm *mvm, +struct ieee80211_vif *vif, +struct ieee80211_sta *sta,struct ieee80211_bss_conf *link_conf,struct ieee80211_link_sta *link_sta,enum nl80211_band band,bool update);
Signature · 1 line
2.38.1
PATCH 8/15 wifi: iwlwifi: mvm: rs-fw: properly access sband->iftype_data
In reply to [email protected]From: Johannes Berg <[email protected]>
We need to look up the correct version of this struct depending on the interface type, rather than just checking if the pointer is non-NULL. Fix that.
--- .../net/wireless/intel/iwlwifi/mvm/rs-fw.c | 21 +++++++++++-------- 1 file changed, 12 insertions(+), 9 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c +12 -9
@@ -61,12 +61,14 @@ static u8 rs_fw_sgi_cw_support(struct ieee80211_link_sta *link_sta) }static u16 rs_fw_get_config_flags (struct iwl_mvm *mvm, +struct ieee80211_vif *vif,struct ieee80211_link_sta *link_sta,struct ieee80211_supported_band *sband) {struct ieee80211_sta_ht_cap *ht_cap = &link_sta->ht_cap;struct ieee80211_sta_vht_cap *vht_cap = &link_sta->vht_cap;struct ieee80211_sta_he_cap *he_cap = &link_sta->he_cap; +const struct ieee80211_sta_he_cap *sband_he_cap;bool vht_ena = vht_cap->vht_supported;u16 flags =0 ;
@@ -92,17 +94,19 @@ static u16 rs_fw_get_config_flags(struct iwl_mvm *mvm, IEEE80211_HE_PHY_CAP1_LDPC_CODING_IN_PAYLOAD)) flags |= IWL_TLC_MNG_CFG_FLAGS_LDPC_MSK; -if (sband->iftype_data && sband->iftype_data->he_cap.has_he && - !(sband->iftype_data->he_cap.he_cap_elem.phy_cap_info[1 ] & -IEEE80211_HE_PHY_CAP1_LDPC_CODING_IN_PAYLOAD )) + sband_he_cap =ieee80211_get_he_iftype_cap (sband, +ieee80211_vif_type_p2p (vif)); +if (sband_he_cap && + !(sband_he_cap->he_cap_elem.phy_cap_info[1 ] & +IEEE80211_HE_PHY_CAP1_LDPC_CODING_IN_PAYLOAD )) flags &= ~IWL_TLC_MNG_CFG_FLAGS_LDPC_MSK ;if (he_cap->has_he && (he_cap->he_cap_elem.phy_cap_info[3 ] &IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_RX_MASK && - sband->iftype_data && - sband->iftype_data->he_cap.he_cap_elem.phy_cap_info[3 ] & -IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_TX_MASK )) + sband_he_cap && + sband_he_cap->he_cap_elem.phy_cap_info[3 ] & +IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_TX_MASK )) flags |=IWL_TLC_MNG_CFG_FLAGS_HE_DCM_NSS_1_MSK ;return flags;
@@ -576,9 +580,8 @@ void rs_fw_rate_init(struct iwl_mvm *mvm,struct iwl_lq_sta_rs_fw *lq_sta;struct iwl_tlc_config_cmd_v4 cfg_cmd = { .max_ch_width = update ? -rs_fw_bw_from_sta_bw (link_sta) : -IWL_TLC_MNG_CH_WIDTH_20MHZ , - .flags =cpu_to_le16 (rs_fw_get_config_flags (mvm, link_sta, +rs_fw_bw_from_sta_bw (link_sta) :IWL_TLC_MNG_CH_WIDTH_20MHZ , + .flags =cpu_to_le16 (rs_fw_get_config_flags (mvm, vif, link_sta, sband)), .chains =rs_fw_set_active_chains (iwl_mvm_get_valid_tx_ant (mvm)), .sgi_ch_width_supp =rs_fw_sgi_cw_support (link_sta),
Signature · 1 line
2.38.1
PATCH 9/15 wifi: iwlwifi: mvm: initialize per-link STA ratescale data
In reply to [email protected]From: Johannes Berg <[email protected]>
When allocating a new link station, initialize the ratescaling data for it. To do that, refactor the initialization code out into a new iwl_mvm_rs_add_sta_link() function.
--- .../net/wireless/intel/iwlwifi/mvm/mld-sta.c | 2 ++ .../net/wireless/intel/iwlwifi/mvm/rs-fw.c | 35 +++++++++++-------- drivers/net/wireless/intel/iwlwifi/mvm/rs.h | 5 +++ 3 files changed, 28 insertions(+), 14 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c +2 -0
@@ -1126,6 +1126,8 @@ int iwl_mvm_mld_update_sta_links(struct iwl_mvm *mvm, goto err; link_sta_added_to_fw |=BIT (link_id); + +iwl_mvm_rs_add_sta_link (mvm, mvm_sta_link); }if (sta_mask_added) {
drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c +21 -14
@@ -679,6 +679,26 @@ int rs_fw_tx_protection(struct iwl_mvm *mvm, struct iwl_mvm_sta *mvmsta,return 0 ; } +void iwl_mvm_rs_add_sta_link (struct iwl_mvm *mvm, +struct iwl_mvm_link_sta *link_sta) +{ +struct iwl_lq_sta_rs_fw *lq_sta; + + lq_sta = &link_sta->lq_sta.rs_fw; + + lq_sta->pers.drv = mvm; + lq_sta->pers.sta_id = link_sta->sta_id; + lq_sta->pers.chains =0 ; +memset (lq_sta->pers.chain_signal,0 , +sizeof (lq_sta->pers.chain_signal)); + lq_sta->pers.last_rssi =S8_MIN ; + lq_sta->last_rate_n_flags =0 ; + +#ifdef CONFIG_MAC80211_DEBUGFS + lq_sta->pers.dbg_fixed_rate =0 ; +#endif +} +void iwl_mvm_rs_add_sta (struct iwl_mvm *mvm,struct iwl_mvm_sta *mvmsta) {unsigned int link_id;
@@ -686,25 +706,12 @@ void iwl_mvm_rs_add_sta(struct iwl_mvm *mvm, struct iwl_mvm_sta *mvmsta)IWL_DEBUG_RATE (mvm,"create station rate scale window\n" );for (link_id =0 ; link_id <ARRAY_SIZE (mvmsta->link); link_id++) { -struct iwl_lq_sta_rs_fw *lq_sta;struct iwl_mvm_link_sta *link =rcu_dereference_protected (mvmsta->link[link_id],lockdep_is_held (&mvm->mutex));if (!link)continue ; - lq_sta = &link->lq_sta.rs_fw; - - lq_sta->pers.drv = mvm; - lq_sta->pers.sta_id = link->sta_id; - lq_sta->pers.chains =0 ; -memset (lq_sta->pers.chain_signal,0 , -sizeof (lq_sta->pers.chain_signal)); - lq_sta->pers.last_rssi =S8_MIN ; - lq_sta->last_rate_n_flags =0 ; - -#ifdef CONFIG_MAC80211_DEBUGFS - lq_sta->pers.dbg_fixed_rate =0 ; -#endif +iwl_mvm_rs_add_sta_link (mvm, link); } }
drivers/net/wireless/intel/iwlwifi/mvm/rs.h +5 -0
@@ -434,7 +434,12 @@ int iwl_mvm_tx_protection(struct iwl_mvm *mvm, struct iwl_mvm_sta *mvmsta,void iwl_mvm_reset_frame_stats (struct iwl_mvm *mvm);#endif +struct iwl_mvm_link_sta ; +void iwl_mvm_rs_add_sta (struct iwl_mvm *mvm,struct iwl_mvm_sta *mvmsta); +void iwl_mvm_rs_add_sta_link (struct iwl_mvm *mvm, +struct iwl_mvm_link_sta *link_sta); + void rs_fw_rate_init(struct iwl_mvm *mvm, struct ieee80211_vif *vif, struct ieee80211_sta *sta,
Signature · 1 line
2.38.1
PATCH 10/15 wifi: iwlwifi: mvm: remove RS rate init update argument
In reply to [email protected]From: Johannes Berg <[email protected]>
Track instead whether or not the station was authorized, that's clearer than trying to indicate in the code whether or not the full bandwidth should be used via an 'update' argument.
While at it, give rs_fw_rate_init() the iwl_mvm_ prefix.
--- .../net/wireless/intel/iwlwifi/mvm/mac80211.c | 19 +++++++++++-------- .../net/wireless/intel/iwlwifi/mvm/rs-fw.c | 14 +++++++------- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 8 ++++---- drivers/net/wireless/intel/iwlwifi/mvm/rs.h | 14 +++++++------- drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 2 ++ 5 files changed, 31 insertions(+), 26 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +11 -8
@@ -3577,8 +3577,7 @@ static int iwl_mvm_mac_sta_state(struct ieee80211_hw *hw,*/ static void iwl_mvm_rs_rate_init_all_links (struct iwl_mvm *mvm,struct ieee80211_vif *vif, -struct ieee80211_sta *sta, -bool update) +struct ieee80211_sta *sta) {struct iwl_mvm_vif *mvmvif =iwl_mvm_vif_from_mac80211 (vif);unsigned int link_id;
@@ -3593,8 +3592,7 @@ static void iwl_mvm_rs_rate_init_all_links(struct iwl_mvm *mvm,continue ;iwl_mvm_rs_rate_init (mvm, vif, sta, conf, link_sta, - mvmvif->link[link_id]->phy_ctxt->channel->band, - update); + mvmvif->link[link_id]->phy_ctxt->channel->band); } }
@@ -3766,7 +3764,7 @@ iwl_mvm_sta_state_auth_to_assoc(struct ieee80211_hw *hw, } out: -iwl_mvm_rs_rate_init_all_links (mvm, vif, sta, false); +iwl_mvm_rs_rate_init_all_links (mvm, vif, sta);return callbacks->update_sta (mvm, vif, sta); }
@@ -3799,7 +3797,9 @@ iwl_mvm_sta_state_assoc_to_authorized(struct iwl_mvm *mvm,iwl_mvm_mei_host_associated (mvm, vif, mvm_sta); } -iwl_mvm_rs_rate_init_all_links (mvm, vif, sta, true); + mvm_sta->authorized = true; + +iwl_mvm_rs_rate_init_all_links (mvm, vif, sta);return 0 ; }
@@ -3811,14 +3811,17 @@ iwl_mvm_sta_state_authorized_to_assoc(struct iwl_mvm *mvm, struct iwl_mvm_sta_state_ops *callbacks) {struct iwl_mvm_vif *mvmvif =iwl_mvm_vif_from_mac80211 (vif); +struct iwl_mvm_sta *mvmsta =iwl_mvm_sta_from_mac80211 (sta);int ret;lockdep_assert_held (&mvm->mutex); + mvmsta->authorized = false; +/* once we move into assoc state, need to update rate scale to * disable using wide bandwidth */ -iwl_mvm_rs_rate_init_all_links (mvm, vif, sta, false); +iwl_mvm_rs_rate_init_all_links (mvm, vif, sta);if (!sta->tdls) {/* Set this but don't call iwl_mvm_mac_ctxt_changed()
@@ -3987,7 +3990,7 @@ void iwl_mvm_sta_rc_update(struct ieee80211_hw *hw, struct ieee80211_vif *vif,if (changed & (IEEE80211_RC_BW_CHANGED |IEEE80211_RC_SUPP_RATES_CHANGED |IEEE80211_RC_NSS_CHANGED )) -iwl_mvm_rs_rate_init_all_links (mvm, vif, sta, true); +iwl_mvm_rs_rate_init_all_links (mvm, vif, sta);if (vif->type ==NL80211_IFTYPE_STATION && changed &IEEE80211_RC_NSS_CHANGED )
drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c +7 -7
@@ -564,12 +564,12 @@ u16 rs_fw_get_max_amsdu_len(struct ieee80211_sta *sta,return 0 ; } -void rs_fw_rate_init (struct iwl_mvm *mvm, -struct ieee80211_vif *vif, -struct ieee80211_sta *sta, -struct ieee80211_bss_conf *link_conf, -struct ieee80211_link_sta *link_sta, -enum nl80211_band band,bool update) +void iwl_mvm_rs_fw_rate_init (struct iwl_mvm *mvm, +struct ieee80211_vif *vif, +struct ieee80211_sta *sta, +struct ieee80211_bss_conf *link_conf, +struct ieee80211_link_sta *link_sta, +enum nl80211_band band) {struct ieee80211_hw *hw = mvm->hw;struct iwl_mvm_sta *mvmsta =iwl_mvm_sta_from_mac80211 (sta);
@@ -579,7 +579,7 @@ void rs_fw_rate_init(struct iwl_mvm *mvm,struct iwl_mvm_link_sta *mvm_link_sta;struct iwl_lq_sta_rs_fw *lq_sta;struct iwl_tlc_config_cmd_v4 cfg_cmd = { - .max_ch_width = update ? + .max_ch_width = mvmsta->authorized ?rs_fw_bw_from_sta_bw (link_sta) :IWL_TLC_MNG_CH_WIDTH_20MHZ , .flags =cpu_to_le16 (rs_fw_get_config_flags (mvm, vif, link_sta, sband)),
drivers/net/wireless/intel/iwlwifi/mvm/rs.c +4 -4
@@ -3017,7 +3017,7 @@ static void rs_drv_rate_update(void *mvm_r,iwl_mvm_rs_rate_init (mvm, mvmsta->vif, sta, &mvmsta->vif->bss_conf, &sta->deflink, - sband->band, true); + sband->band); } static void __iwl_mvm_rs_tx_status(struct iwl_mvm *mvm,
@@ -4106,11 +4106,11 @@ void iwl_mvm_rs_rate_init(struct iwl_mvm *mvm,struct ieee80211_sta *sta, struct ieee80211_bss_conf *link_conf, struct ieee80211_link_sta *link_sta, - enum nl80211_band band, bool update) + enum nl80211_band band) { if (iwl_mvm_has_tlc_offload(mvm)) { -rs_fw_rate_init (mvm ,vif ,sta ,link_conf , -link_sta ,band ,update ); +iwl_mvm_rs_fw_rate_init (mvm ,vif ,sta ,link_conf , +link_sta ,band ); } else {struct iwl_mvm_sta *mvmsta =iwl_mvm_sta_from_mac80211 (sta);
drivers/net/wireless/intel/iwlwifi/mvm/rs.h +7 -7
@@ -399,7 +399,7 @@ void iwl_mvm_rs_rate_init(struct iwl_mvm *mvm,struct ieee80211_sta *sta, struct ieee80211_bss_conf *link_conf, struct ieee80211_link_sta *link_sta, - enum nl80211_band band, bool update); + enum nl80211_band band);/* Notify RS about Tx status */ void iwl_mvm_rs_tx_status(struct iwl_mvm *mvm, struct ieee80211_sta *sta,
@@ -440,12 +440,12 @@ void iwl_mvm_rs_add_sta(struct iwl_mvm *mvm, struct iwl_mvm_sta *mvmsta);void iwl_mvm_rs_add_sta_link (struct iwl_mvm *mvm,struct iwl_mvm_link_sta *link_sta); -void rs_fw_rate_init (struct iwl_mvm *mvm, -struct ieee80211_vif *vif, -struct ieee80211_sta *sta, -struct ieee80211_bss_conf *link_conf, -struct ieee80211_link_sta *link_sta, -enum nl80211_band band,bool update); +void iwl_mvm_rs_fw_rate_init (struct iwl_mvm *mvm, +struct ieee80211_vif *vif, +struct ieee80211_sta *sta, +struct ieee80211_bss_conf *link_conf, +struct ieee80211_link_sta *link_sta, +enum nl80211_band band);int rs_fw_tx_protection (struct iwl_mvm *mvm,struct iwl_mvm_sta *mvmsta,bool enable); void iwl_mvm_tlc_update_notif(struct iwl_mvm *mvm,
drivers/net/wireless/intel/iwlwifi/mvm/sta.h +2 -0
@@ -356,6 +356,7 @@ struct iwl_mvm_link_sta {* @tid_disable_agg: bitmap: if bit(tid) is set, the fw won't send ampdus for * tid. * @sta_type: station type +* @authorized: indicates station is authorized * @sta_state: station state according to enum %ieee80211_sta_state * @bt_reduced_txpower: is reduced tx power enabled for this station * @next_status_eosp: the next reclaimed packet is a PS-Poll response and
@@ -409,6 +410,7 @@ struct iwl_mvm_sta {enum ieee80211_sta_state sta_state;bool bt_reduced_txpower;bool next_status_eosp; +bool authorized;spinlock_t lock;struct iwl_mvm_tid_data tid_data[IWL_MAX_TID_COUNT +1 ];u8 tid_to_baid[IWL_MAX_TID_COUNT ];
Signature · 1 line
2.38.1
PATCH 11/15 wifi: iwlwifi: fix iwl_mvm_max_amsdu_size() for MLO
In reply to [email protected]From: Johannes Berg <[email protected]>
For MLO, we cannot use vif->bss_conf.chandef.chan->band, since that will lead to a NULL-ptr dereference as bss_conf isn't used. However, in case of real MLO, we also need to take both LMACs into account if they exist, since the station might be active on both LMACs at the same time.
--- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 37 +++++++++++++++++++-- 1 file changed, 34 insertions(+), 3 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/tx.c +34 -3
@@ -804,10 +804,11 @@ unsigned int iwl_mvm_max_amsdu_size(struct iwl_mvm *mvm, struct ieee80211_sta *sta, unsigned int tid) {struct iwl_mvm_sta *mvmsta =iwl_mvm_sta_from_mac80211 (sta); -enum nl80211_band band = mvmsta->vif->bss_conf.chandef.chan->band;u8 ac = tid_to_mac80211_ac[tid]; +enum nl80211_band band;unsigned int txf; -int lmac =iwl_mvm_get_lmac_id (mvm->fw, band); +unsigned int val; +int lmac;/* For HE redirect to trigger based fifos */ if (sta->deflink.he_cap.has_he && !WARN_ON (!iwl_mvm_has_new_tx_api (mvm)))
@@ -821,7 +822,37 @@ unsigned int iwl_mvm_max_amsdu_size(struct iwl_mvm *mvm,* We also want to have the start of the next packet inside the * fifo to be able to send bursts. */ - return min_t(unsigned int, mvmsta->max_amsdu_len, + val = mvmsta->max_amsdu_len; + +if (hweight16 (sta->valid_links) <=1 ) { +if (sta->valid_links) { +struct ieee80211_bss_conf *link_conf; +unsigned int link =ffs (sta->valid_links) -1 ; + +rcu_read_lock (); + link_conf =rcu_dereference (mvmsta->vif->link_conf[link]); +if (WARN_ON (!link_conf)) + band =NL80211_BAND_2GHZ ; +else + band = link_conf->chandef.chan->band; +rcu_read_unlock (); + }else { + band = mvmsta->vif->bss_conf.chandef.chan->band; + } + + lmac =iwl_mvm_get_lmac_id (mvm->fw, band); + }else if (fw_has_capa (&mvm->fw->ucode_capa, +IWL_UCODE_TLV_CAPA_CDB_SUPPORT )) { +/* for real MLO restrict to both LMACs if they exist */ + lmac =IWL_LMAC_5G_INDEX ; + val = min_t(unsigned int, val, + mvm->fwrt.smem_cfg.lmac[lmac].txfifo_size[txf] -256 ); + lmac =IWL_LMAC_24G_INDEX ; + }else { + lmac =IWL_LMAC_24G_INDEX ; + } + + return min_t(unsigned int, val, mvm->fwrt.smem_cfg.lmac[lmac].txfifo_size[txf] -256 ); }
Signature · 1 line
2.38.1
PATCH 12/15 wifi: iwlwifi: mvm: configure TLC on link activation
In reply to [email protected]From: Johannes Berg <[email protected]>
If the AP station already exists on link activation (which means we're during link switch), configure the TLC in FW so we can immediately transmit once the link is activated.
--- .../wireless/intel/iwlwifi/mvm/mld-mac80211.c | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)
drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c +24 -0
@@ -256,6 +256,30 @@ __iwl_mvm_mld_assign_vif_chanctx(struct iwl_mvm *mvm,if (ret) goto out; +/* Initialize rate control for the AP station, since we might be +* doing a link switch here - we cannot initialize it before since +* this needs the phy context assigned (and in FW?), and we cannot +* do it later because it needs to be initialized as soon as we're +* able to TX on the link, i.e. when active. +* +* Firmware restart isn't quite correct yet for MLO, but we don't +* need to do it in that case anyway since it will happen from the +* normal station state callback. +*/ +if (mvmvif->ap_sta && + !test_bit (IWL_MVM_STATUS_IN_HW_RESTART , &mvm->status)) { +struct ieee80211_link_sta *link_sta; + +rcu_read_lock (); + link_sta =rcu_dereference (mvmvif->ap_sta->link[link_id]); + +if (!WARN_ON_ONCE (!link_sta)) +iwl_mvm_rs_rate_init (mvm, vif, mvmvif->ap_sta, + link_conf, link_sta, + phy_ctxt->channel->band); +rcu_read_unlock (); + } +/* then activate */ ret = iwl_mvm_link_changed(mvm, vif, link_conf, LINK_CONTEXT_MODIFY_ACTIVE |
Signature · 1 line
2.38.1
PATCH 13/15 wifi: iwlwifi: mvm: add MLO support to SF - use sta pointer
In reply to [email protected]From: Johannes Berg <[email protected]>
For MLO support, use the pointer to the peer MLD instead of the default link station id, since the default link is only used for non-MLO cases. Using the default link sta id is meaningless for MLO. Also remove the rcu protected section since we now avoid the lookup based on sta id.
--- drivers/net/wireless/intel/iwlwifi/mvm/sf.c | 29 ++++++--------------- 1 file changed, 8 insertions(+), 21 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/sf.c +8 -21
@@ -8,7 +8,7 @@/* For counting bound interfaces */ struct iwl_mvm_active_iface_iterator_data {struct ieee80211_vif *ignore_vif; -u8 sta_vif_ap_sta_id; +struct ieee80211_sta *sta_vif_ap_sta;enum iwl_sf_state sta_vif_state;u32 num_active_macs; };
@@ -30,7 +30,7 @@ static void iwl_mvm_bound_iface_iterator(void *_data, u8 *mac, data->num_active_macs++;if (vif->type ==NL80211_IFTYPE_STATION ) { - data->sta_vif_ap_sta_id = mvmvif->deflink.ap_sta_id; + data->sta_vif_ap_sta = mvmvif->ap_sta;if (vif->cfg.assoc) data->sta_vif_state =SF_FULL_ON ;else
@@ -172,13 +172,12 @@ static void iwl_mvm_fill_sf_command(struct iwl_mvm *mvm, } } -static int iwl_mvm_sf_config (struct iwl_mvm *mvm,u8 sta_id, +static int iwl_mvm_sf_config (struct iwl_mvm *mvm,struct ieee80211_sta *sta,enum iwl_sf_state new_state) {struct iwl_sf_cfg_cmd sf_cmd = { .state =cpu_to_le32 (new_state), }; -struct ieee80211_sta *sta;int ret =0 ;if (mvm->cfg->disable_dummy_notification)
@@ -196,20 +195,12 @@ static int iwl_mvm_sf_config(struct iwl_mvm *mvm, u8 sta_id,iwl_mvm_fill_sf_command (mvm, &sf_cmd,NULL );break ;case SF_FULL_ON : -if (sta_id ==IWL_MVM_INVALID_STA ) { +if (!sta) {IWL_ERR (mvm,"No station: Cannot switch SF to FULL_ON\n" );return -EINVAL ; } -rcu_read_lock (); - sta =rcu_dereference (mvm->fw_id_to_mac_id[sta_id]); -if (IS_ERR_OR_NULL (sta)) { -IWL_ERR (mvm,"Invalid station id\n" ); -rcu_read_unlock (); -return -EINVAL ; - }iwl_mvm_fill_sf_command (mvm, &sf_cmd, sta); -rcu_read_unlock ();break ;case SF_INIT_OFF :iwl_mvm_fill_sf_command (mvm, &sf_cmd,NULL );
@@ -237,13 +228,12 @@ int iwl_mvm_sf_update(struct iwl_mvm *mvm, struct ieee80211_vif *changed_vif, bool remove_vif) {enum iwl_sf_state new_state; -u8 sta_id =IWL_MVM_INVALID_STA ;struct iwl_mvm_vif *mvmvif =NULL ;struct iwl_mvm_active_iface_iterator_data data = { .ignore_vif = changed_vif, .sta_vif_state =SF_UNINIT , - .sta_vif_ap_sta_id =IWL_MVM_INVALID_STA , }; +struct ieee80211_sta *sta =NULL ;/* * Ignore the call if we are in HW Restart flow, or if the handled
@@ -273,7 +263,7 @@ int iwl_mvm_sf_update(struct iwl_mvm *mvm, struct ieee80211_vif *changed_vif,* and we filled the relevant data during iteration */ new_state = data.sta_vif_state; - sta_id = data.sta_vif_ap_sta_id; + sta = data.sta_vif_ap_sta; }else {if (WARN_ON (!changed_vif))return -EINVAL ;
@@ -282,7 +272,7 @@ int iwl_mvm_sf_update(struct iwl_mvm *mvm, struct ieee80211_vif *changed_vif, }else if (changed_vif->cfg.assoc && changed_vif->bss_conf.dtim_period) { mvmvif =iwl_mvm_vif_from_mac80211 (changed_vif); - sta_id = mvmvif->deflink.ap_sta_id; + sta = mvmvif->ap_sta; new_state =SF_FULL_ON ; }else { new_state =SF_INIT_OFF ;
@@ -294,8 +284,5 @@ int iwl_mvm_sf_update(struct iwl_mvm *mvm, struct ieee80211_vif *changed_vif, new_state =SF_UNINIT ; } -/* For MLO it's ok to use deflink->sta_id as it's needed only to get -* a pointer to mac80211 sta -*/ -return iwl_mvm_sf_config (mvm, sta_id, new_state); +return iwl_mvm_sf_config (mvm, sta, new_state); }
Signature · 1 line
2.38.1
PATCH 14/15 wifi: iwlwifi: mvm: check firmware response size
In reply to [email protected]From: Johannes Berg <[email protected]>
Check the firmware response size for responses to the memory read/write command in debugfs before using it.
--- drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c +10 -0
@@ -1961,6 +1961,11 @@ static ssize_t iwl_dbgfs_mem_read(struct file *file, char __user *user_buf,if (ret <0 )return ret; +if (iwl_rx_packet_payload_len (hcmd.resp_pkt) <sizeof (*rsp)) { + ret = -EIO ; + goto out; + } + rsp = (void *)hcmd.resp_pkt->data;if (le32_to_cpu (rsp->status) !=DEBUG_MEM_STATUS_SUCCESS ) { ret = -ENXIO ;
@@ -2037,6 +2042,11 @@ static ssize_t iwl_dbgfs_mem_write(struct file *file,if (ret <0 )return ret; +if (iwl_rx_packet_payload_len (hcmd.resp_pkt) <sizeof (*rsp)) { + ret = -EIO ; + goto out; + } + rsp = (void *)hcmd.resp_pkt->data;if (rsp->status !=DEBUG_MEM_STATUS_SUCCESS ) { ret = -ENXIO ;
Signature · 1 line
2.38.1
PATCH 15/15 wifi: iwlwifi: bump FW API to 78 for AX devices
In reply to [email protected]From: Gregory Greenman <[email protected]>
Start supporting API version 78 for AX devices.
--- drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/cfg/22000.c +1 -1
@@ -10,7 +10,7 @@#include "fw/api/txq.h" /* Highest firmware API version supported */ -#define IWL_22000_UCODE_API_MAX 77 +#define IWL_22000_UCODE_API_MAX 78/* Lowest firmware API version supported */ #define IWL_22000_UCODE_API_MIN 39
Signature · 1 line
2.38.1