Skip to contentSkip to conversation

reorder: improve buffer structure layout

PATCH Superseded Volodymyr Fialko 5 participants 8 messages Apr 14, 2023 – Jun 1, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reorder: improve buffer structure layout

Rearrange the reorder buffer structure to prevent padding to extra one cache line.

Current layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;
        int is_initialized;

// -> padding to cache align, eat whole line
};

New layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
        int is_initialized;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;

// -> no padding
};

---
 lib/reorder/rte_reorder.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/reorder/rte_reorder.c +2 -1
index f55f383700..7418202b04 100644
@@ -46,9 +46,10 @@ struct rte_reorder_buffer {
 	char name[RTE_REORDER_NAMESIZE];
 	uint32_t min_seqn;  /**< Lowest seq. number that can be in the buffer */
 	unsigned int memsize; /**< memory area size of reorder buffer */
+	int is_initialized; /**< flag indicates that buffer was initialized */
+
 	struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */
 	struct cir_buffer order_buf; /**< buffer used to reorder entries */
-	int is_initialized;
 } __rte_cache_aligned;
 
 static void
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 24 lines · Volodymyr Fialko

Rearrange the reorder buffer structure to prevent padding to extra one cache line.

Current layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;
        int is_initialized;

// -> padding to cache align, eat whole line
};

New layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
        int is_initialized;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;
Quoted 5 lines

// -> no padding
};

---

lib/reorder/rte_reorder.c struct rte_reorder_buffer { · line 50

Quoted 13 lines
 lib/reorder/rte_reorder.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/reorder/rte_reorder.c +2 -0
index f55f383700..7418202b04 100644
@@ -46,9 +46,10 @@ struct rte_reorder_buffer {
 	char name[RTE_REORDER_NAMESIZE];
 	uint32_t min_seqn;  /**< Lowest seq. number that can be in the buffer */
 	unsigned int memsize; /**< memory area size of reorder buffer */
+	int is_initialized; /**< flag indicates that buffer was initialized */
+

Since we are moving it, it might be an opportunity to change it from "int" to "bool".

Quoted 9 lines
lib/reorder/rte_reorder.c +0 -1
 	struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */
 	struct cir_buffer order_buf; /**< buffer used to reorder entries */
-	int is_initialized;
 } __rte_cache_aligned;
 
 static void
Signature · 1 line
2.34.1
#2 lore raw
Quoted 36 lines · Bruce Richardson
Quoted 24 lines · Volodymyr Fialko

Rearrange the reorder buffer structure to prevent padding to extra one cache line.

Current layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;
        int is_initialized;

// -> padding to cache align, eat whole line
};

New layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
        int is_initialized;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;
Quoted 5 lines

// -> no padding
};

---

Quoted 3 lines
 lib/reorder/rte_reorder.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 13 lines

lib/reorder/rte_reorder.c struct rte_reorder_buffer { · line 50

Quoted 10 lines
lib/reorder/rte_reorder.c +2 -0
index f55f383700..7418202b04 100644
@@ -46,9 +46,10 @@ struct rte_reorder_buffer {
 	char name[RTE_REORDER_NAMESIZE];
 	uint32_t min_seqn;  /**< Lowest seq. number that can be in the buffer */
 	unsigned int memsize; /**< memory area size of reorder buffer */
+	int is_initialized; /**< flag indicates that buffer was initialized */
+

Since we are moving it, it might be an opportunity to change it from "int" to "bool".

+1

Quoted 10 lines
Quoted 10 lines
lib/reorder/rte_reorder.c +0 -1
 	struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */
 	struct cir_buffer order_buf; /**< buffer used to reorder entries */
-	int is_initialized;
 } __rte_cache_aligned;
 
 static void
Signature · 1 line
2.34.1
#3 lore raw
In reply to Volodymyr Fialko
Quoted 6 lines · On Fri, 14 Apr 2023 10:43:43 +0200 Volodymyr Fialko <[email protected]> wrote:
lib/reorder/rte_reorder.c +0 -0
index f55f383700..7418202b04 100644
@@ -46,9 +46,10 @@ struct rte_reorder_buffer {
 	char name[RTE_REORDER_NAMESIZE];

lib/reorder/rte_reorder.c struct rte_reorder_buffer { · line 55

Quoted 10 lines
lib/reorder/rte_reorder.c +2 -1
 	uint32_t min_seqn;  /**< Lowest seq. number that can be in the buffer */
 	unsigned int memsize; /**< memory area size of reorder buffer */
+	int is_initialized; /**< flag indicates that buffer was initialized */
+
 	struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */
 	struct cir_buffer order_buf; /**< buffer used to reorder entries */
-	int is_initialized;
 } __rte_cache_aligned;
 
 static void

Since this is ABI change it will have to wait for 23.11 release

#4 lore raw
Quoted 18 lines · Stephen Hemminger
Quoted 15 lines · On Fri, 14 Apr 2023 10:43:43 +0200 Volodymyr Fialko <[email protected]> wrote:
lib/reorder/rte_reorder.c +2 -1
index f55f383700..7418202b04 100644
@@ -46,9 +46,10 @@ struct rte_reorder_buffer {
 	char name[RTE_REORDER_NAMESIZE];
 	uint32_t min_seqn;  /**< Lowest seq. number that can be in the buffer */
 	unsigned int memsize; /**< memory area size of reorder buffer */
+	int is_initialized; /**< flag indicates that buffer was initialized */
+
 	struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */
 	struct cir_buffer order_buf; /**< buffer used to reorder entries */
-	int is_initialized;
 } __rte_cache_aligned;
 
Quoted 3 lines

lib/reorder/rte_reorder.c struct rte_reorder_buffer { · line 55

Quoted 1 line
lib/reorder/rte_reorder.c +0 -0
 static void

Since this is ABI change it will have to wait for 23.11 release

It shouldn't be an ABI change. This struct is defined in a C file, rather than a header, so is not exposed to end applications.

/Bruce

#5 lore raw
Quoted 19 lines · On Fri, 14 Apr 2023 15:54:13 +0100 Bruce Richardson…
Quoted 18 lines · Stephen Hemminger
Quoted 15 lines · On Fri, 14 Apr 2023 10:43:43 +0200 Volodymyr Fialko <[email protected]> wrote:
lib/reorder/rte_reorder.c +2 -1
index f55f383700..7418202b04 100644
@@ -46,9 +46,10 @@ struct rte_reorder_buffer {
 	char name[RTE_REORDER_NAMESIZE];
 	uint32_t min_seqn;  /**< Lowest seq. number that can be in the buffer */
 	unsigned int memsize; /**< memory area size of reorder buffer */
+	int is_initialized; /**< flag indicates that buffer was initialized */
+
 	struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */
 	struct cir_buffer order_buf; /**< buffer used to reorder entries */
-	int is_initialized;
 } __rte_cache_aligned;
 
Quoted 8 lines
Quoted 3 lines

lib/reorder/rte_reorder.c struct rte_reorder_buffer { · line 55

Quoted 1 line
lib/reorder/rte_reorder.c +0 -0
 static void  

Since this is ABI change it will have to wait for 23.11 release

It shouldn't be an ABI change. This struct is defined in a C file, rather than a header, so is not exposed to end applications.

/Bruce

Sorry, Bruce is right.
You might want to use uint8_t or bool for a simple flag.

#6 lore raw

PATCH v2 1/1 reorder: improve buffer structure layout

In reply to Volodymyr Fialko

Rearrange the reorder buffer structure to prevent padding to extra one cache line.

Current layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;
        int is_initialized;

// -> padding to cache align, eat whole line
};

New layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
        bool is_initialized;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;

// -> no padding
};

---
v2:
- changed flag type to bool

 lib/reorder/rte_reorder.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/reorder/rte_reorder.c +2 -1
index f55f383700..4de1aa4056 100644
@@ -46,9 +46,10 @@ struct rte_reorder_buffer {
 	char name[RTE_REORDER_NAMESIZE];
 	uint32_t min_seqn;  /**< Lowest seq. number that can be in the buffer */
 	unsigned int memsize; /**< memory area size of reorder buffer */
+	bool is_initialized; /**< flag indicates that buffer was initialized */
+
 	struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */
 	struct cir_buffer order_buf; /**< buffer used to reorder entries */
-	int is_initialized;
 } __rte_cache_aligned;
 
 static void
Signature · 1 line
2.34.1
#7 lore raw

17/04/2023 11:12, Volodymyr Fialko:

Quoted 24 lines

Rearrange the reorder buffer structure to prevent padding to extra one cache line.

Current layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;
        int is_initialized;

// -> padding to cache align, eat whole line
};

New layout:

struct rte_reorder_buffer {
        char name[RTE_REORDER_NAMESIZE];
        uint32_t min_seqn;
        unsigned int memsize;
        bool is_initialized;
// -> padding to cache align (cir_buffer is also cache aligned)
        struct cir_buffer ready_buf;
        struct cir_buffer order_buf;
Quoted 5 lines

// -> no padding
};

Applied, thanks.