Skip to contentSkip to conversation

mtd: spi-nor: issi: add support for IS25WP01G

PATCH In review [email protected] 2 participants 2 messages Apr 17, 2023 – Apr 18, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spi-nor: issi: add support for IS25WP01G

From: Niravkumar L Rabara <[email protected]>

Tested on Intel N5X socdk board,
random data write, erase, read - verified erase operations random data write, read and compare - verified write/read operations

---

root@n5x:~# cat /sys/devices/platform/soc/ff8d2000.spi/spi_master/
spi0/spi0.0/spi-nor/jedec_id
9d701b
root@n5x:~# cat /sys/devices/platform/soc/ff8d2000.spi/spi_master/
spi0/spi0.0/spi-nor/manufacturer
issi
root@n5x:~# cat /sys/devices/platform/soc/ff8d2000.spi/spi_master/
spi0/spi0.0/spi-nor/partname
is25wp01g
root@n5x:~# hexdump /sys/devices/platform/soc/ff8d2000.spi/spi_master
/spi0/spi0.0/spi-nor/sfdp
0000000 4653 5044 0106 ff01 0600 1001 0030 ff00
0000010 0084 0201 0080 ff00 ffff ffff ffff ffff
0000020 ffff ffff ffff ffff ffff ffff ffff ffff
0000030 20e5 fffb ffff 3fff eb44 6b08 3b08 bb80
0000040 fffe ffff ffff ff00 ffff eb44 200c 520f
0000050 d810 ff00 4262 00a9 6482 d302 8dec 4c69
0000060 757a 757a a4f7 5cd5 c24a ff2c 30e1 a9fa
0000070 ffff ffff ffff ffff ffff ffff ffff ffff
0000080 eeff ffff 5c21 ffdc
0000088
root@n5x:~# md5sum /sys/devices/platform/soc/ff8d2000.spi/spi_master/
spi0/spi0.0/spi-nor/sfdp
83440c0ff8676fe5292d207788693900  /sys/devices/platform/soc/ff8d2000.
spi/spi_master/spi0/spi0.0/spi-nor/sfdp
---
 drivers/mtd/spi-nor/issi.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi-nor/issi.c +2 -0
index 400e2b42f45a..79132267cf0d 100644
@@ -64,6 +64,8 @@ static const struct flash_info issi_nor_parts[] = {
 		PARSE_SFDP
 		FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
 		.fixups = &is25lp256_fixups },
+	{ "is25wp01g",  INFO(0x9d701b, 0, 256 * 1024,  512)
+		PARSE_SFDP },
 	{ "is25wp032",  INFO(0x9d7016, 0, 64 * 1024,  64)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "is25wp064",  INFO(0x9d7017, 0, 64 * 1024, 128)
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 26 lines

From: Niravkumar L Rabara <[email protected]>

Tested on Intel N5X socdk board,
random data write, erase, read - verified erase operations random data write, read and compare - verified write/read operations

---

root@n5x:~# cat /sys/devices/platform/soc/ff8d2000.spi/spi_master/
spi0/spi0.0/spi-nor/jedec_id
9d701b
root@n5x:~# cat /sys/devices/platform/soc/ff8d2000.spi/spi_master/
spi0/spi0.0/spi-nor/manufacturer
issi
root@n5x:~# cat /sys/devices/platform/soc/ff8d2000.spi/spi_master/
spi0/spi0.0/spi-nor/partname
is25wp01g
root@n5x:~# hexdump /sys/devices/platform/soc/ff8d2000.spi/spi_master
/spi0/spi0.0/spi-nor/sfdp
0000000 4653 5044 0106 ff01 0600 1001 0030 ff00
0000010 0084 0201 0080 ff00 ffff ffff ffff ffff
0000020 ffff ffff ffff ffff ffff ffff ffff ffff
0000030 20e5 fffb ffff 3fff eb44 6b08 3b08 bb80
0000040 fffe ffff ffff ff00 ffff eb44 200c 520f
0000050 d810 ff00 4262 00a9 6482 d302 8dec 4c69
Quoted 8 lines
0000060 757a 757a a4f7 5cd5 c24a ff2c 30e1 a9fa
0000070 ffff ffff ffff ffff ffff ffff ffff ffff
0000080 eeff ffff 5c21 ffdc
0000088
root@n5x:~# md5sum /sys/devices/platform/soc/ff8d2000.spi/spi_master/
spi0/spi0.0/spi-nor/sfdp
83440c0ff8676fe5292d207788693900  /sys/devices/platform/soc/ff8d2000.
spi/spi_master/spi0/spi0.0/spi-nor/sfdp

Thanks for the dump!

Quoted 9 lines
---
 drivers/mtd/spi-nor/issi.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi-nor/issi.c +0 -0
index 400e2b42f45a..79132267cf0d 100644

drivers/mtd/spi-nor/issi.c static const struct flash_info issi_nor_parts[] = { · line 68

Quoted 5 lines
drivers/mtd/spi-nor/issi.c +2 -0
@@ -64,6 +64,8 @@ static const struct flash_info issi_nor_parts[] = {
 		PARSE_SFDP
 		FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
 		.fixups = &is25lp256_fixups },
+	{ "is25wp01g",  INFO(0x9d701b, 0, 256 * 1024,  512)
+		PARSE_SFDP },

There are no special flags, thus this flash should just work with the generic SPI-NOR driver [1]. No patch needed.

-michael

drivers/mtd/spi-nor/issi.c static const struct flash_info issi_nor_parts[] = { · line 71

Quoted 3 lines
drivers/mtd/spi-nor/issi.c +0 -0
 	{ "is25wp032",  INFO(0x9d7016, 0, 64 * 1024,  64)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "is25wp064",  INFO(0x9d7017, 0, 64 * 1024, 128)

[1] https://elixir.bootlin.com/linux/v6.3-rc7/source/drivers/mtd/spi-nor/core.c#L1637