xfs: scrub: remove duplicate include headers
PATCH 1/1 xfs: scrub: remove duplicate include headers
From: Ye Xingchen <[email protected]>
xfs_trans_resv.h and xfs_mount.h are included more than once.
Signed-off-by Ye Xingchen <[email protected]>
--- fs/xfs/scrub/health.c | 2 -- fs/xfs/scrub/refcount.c | 2 -- 2 files changed, 4 deletions(-)
fs/xfs/scrub/health.c +0 -2
@@ -7,8 +7,6 @@#include "xfs_fs.h" #include "xfs_shared.h" #include "xfs_format.h" -#include "xfs_trans_resv.h" -#include "xfs_mount.h" #include "xfs_btree.h" #include "xfs_trans_resv.h" #include "xfs_mount.h"
fs/xfs/scrub/refcount.c +0 -2
@@ -7,8 +7,6 @@#include "xfs_fs.h" #include "xfs_shared.h" #include "xfs_format.h" -#include "xfs_trans_resv.h" -#include "xfs_mount.h" #include "xfs_btree.h" #include "xfs_rmap.h" #include "xfs_refcount.h"
Signature · 1 line
2.25.1
Quoted 5 lines · On Mon, Apr 17, 2023 at 04:13:07PM +0800, [email protected] wrote:
From: Ye Xingchen <[email protected]>
xfs_trans_resv.handxfs_mount.hare included more than once.Signed-off-by Ye Xingchen <[email protected]>
Yes they are, but it's already been fixed:
https://lore.kernel.org/linux-xfs/[email protected]/
-Dave.
Signature · 2 lines
Dave Chinner [email protected]
Quoted 15 lines · On Mon, Apr 17, 2023 at 04:13:07PM +0800, [email protected] wrote:
From: Ye Xingchen <[email protected]>
xfs_trans_resv.handxfs_mount.hare included more than once.Signed-off-by Ye Xingchen <[email protected]>--- fs/xfs/scrub/health.c | 2 -- fs/xfs/scrub/refcount.c | 2 -- 2 files changed, 4 deletions(-)fs/xfs/scrub/health.c +0
-0
fs/xfs/scrub/health.c line 12
Quoted 8 lines
fs/xfs/scrub/health.c +0
-2@@ -7,8 +7,6 @@#include "xfs_fs.h" #include "xfs_shared.h" #include "xfs_format.h" -#include "xfs_trans_resv.h" -#include "xfs_mount.h" #include "xfs_btree.h" #include "xfs_trans_resv.h" #include "xfs_mount.h"
The convention (AFAICT) for include order is xfs_trans_resv -> xfs_mount -> xfs_btree.h...
fs/xfs/scrub/refcount.c
Quoted 4 lines
fs/xfs/scrub/refcount.c +0
-0
Please check the list before sending duplicate diffs.
--D
Quoted 11 lines
fs/xfs/scrub/refcount.c +0
-2@@ -7,8 +7,6 @@#include "xfs_fs.h" #include "xfs_shared.h" #include "xfs_format.h" -#include "xfs_trans_resv.h" -#include "xfs_mount.h" #include "xfs_btree.h" #include "xfs_rmap.h" #include "xfs_refcount.h" Signature · 1 line
2.25.1