mm/slab: trivial fixup for SLAB_TYPESAFE_BY_RCU example code snippet
Subsystems (2)
v3 cover mm/slab: trivial fixup for SLAB_TYPESAFE_BY_RCU example code snippet
Changes from v2
(https://lore.kernel.org/linux-mm/[email protected]/)
- Wordsmith commit message of the second patch (Valstimil Babka)
Changes from v1
(https://lore.kernel.org/linux-mm/[email protected]/)
- Update label (s/again/begin/) correctly (Matthew Wilcox)
- Add missed rcu_read_unlock()
This patchset is for trivial fixup for SLAB_TYPESAFE_BY_RCU example code snippet, namely adding missed semicolon and breaking RCU read-side critical section into smaller ones.
SeongJae Park (2):
mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code
include/linux/slab.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1
PATCH v3 1/2 mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code
An example code snippet for SLAB_TYPESAFE_BY_RCU is missing a semicolon. Add it.
--- include/linux/slab.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/slab.h +1 -1
@@ -53,7 +53,7 @@* stays valid, the trick to using this is relying on an independent * object validation pass. Something like: * -* rcu_read_lock() +* rcu_read_lock(); * again: * obj = lockless_lookup(key); * if (obj) {
Signature · 1 line
2.25.1
PATCH v3 2/2 mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code
In reply to SeongJae ParkThe SLAB_TYPESAFE_BY_RCU example code snippet uses a single RCU read-side critical section for retries. 'Documentation/RCU/rculist_nulls.rst' has similar example code snippet, and commit da82af04352b ("doc: Update and wordsmith rculist_nulls.rst") has broken it up. Apply the change to SLAB_TYPESAFE_BY_RCU example code snippet, too.
--- include/linux/slab.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
include/linux/slab.h +5 -3
@@ -53,16 +53,18 @@* stays valid, the trick to using this is relying on an independent * object validation pass. Something like: * +* begin: * rcu_read_lock(); -* again: * obj = lockless_lookup(key); * if (obj) { * if (!try_get_ref(obj)) // might fail for free objects -* goto again; +* rcu_read_unlock(); +* goto begin; * * if (obj->key != key) { // not the object we expected * put_ref(obj); -* goto again; +* rcu_read_unlock(); +* goto begin; * } * } * rcu_read_unlock();
Signature · 1 line
2.25.1