Skip to contentSkip to conversation

net: hyperv: select CONFIG_NLS for mac address setting

PATCH In review Arnd Bergmann 3 participants 3 messages Apr 17, 2023 – Apr 19, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: hyperv: select CONFIG_NLS for mac address setting

From: Arnd Bergmann <[email protected]>

A rare randconfig build error happens when this driver is enabled, but nothing else enables NLS support:

x86_64-linux-ld: drivers/net/hyperv/rndis_filter.o: in function `rndis_filter_set_device_mac':
rndis_filter.c:(.text+0x1536): undefined reference to `utf8s_to_utf16s'

This is normally selected by PCI, USB, ACPI, or common file systems. Since the dependency on ACPI is now gone, NLS has to be selected here directly.

Fixes 38299f300c12 ("Driver: VMBus: Add Devicetree support")
---
 drivers/net/hyperv/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/hyperv/Kconfig +1 -0
index ca7bf7f897d3..924dad26ad47 100644
@@ -2,6 +2,7 @@
 config HYPERV_NET
 	tristate "Microsoft Hyper-V virtual network driver"
 	depends on HYPERV
+	select NLS
 	select UCS2_STRING
 	help
 	  Select this option to enable the Hyper-V virtual network driver.
Signature · 1 line
2.39.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Mon, 17 Apr 2023 22:55:48 +0200 Arnd Bergmann wrote:

From: Arnd Bergmann <[email protected]>

A rare randconfig build error happens when this driver is enabled, but nothing else enables NLS support:

x86_64-linux-ld: drivers/net/hyperv/rndis_filter.o: in function `rndis_filter_set_device_mac':
rndis_filter.c:(.text+0x1536): undefined reference to `utf8s_to_utf16s'

Quoted 6 lines

This is normally selected by PCI, USB, ACPI, or common file systems. Since the dependency on ACPI is now gone, NLS has to be selected here directly.

Fixes 38299f300c12 ("Driver: VMBus: Add Devicetree support")

I'm assuming Wei will take this since the offending commit doesn't exist in netdev, yet:

Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A rare randconfig build error happens when this driver is enabled, but nothing else enables NLS support:

x86_64-linux-ld: drivers/net/hyperv/rndis_filter.o: in function `rndis_filter_set_device_mac':
rndis_filter.c:(.text+0x1536): undefined reference to `utf8s_to_utf16s'

Quoted 6 lines

This is normally selected by PCI, USB, ACPI, or common file systems. Since the dependency on ACPI is now gone, NLS has to be selected here directly.

Fixes 38299f300c12 ("Driver: VMBus: Add Devicetree support")