media: nxp: ignore unused suspend operations
Subsystems (3)
PATCH v3 1/1 media: nxp: ignore unused suspend operations
From: Arnd Bergmann <[email protected]>
gcc warns about some functions being unused when CONFIG_PM_SLEEP is disabled:
drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c:328:12: error: 'mxc_isi_pm_resume' defined but not used [-Werror=unused-function]
328 | static int mxc_isi_pm_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c:314:12: error: 'mxc_isi_pm_suspend' defined but not used [-Werror=unused-function]
314 | static int mxc_isi_pm_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~Use the modern SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() helpers in place of the old SET_SYSTEM_SLEEP_PM_OPS()/SET_RUNTIME_PM_OPS() ones.
By convention, use pm_ptr() to guard the reference to the operations. This makes no difference as long as the driver requires CONFIG_PM, but is what users of SET_RUNTIME_PM_OPS() are supposed to do.
---
v3: update changelog text
v2: Laurent and me both sent a v1
--- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +3 -3
@@ -378,8 +378,8 @@ static int mxc_isi_runtime_resume(struct device *dev) }static const struct dev_pm_ops mxc_isi_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(mxc_isi_pm_suspend, mxc_isi_pm_resume) -SET_RUNTIME_PM_OPS (mxc_isi_runtime_suspend, mxc_isi_runtime_resume,NULL ) + SYSTEM_SLEEP_PM_OPS(mxc_isi_pm_suspend, mxc_isi_pm_resume) +RUNTIME_PM_OPS (mxc_isi_runtime_suspend, mxc_isi_runtime_resume,NULL ) };/* -----------------------------------------------------------------------------
@@ -528,7 +528,7 @@ static struct platform_driver mxc_isi_driver = { .driver = { .of_match_table = mxc_isi_of_match, .name = MXC_ISI_DRIVER_NAME, - .pm = &mxc_isi_pm_ops, + .pm = pm_ptr(&mxc_isi_pm_ops), } };module_platform_driver (mxc_isi_driver);
Signature · 1 line
2.39.2