ntfs: remove redundant initialization to pointer cb_sb_start
Subsystems (2)
PATCH 1/1 ntfs: remove redundant initialization to pointer cb_sb_start
The pointer cb_sb_start is being initialized with a value that is never read, it is being re-assigned the same value later on when it is first being used. The initialization is redundant and can be removed.
Cleans up clang scan build warning:fs/ntfs/compress.c:164:6: warning: Value stored to 'cb_sb_start' during its initialization is never read [deadcode.DeadStores]
u8 *cb_sb_start = cb; /* Beginning of the current sb in the cb. */
--- fs/ntfs/compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ntfs/compress.c +1 -1
@@ -161,7 +161,7 @@ static int ntfs_decompress(struct page *dest_pages[], int completed_pages[],*/ u8 *cb_end = cb_start + cb_size;/* End of cb. */ u8 *cb = cb_start;/* Current position in cb. */ -u8 *cb_sb_start = cb;/* Beginning of the current sb in the cb. */ +u8 *cb_sb_start;/* Beginning of the current sb in the cb. */ u8 *cb_sb_end;/* End of current sb / beginning of next sb. */ /* Variables for uncompressed data / destination. */
Signature · 1 line
2.30.2
2023-04-19 0:36 GMT+09:00, Colin Ian King <[email protected]>:
Quoted 11 lines
The pointer
cb_sb_startis being initialized with a value that is never read, it is being re-assigned the same value later on when it is first being used. The initialization is redundant and can be removed.Cleans up clang scan build warning:
fs/ntfs/compress.c:164:6: warning: Value stored to 'cb_sb_start' during its initialization is never read [deadcode.DeadStores]
u8*cb_sb_start= cb; /* Beginning of the current sb in the cb.
*/Signed-off-by Colin Ian King <[email protected]>
Christian Brauner
AppliedQuoted 9 lines · Colin Ian King
The pointer
cb_sb_startis being initialized with a value that is never read, it is being re-assigned the same value later on when it is first being used. The initialization is redundant and can be removed.Cleans up clang scan build warning:
fs/ntfs/compress.c:164:6: warning: Value stored to 'cb_sb_start' during its initialization is never read [deadcode.DeadStores]
u8*cb_sb_start= cb; /* Beginning of the current sb in the cb. */[...]
Applied to the fs.ntfs branch of the vfs/vfs.git tree. Patches in the fs.ntfs branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: fs.ntfs
[1/1] ntfs: remove redundant initialization to pointer cb_sb_start
https://git.kernel.org/vfs/vfs/c/04faa6cfd449