More MTL WA and powerwell patches
Subsystems (3)
v2 cover More MTL WA and powerwell patches
This series adds 2 MTL WA's and 2 patches to fix re-use "DC off" power wells.
v2:
Haridhar Kalvala (1):
drm/i915/mtl: WA to clear RDOP clock gating
Madhumitha Tolakanahalli Pradeep (1):
drm/i915/mtl: Extend Wa_22011802037 to MTL A-step
Matt Roper (2):
drm/i915: Use separate "DC off" power well for ADL-P and DG2 drm/i915/mtl: Re-use ADL-P's "DC off" power well
.../i915/display/intel_display_power_map.c | 57 +++++++++++++------ drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 + .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 ++-- 3 files changed, 48 insertions(+), 24 deletions(-)
Signature · 1 line
2.34.1
PATCH v2 1/4 drm/i915: Use separate "DC off" power well for ADL-P and DG2
From: Matt Roper <[email protected]>
Although ADL-P and DG2 both use the same general power well setup, the DC5/DC6 requirements are slightly different which means each platform should have its own "DC off" power well.
DG2 (i.e., Xe_HPD IP) requires that DC5 be disabled whenever PG2 is active. However ADL-P (i.e., Xe_LPD IP) only requires DC5/DC6 to be disabled when the PGC or PGD subwells are active; we should be able to remain in these DC states when PGB and general PG2 functionality is in use.
v2: Use dc_of as power well name.
Move xehpd power domain definitions near power well definition.(Imre)
Bspec: 49193
--- .../i915/display/intel_display_power_map.c | 41 +++++++++++++++++-- 1 file changed, 38 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +38 -3
@@ -1301,7 +1301,8 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_2,*/ I915_DECL_PW_DOMAINS(xelpd_pwdoms_dc_off, - XELPD_PW_2_POWER_DOMAINS, + XELPD_PW_C_POWER_DOMAINS, + XELPD_PW_D_POWER_DOMAINS, POWER_DOMAIN_PORT_DSI, POWER_DOMAIN_AUDIO_MMIO, POWER_DOMAIN_AUX_A,
@@ -1310,14 +1311,18 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_dc_off, POWER_DOMAIN_DC_OFF, POWER_DOMAIN_INIT); -static const struct i915_power_well_desc xelpd_power_wells_main[] = { +static const struct i915_power_well_desc xelpd_power_wells_dc_off[] = { { .instances = &I915_PW_INSTANCES (I915_PW ("DC_off" , &xelpd_pwdoms_dc_off, .id = SKL_DISP_DC_OFF), ), .ops = &gen9_dc_off_power_well_ops, - }, { + } +}; + +static const struct i915_power_well_desc xelpd_power_wells_main[] = { + { .instances = &I915_PW_INSTANCES( I915_PW("PW_2", &xelpd_pwdoms_pw_2, .hsw.idx = ICL_PW_CTL_IDX_PW_2,
@@ -1400,6 +1405,34 @@ static const struct i915_power_well_desc xelpd_power_wells_main[] = {static const struct i915_power_well_desc_list xelpd_power_wells[] = {I915_PW_DESCRIPTORS (i9xx_power_wells_always_on),I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (xelpd_power_wells_dc_off), +I915_PW_DESCRIPTORS (xelpd_power_wells_main), +}; + +I915_DECL_PW_DOMAINS (xehpd_pwdoms_dc_off, +XELPD_PW_2_POWER_DOMAINS , +POWER_DOMAIN_PORT_DSI , +POWER_DOMAIN_AUDIO_MMIO , +POWER_DOMAIN_AUX_A , +POWER_DOMAIN_AUX_B , +POWER_DOMAIN_MODESET , +POWER_DOMAIN_DC_OFF , +POWER_DOMAIN_INIT ); + +static const struct i915_power_well_desc xehpd_power_wells_dc_off[] = { + { + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &xehpd_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), + .ops = &gen9_dc_off_power_well_ops, + } +}; + +static const struct i915_power_well_desc_list xehpd_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (xehpd_power_wells_dc_off),I915_PW_DESCRIPTORS (xelpd_power_wells_main), };
@@ -1624,6 +1657,8 @@ int intel_display_power_map_init(struct i915_power_domains *power_domains)if (DISPLAY_VER (i915) >=14 )return set_power_wells (power_domains, xelpdp_power_wells); +else if (IS_DG2 (i915)) +return set_power_wells (power_domains, xehpd_power_wells);else if (DISPLAY_VER (i915) >=13 )return set_power_wells (power_domains, xelpd_power_wells);else if (IS_DG1 (i915))
Signature · 1 line
2.34.1
PATCH v2 2/4 drm/i915/mtl: Re-use ADL-P's "DC off" power well
In reply to Radhakrishna SripadaFrom: Matt Roper <[email protected]>
As with ADL-P, MTL's "DC off" power well should be a dependency of the PGC and PGD power wells, not the entire PG2 well. In fact, the DC5/DC6 requirements between the two platforms are the same, so the Xe_LPD "DC off" well definition can just be re-used for Xe_LPD+.
Bspec: 49193
--- .../drm/i915/display/intel_display_power_map.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +1 -15
@@ -1456,15 +1456,6 @@ I915_DECL_PW_DOMAINS(xelpdp_pwdoms_pw_2,XELPDP_PW_2_POWER_DOMAINS , POWER_DOMAIN_INIT); -I915_DECL_PW_DOMAINS (xelpdp_pwdoms_dc_off, -XELPDP_PW_2_POWER_DOMAINS , -POWER_DOMAIN_AUDIO_MMIO , -POWER_DOMAIN_MODESET , -POWER_DOMAIN_AUX_A , -POWER_DOMAIN_AUX_B , -POWER_DOMAIN_DC_OFF , -POWER_DOMAIN_INIT ); -I915_DECL_PW_DOMAINS (xelpdp_pwdoms_aux_tc1,POWER_DOMAIN_AUX_USBC1 ,POWER_DOMAIN_AUX_TBT1 );
@@ -1483,12 +1474,6 @@ I915_DECL_PW_DOMAINS(xelpdp_pwdoms_aux_tc4,static const struct i915_power_well_desc xelpdp_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( -I915_PW ("DC_off" , &xelpdp_pwdoms_dc_off, - .id = SKL_DISP_DC_OFF), - ), - .ops = &gen9_dc_off_power_well_ops, - }, { .instances = &I915_PW_INSTANCES( I915_PW("PW_2", &xelpdp_pwdoms_pw_2, .hsw.idx = ICL_PW_CTL_IDX_PW_2,
@@ -1545,6 +1530,7 @@ static const struct i915_power_well_desc xelpdp_power_wells_main[] = {static const struct i915_power_well_desc_list xelpdp_power_wells[] = {I915_PW_DESCRIPTORS (i9xx_power_wells_always_on),I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (xelpd_power_wells_dc_off),I915_PW_DESCRIPTORS (xelpdp_power_wells_main), };
Signature · 1 line
2.34.1
PATCH v2 3/4 drm/i915/mtl: Extend Wa_22011802037 to MTL A-step
In reply to Radhakrishna SripadaFrom: Madhumitha Tolakanahalli Pradeep <[email protected]>
Wa_22011802037 was being applied to all graphics_ver 11 & 12. This patch updates the if statement to apply the W/A to right platforms and extends it to MTL-M:A step.
v1.1: Fix checkpatch warning.
v2: Change the check to reflect the wa at other palces(Lucas)
--- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +6 -6
@@ -1629,16 +1629,16 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub)static void guc_engine_reset_prepare (struct intel_engine_cs *engine) { -if (!IS_GRAPHICS_VER (engine->i915,11 ,12 )) -return ; - -intel_engine_stop_cs (engine); -/* * Wa_22011802037: In addition to stopping the cs, we need * to wait for any pending mi force wakeups */ -intel_engine_wait_for_pending_mi_fw (engine); +if (IS_MTL_GRAPHICS_STEP (engine->i915,M ,STEP_A0 ,STEP_B0 ) || + (GRAPHICS_VER (engine->i915) >=11 && +GRAPHICS_VER_FULL (engine->i915) <IP_VER (12 ,70 ))) { +intel_engine_stop_cs (engine); +intel_engine_wait_for_pending_mi_fw (engine); + } }static void guc_reset_nop (struct intel_engine_cs *engine)
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step
Quoted 6 lines · Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep <[email protected]>
Wa_22011802037was being applied to allgraphics_ver11 & 12. This patch updates the if statement to apply the W/A to right platforms and extends it to MTL-M:A step.
Bspec: 53509
Quoted 2 lines
v1.1: Fix checkpatch warning.
v2: Change the check to reflect the wa at other palces(Lucas)
s/palces/places.
Quoted 3 lines
Cc Lucas De Marchi <[email protected]>Cc Umesh Nerlige Ramappa <[email protected]>
With that.
Quoted 36 lines
Signed-off-by Madhumitha Tolakanahalli Pradeep <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +6
-6@@ -1629,16 +1629,16 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub)static void guc_engine_reset_prepare (struct intel_engine_cs *engine) { -if (!IS_GRAPHICS_VER (engine->i915,11 ,12 )) -return ; - -intel_engine_stop_cs (engine); -/* * Wa_22011802037: In addition to stopping the cs, we need * to wait for any pending mi force wakeups */ -intel_engine_wait_for_pending_mi_fw (engine); +if (IS_MTL_GRAPHICS_STEP (engine->i915,M ,STEP_A0 ,STEP_B0 ) || + (GRAPHICS_VER (engine->i915) >=11 && +GRAPHICS_VER_FULL (engine->i915) <IP_VER (12 ,70 ))) { +intel_engine_stop_cs (engine); +intel_engine_wait_for_pending_mi_fw (engine); + } }static void guc_reset_nop (struct intel_engine_cs *engine)Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step
Quoted 8 lines · Matt Atwood
Quoted 6 lines · Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep <[email protected]>
Wa_22011802037was being applied to allgraphics_ver11 & 12. This patch updates the if statement to apply the W/A to right platforms and extends it to MTL-M:A step.Bspec: 53509
Quoted 10 lines
Quoted 2 lines
v1.1: Fix checkpatch warning.
v2: Change the check to reflect the wa at other palces(Lucas)s/palces/places.
Quoted 3 lines
Cc Lucas De Marchi <[email protected]>Cc Umesh Nerlige Ramappa <[email protected]>With that.
Reviewed-by Matt Atwood <[email protected]>Quoted 2 lines
Signed-off-by Madhumitha Tolakanahalli Pradeep <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>
It doesn't look like this patch is complete? It's only changing one condition for Wa_22011802037, even though there are several in the code. From a quick grep, you're still missing updates for at least guc_ctl_wa_flags, execlists_reset_prepare, and __intel_engine_stop_cs.
Since this workaround is a complicated one that touches so many areas of the code, and has a complex platform list, it's probably time to factor the condition out into a needs_wa_22011802037() helper or something.
Matt
Quoted 34 lines
Quoted 34 lines
--- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +6
-6@@ -1629,16 +1629,16 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub)static void guc_engine_reset_prepare (struct intel_engine_cs *engine) { -if (!IS_GRAPHICS_VER (engine->i915,11 ,12 )) -return ; - -intel_engine_stop_cs (engine); -/* * Wa_22011802037: In addition to stopping the cs, we need * to wait for any pending mi force wakeups */ -intel_engine_wait_for_pending_mi_fw (engine); +if (IS_MTL_GRAPHICS_STEP (engine->i915,M ,STEP_A0 ,STEP_B0 ) || + (GRAPHICS_VER (engine->i915) >=11 && +GRAPHICS_VER_FULL (engine->i915) <IP_VER (12 ,70 ))) { +intel_engine_stop_cs (engine); +intel_engine_wait_for_pending_mi_fw (engine); + } }static void guc_reset_nop (struct intel_engine_cs *engine)Signature · 1 line
2.34.1
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step
Quoted 17 lines · Matt Roper
Quoted 16 lines · Matt Atwood
Quoted 6 lines · Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep <[email protected]>
Wa_22011802037was being applied to allgraphics_ver11 & 12. This patch updates the if statement to apply the W/A to right platforms and extends it to MTL-M:A step.Bspec: 53509
Quoted 2 lines
v1.1: Fix checkpatch warning.
v2: Change the check to reflect the wa at other palces(Lucas)s/palces/places.
Quoted 3 lines
Cc Lucas De Marchi <[email protected]>Cc Umesh Nerlige Ramappa <[email protected]>With that.
Reviewed-by Matt Atwood <[email protected]>
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Madhumitha Tolakanahalli Pradeep <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>It doesn't look like this patch is complete? It's only changing one condition for
Wa_22011802037, even though there are several in the code. From a quick grep, you're still missing updates for at leastguc_ctl_wa_flags,execlists_reset_prepare, and__intel_engine_stop_cs.
Actually, scratch that. Those other spots already have a MTL clause as part of the condition. But in that case it means the commit message here is inaccurate; you're not extending this workaround to MTL a-step because that already happened on a previous patch. You're just providing a fix for an incomplete implementation that happened earlier. The commit message should be explaining that.
Quoted 4 lines
Since this workaround is a complicated one that touches so many areas of the code, and has a complex platform list, it's probably time to factor the condition out into a
needs_wa_22011802037()helper or something.
I still suggest doing this, especially since we've clearly screwed up the handling of this workaround at least once already.
Matt
Quoted 44 lines
Matt
Quoted 34 lines
Quoted 34 lines
--- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +6
-6@@ -1629,16 +1629,16 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub)static void guc_engine_reset_prepare (struct intel_engine_cs *engine) { -if (!IS_GRAPHICS_VER (engine->i915,11 ,12 )) -return ; - -intel_engine_stop_cs (engine); -/* * Wa_22011802037: In addition to stopping the cs, we need * to wait for any pending mi force wakeups */ -intel_engine_wait_for_pending_mi_fw (engine); +if (IS_MTL_GRAPHICS_STEP (engine->i915,M ,STEP_A0 ,STEP_B0 ) || + (GRAPHICS_VER (engine->i915) >=11 && +GRAPHICS_VER_FULL (engine->i915) <IP_VER (12 ,70 ))) { +intel_engine_stop_cs (engine); +intel_engine_wait_for_pending_mi_fw (engine); + } }static void guc_reset_nop (struct intel_engine_cs *engine)Signature · 1 line
2.34.1Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step
Quoted 47 lines
-----Original Message-----
From: Roper, Matthew D <[email protected]>
Sent: Friday, April 21, 2023 8:09 AM
To: Atwood, Matthew S <[email protected]>
Cc: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: ExtendWa_22011802037to MTL A-stepQuoted 3 lines · Matt Roper
Quoted 2 lines · Matt Atwood
Quoted 1 line · Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Wa_22011802037was being applied to allgraphics_ver11 & 12. This patch updates the if statement to apply the W/A to right platforms and extends it to MTL-M:A step.Bspec: 53509
Quoted 2 lines
v1.1: Fix checkpatch warning.
v2: Change the check to reflect the wa at other palces(Lucas)Quoted 7 lines
Quoted 7 lines
s/palces/places.
Quoted 3 lines
Cc Lucas De Marchi <[email protected]>Cc Umesh Nerlige Ramappa <[email protected]>With that.
Reviewed-by Matt Atwood <[email protected]>Quoted 1 line
Signed-off-by Madhumitha Tolakanahalli PradeepQuoted 6 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Radhakrishna Sripada <[email protected]>It doesn't look like this patch is complete? It's only changing one condition for
Wa_22011802037, even though there are several in the code. From a quick grep, you're still missing updates for at leastguc_ctl_wa_flags,execlists_reset_prepare, and__intel_engine_stop_cs.Actually, scratch that. Those other spots already have a MTL clause as part of the condition. But in that case it means the commit message here is inaccurate; you're not extending this workaround to MTL a-step because that already happened on a previous patch. You're just providing a fix for an incomplete implementation that happened earlier. The commit message should be explaining that.
Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Since this workaround is a complicated one that touches so many areas of the code, and has a complex platform list, it's probably time to factor the condition out into a
needs_wa_22011802037()helper or something.I still suggest doing this, especially since we've clearly screwed up the handling of this workaround at least once already.
Sure Matt. With the patch already merged, I will handle this as a separate patch.
- Radhakrishna(RK) Sripada
Quoted 55 lines
Matt
Quoted 9 lines
Matt
Quoted 5 lines
Review
Quoted 5 lines
--- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.cQuoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c static void guc_reset_state(struct
Quoted 4 lines
index
88e881b100cf..ee3e8352637f100644drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0
-0@@ -1629,16 +1629,16 @@ static void guc_reset_state(struct
intel_context*ce, u32 head, bool scrub)Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +6
-6static void guc_engine_reset_prepare (struct intel_engine_cs *engine) { -if (!IS_GRAPHICS_VER (engine->i915,11 ,12 )) -return ; - -intel_engine_stop_cs (engine); -/* * Wa_22011802037: In addition to stopping the cs, we need * to wait for any pending mi force wakeups */ -intel_engine_wait_for_pending_mi_fw (engine); +if (IS_MTL_GRAPHICS_STEP (engine->i915,M ,STEP_A0 ,STEP_B0 ) || + (GRAPHICS_VER (engine->i915) >=11 && +GRAPHICS_VER_FULL (engine->i915) <IP_VER (12 ,70 ))) { +intel_engine_stop_cs (engine); +intel_engine_wait_for_pending_mi_fw (engine); + } }Quoted 10 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +0
-1static void guc_reset_nop (struct intel_engine_cs *engine) --2.34.1
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
PATCH v2 4/4 drm/i915/mtl: WA to clear RDOP clock gating
In reply to Radhakrishna SripadaFrom: Haridhar Kalvala <[email protected]>
Workaround implementation to clear RDOP clock gating.
Bspec: 33453
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/gt/intel_workarounds.c +3 -0
@@ -1703,6 +1703,9 @@ xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)/* Wa_18018781329 */ wa_mcr_write_or (wal,RENDER_MOD_CTRL ,FORCE_MISS_FTLB );wa_mcr_write_or (wal,COMP_MOD_CTRL ,FORCE_MISS_FTLB ); + +/* Wa_14015795083 */ +wa_write_clr (wal,GEN7_MISCCPCTL ,GEN12_DOP_CLOCK_GATE_RENDER_ENABLE ); }/*
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/mtl: WA to clear RDOP clock gating
Quoted 5 lines · Radhakrishna Sripada
From: Haridhar Kalvala <[email protected]>
Workaround implementation to clear RDOP clock gating.
Bspec: 33453
A better bspec value here is 53509, you're referencing a non-updating page
Quoted 1 line
With that.
Quoted 23 lines
Signed-off-by Haridhar Kalvala <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/i915/gt/intel_workarounds.c +3
-0@@ -1703,6 +1703,9 @@ xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)/* Wa_18018781329 */ wa_mcr_write_or (wal,RENDER_MOD_CTRL ,FORCE_MISS_FTLB );wa_mcr_write_or (wal,COMP_MOD_CTRL ,FORCE_MISS_FTLB ); + +/* Wa_14015795083 */ +wa_write_clr (wal,GEN7_MISCCPCTL ,GEN12_DOP_CLOCK_GATE_RENDER_ENABLE ); }/* Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/mtl: WA to clear RDOP clock gating
Thank you for the review. Merged both the workarounds with updated Bspec page.
- Radhakrishna(RK) Sripada
Quoted 47 lines
-----Original Message-----
From: Atwood, Matthew S <[email protected]>
Sent: Wednesday, April 19, 2023 2:49 PM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/mtl: WA to clear RDOP clock gatingQuoted 5 lines · Radhakrishna Sripada
From: Haridhar Kalvala <[email protected]>
Workaround implementation to clear RDOP clock gating.
Bspec: 33453
A better bspec value here is 53509, you're referencing a non-updating page
Quoted 1 line
With that.
Reviewed-by Matt Atwood <[email protected]>Review
Quoted 7 lines
Signed-off-by Haridhar Kalvala <[email protected]>Signed-off-by Radhakrishna Sripada <[email protected]>--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 1 file changed, 3 insertions(+)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/gt/intel_workarounds.cdrivers/gpu/drm/i915/gt/intel_workarounds.c xelpg_gt_workarounds_init(struct intel_gt *gt,
Quoted 4 lines
index
b925ef47304b..312eb8b5f949100644drivers/gpu/drm/i915/gt/intel_workarounds.c +0
-0@@ -1703,6 +1703,9 @@ xelpg_gt_workarounds_init(struct intel_gt *gt,struct
i915_wa_list*wal)drivers/gpu/drm/i915/gt/intel_workarounds.c xelpg_gt_workarounds_init(struct intel_gt *gt, · line 1704
Quoted 2 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +0
-0/* Wa_18018781329 */ wa_mcr_write_or(wal, RENDER_MOD_CTRL,
FORCE_MISS_FTLB);drivers/gpu/drm/i915/gt/intel_workarounds.c xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
Quoted 4 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +3
-0wa_mcr_write_or (wal,COMP_MOD_CTRL ,FORCE_MISS_FTLB ); + +/* Wa_14015795083 */ + wa_write_clr(wal, GEN7_MISCCPCTL,
GEN12_DOP_CLOCK_GATE_RENDER_ENABLE);Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +0
-1}/* -- 2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More MTL WA and powerwell patches (rev3)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: More MTL WA and powerwell patches (rev3)
URL : https://patchwork.freedesktop.org/series/115292/
State : warning
== Summary ==
Error: dim checkpatch failed92386c5cacda drm/i915: Use separate "DC off" power well for ADL-P and DG2 -:68: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #68: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1413:
+I915_DECL_PW_DOMAINS(xehpd_pwdoms_dc_off,
+ XELPD_PW_2_POWER_DOMAINS,
-:79: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #79: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1424:
+ .instances = &I915_PW_INSTANCES(
total: 0 errors, 0 warnings, 2 checks, 71 lines checked 0d43dceba295 drm/i915/mtl: Re-use ADL-P's "DC off" power well 88fc548d256c drm/i915/mtl: Extend Wa_22011802037 to MTL A-step 37ef7912f5a3 drm/i915/mtl: WA to clear RDOP clock gating
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for More MTL WA and powerwell patches (rev3)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: More MTL WA and powerwell patches (rev3)
URL : https://patchwork.freedesktop.org/series/115292/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:117:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:148:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:148:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:150:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:150:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:154:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:154:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:156:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:156:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:156:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:156:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:174:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:174:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:176:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:176:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:180:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:180:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:182:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:182:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:182:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:182:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:186:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:186:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:188:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:188:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:192:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:192:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:195:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:195:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:195:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:195:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:237:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:237:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:239:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:239:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./drivers/gpu/drm/i915/intel_uncore.h:346:1: warning: trying to copy expression type 31 +./drivers/gpu/drm/i915/intel_uncore.h:351:1: warning: trying to copy expression type 31 +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return'
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for More MTL WA and powerwell patches (rev3)
In reply to Radhakrishna Sripada== Series Details ==
== Series Details ==
Series: More MTL WA and powerwell patches (rev3)
URL : https://patchwork.freedesktop.org/series/115292/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13027 -> Patchwork_115292v3
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_115292v3 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_115292v3, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/index.html
Participating hosts (37 -> 36)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_115292v3:
### IGT changes ###
#### Possible regressions ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-apl-guc: [PASS][1] -> [TIMEOUT][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13027/fi-apl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/fi-apl-guc/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_115292v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@load:
- bat-dg2-11: [PASS][3] -> [ABORT][4] ([i915#8189])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13027/bat-dg2-11/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/bat-dg2-11/igt@[email protected]
* igt@i915_selftest@live@reset:
- bat-rpls-1: NOTRUN -> [ABORT][5] ([i915#4983])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@workarounds:
- bat-adlm-1: [PASS][6] -> [INCOMPLETE][7] ([i915#4983] / [i915#7677])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13027/bat-adlm-1/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/bat-adlm-1/igt@i915_selftest@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-glk-j4005: NOTRUN -> [SKIP][8] ([fdo#109271])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/fi-glk-j4005/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][9] ([i915#3546]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/bat-adlp-9/igt@[email protected]
#### Possible fixes ####
* igt@dmabuf@all-tests@dma_fence:
- fi-glk-j4005: [ABORT][10] -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13027/fi-glk-j4005/igt@dmabuf@all-tests@dma_fence.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/fi-glk-j4005/igt@dmabuf@all-tests@dma_fence.html
* igt@dmabuf@all-tests@dma_fence_chain:
- fi-glk-j4005: [DMESG-FAIL][12] -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13027/fi-glk-j4005/igt@dmabuf@all-tests@dma_fence_chain.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/fi-glk-j4005/igt@dmabuf@all-tests@dma_fence_chain.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][14] ([i915#7911] / [i915#7982]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13027/bat-rpls-1/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [FAIL][16] ([i915#7932]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13027/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
Build changes
-------------
* Linux: CI_DRM_13027 -> Patchwork_115292v3
CI-20190529: 20190529
CI_DRM_13027: 9e1eb302fc69b5d8dc662f1ce7ed8684e87c5751 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7259: 3d3a7f1c041d3f8d84d7457abf96adef0ea071cb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115292v3: 9e1eb302fc69b5d8dc662f1ce7ed8684e87c5751 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
f32d1033b425 drm/i915/mtl: WA to clear RDOP clock gating 205f76fbcb1f drm/i915/mtl: Extend Wa_22011802037 to MTL A-step 757f6079b91d drm/i915/mtl: Re-use ADL-P's "DC off" power well 682dd6744fd7 drm/i915: Use separate "DC off" power well for ADL-P and DG2
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115292v3/index.html
Hi,
Quoted 7 lines · Radhakrishna Sripada
This series adds 2 MTL WA's and 2 patches to fix re-use "DC off" power wells.
v2:
Haridhar Kalvala (1):
drm/i915/mtl: WA to clear RDOP clock gating
Quoted 6 lines
Madhumitha Tolakanahalli Pradeep (1):
drm/i915/mtl: Extend Wa_22011802037 to MTL A-stepMatt Roper (2):
drm/i915: Use separate "DC off" power well for ADL-P and DG2 drm/i915/mtl: Re-use ADL-P's "DC off" power well
Apparently this patchset broke bat-dg2-11 machine on CI.
Both pre and post merge results suggests it [1][2].
Regarding bat-dg2-11, this machine contains DG2 AND ADL cards.
So the bug hits ADL card on bat-dg2-11 machine. No idea why only this one, there are multiple bat machines with ADL.
[1]: http://gfx-ci.igk.intel.com/tree/drm-tip/bat-dg2-11.html
[2]: http://gfx-ci.igk.intel.com/tree/drm-tip/Patchwork_115292v3/index.html?
Regards
Andrzej
Quoted 6 lines
.../i915/display/intel_display_power_map.c | 57 +++++++++++++------ drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 + .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 ++-- 3 files changed, 48 insertions(+), 24 deletions(-)