hw/misc/ivshmem: Use 32-bit addressing for the memory BAR
PATCH 1/1 hw/misc/ivshmem: Use 32-bit addressing for the memory BAR
Since OVMF 202211 the bios maps BAR2 to an upper address which has the undesirable effect of making it impossible to map the memory under Linux due to it exceeding the maximum permissible range for hotplug memory (see mhp_get_pluggable_range in mm/memory_hotplug.c). This patch resolves this by configuring the BAR as 32-bit.
--- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/misc/ivshmem.c +1 -1
@@ -913,7 +913,7 @@ static void ivshmem_common_realize(PCIDevice *dev, Error **errp)pci_register_bar (PCI_DEVICE (s),2 ,PCI_BASE_ADDRESS_SPACE_MEMORY |PCI_BASE_ADDRESS_MEM_PREFETCH | -PCI_BASE_ADDRESS_MEM_TYPE_64 , +PCI_BASE_ADDRESS_MEM_TYPE_32 , s->ivshmem_bar2); }
Signature · 1 line
2.39.2
It seems this patch was missed/ignored, Can we please get some traction on this? Even if this is not the correct approach some advice on how to get this issue resolved would be much appreciated. We are seeing a lot of outcry of the fact that people have to roll back their OVMF BIOS to get things working.
Quoted 24 lines · Geoffrey McRae
Since OVMF 202211 the bios maps BAR2 to an upper address which has the undesirable effect of making it impossible to map the memory under Linux due to it exceeding the maximum permissible range for hotplug memory (see
mhp_get_pluggable_rangeinmm/memory_hotplug.c). This patch resolves this by configuring the BAR as 32-bit.Signed-off-by Geoffrey McRae <[email protected]>--- hw/misc/ivshmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/misc/ivshmem.c +1
-1@@ -913,7 +913,7 @@ static void ivshmem_common_realize(PCIDevice *dev, Error **errp) pci_register_bar(PCI_DEVICE(s), 2, PCI_BASE_ADDRESS_SPACE_MEMORY | PCI_BASE_ADDRESS_MEM_PREFETCH | -PCI_BASE_ADDRESS_MEM_TYPE_64 , +PCI_BASE_ADDRESS_MEM_TYPE_32 , s->ivshmem_bar2); }