Skip to contentSkip to conversation

hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI

PATCH In review Thomas Huth 2 participants 2 messages Apr 19, 2023 – Apr 20, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI

The "pvrdma" device is only usable in conjunction with the "vmxnet3" NIC - see the check for TYPE_VMXNET3 in pvrdma_realize().

By adding this dependency, the amount of total files that have to be compiled for a configuration with all targets decreases by 64 files (!), since the rdma code is marked as target specific and thus got recompiled for all targets that enable PCI so far.

---
 hw/rdma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/rdma/Kconfig +1 -1
index 8e2211288f..840320bdc0 100644
@@ -1,3 +1,3 @@
 config VMW_PVRDMA
     default y if PCI_DEVICES
-    depends on PVRDMA && PCI && MSI_NONBROKEN
+    depends on PVRDMA && MSI_NONBROKEN && VMXNET3_PCI
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Thomas Huth

The "pvrdma" device is only usable in conjunction with the "vmxnet3" NIC - see the check for TYPE_VMXNET3 in pvrdma_realize().

By adding this dependency, the amount of total files that have to be compiled for a configuration with all targets decreases by 64 files (!), since the rdma code is marked as target specific and thus got recompiled for all targets that enable PCI so far.

Quoted 4 lines
---
  hw/rdma/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)