Skip to contentSkip to conversation

arm64: dts: ti: Drop bootargs

PATCH Applied Nishanth Menon 3 participants 8 messages Apr 19, 2023 – Jun 6, 2023

Subsystems (2)
lore
Share & tools
lore

Nishanth Menon

author maintainer
#0 lore raw

v2 cover arm64: dts: ti: Drop bootargs

The bootargs atm contains (generally) two information: console and earlycon - console is already covered by stdout-path and earlycon is really meant to be used when debug is needed and not something of a default to spin out to all users.

This has come up multiple times, so cleaning it all up.
See [1] for context. AM64 is covered in [2]. There are quite a few other instances of the same in mailing list[3].

Changes since V1:
* No functional changes
* Commit message update to be verbose as to the rationale.
* Picked up Roger's and Krzysztof's acks.

V1: https://lore.kernel.org/all/[email protected]/

[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs

Nishanth Menon (5):
arm64: dts: ti: k3-am62x-sk-common: Drop bootargs
arm64: dts: ti: k3-am65*: Drop bootargs
arm64: dts: ti: k3-j721e-*: Drop bootargs
arm64: dts: ti: k3-j7200-common-proc-board: Drop bootargs
arm64: dts: ti: k3-j721s2-common-proc-board: Drop bootargs

 arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi         | 1 -
 arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi     | 1 -
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts         | 1 -
 arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts  | 1 -
 arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts  | 1 -
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts                 | 1 -
 arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts | 1 -
 7 files changed, 7 deletions(-)
Signature · 7 lines
2.40.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#1 lore raw

PATCH v2 1/5 arm64: dts: ti: k3-am62x-sk-common: Drop bootargs

Drop bootargs from the dts. The console arguments are already covered in stdout-path property and earlycon is a debug property that should be enabled only when debug is desired and not as default.

---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs

Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof

V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi +0 -1
index 976f8303c84f..a61e8648f189 100644
@@ -25,7 +25,6 @@ aliases {
 
 	chosen {
 		stdout-path = "serial2:115200n8";
-		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
 	};
 
 	memory@80000000 {
Signature · 7 lines
2.40.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#2 lore raw

PATCH v2 2/5 arm64: dts: ti: k3-am65*: Drop bootargs

In reply to Nishanth Menon

Drop bootargs from the dts. earlycon is a debug property that should be enabled only when debug is desired and not as default - see referenced link on discussion on this topic.

---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs

Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof

V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 1 -
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts     | 1 -
 2 files changed, 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi +0 -1
index 96ac2b476b11..7d256a1638ff 100644
@@ -21,7 +21,6 @@ aliases {
 
 	chosen {
 		stdout-path = "serial3:115200n8";
-		bootargs = "earlycon=ns16550a,mmio32,0x02810000";
 	};
 
 	reserved-memory {
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +0 -1
index 592ab2b54cb3..0d6fc89eba7a 100644
@@ -15,7 +15,6 @@ / {
 
 	chosen {
 		stdout-path = "serial2:115200n8";
-		bootargs = "earlycon=ns16550a,mmio32,0x02800000";
 	};
 
 	memory@80000000 {
Signature · 7 lines
2.40.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by on v2 2/5
#3 lore raw

Re: [PATCH V2 2/5] arm64: dts: ti: k3-am65*: Drop bootargs

Quoted 40 lines · Nishanth Menon

Drop bootargs from the dts. earlycon is a debug property that should be enabled only when debug is desired and not as default - see referenced link on discussion on this topic.

---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs

Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof

V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 1 -
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts     | 1 -
 2 files changed, 2 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi +0 -1
index 96ac2b476b11..7d256a1638ff 100644
@@ -21,7 +21,6 @@ aliases {
 
 	chosen {
 		stdout-path = "serial3:115200n8";
-		bootargs = "earlycon=ns16550a,mmio32,0x02810000";
 	};
 
 	reserved-memory {
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +0 -0
index 592ab2b54cb3..0d6fc89eba7a 100644

arch/arm64/boot/dts/ti/k3-am654-base-board.dts / { · line 20

Quoted 7 lines
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +0 -1
@@ -15,7 +15,6 @@ / {
 
 	chosen {
 		stdout-path = "serial2:115200n8";
-		bootargs = "earlycon=ns16550a,mmio32,0x02800000";
 	};
 
 	memory@80000000 {

For the IOT2050:

Jan

Signature · 2 lines
Siemens AG, Technology
Competence Center Embedded Linux
author maintainer
#4 lore raw

PATCH v2 3/5 arm64: dts: ti: k3-j721e-*: Drop bootargs

In reply to Nishanth Menon

Drop bootargs from the dts. The console arguments are already covered in stdout-path property and earlycon is a debug property that should be enabled only when debug is desired and not as default.

---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs

Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof

V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 1 -
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts                | 1 -
 2 files changed, 2 deletions(-)
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +0 -1
index 7db0603125aa..c11c092c1ce0 100644
@@ -17,7 +17,6 @@ / {
 
 	chosen {
 		stdout-path = "serial2:115200n8";
-		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
 	};
 
 	gpio_keys: gpio-keys {
arch/arm64/boot/dts/ti/k3-j721e-sk.dts +0 -1
index f650a7fd66b4..ad7b45aeed0a 100644
@@ -18,7 +18,6 @@ / {
 
 	chosen {
 		stdout-path = "serial2:115200n8";
-		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
 	};
 
 	memory@80000000 {
Signature · 7 lines
2.40.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#5 lore raw

PATCH v2 4/5 arm64: dts: ti: k3-j7200-common-proc-board: Drop bootargs

In reply to Nishanth Menon

Drop bootargs from the dts. The console arguments are already covered in stdout-path property and earlycon is a debug property that should be enabled only when debug is desired and not as default.

---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs

Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof

V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +0 -1
index 0d39d6b8cc0c..5506341aae21 100644
@@ -17,7 +17,6 @@ / {
 
 	chosen {
 		stdout-path = "serial2:115200n8";
-		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
 	};
 
 	evm_12v0: fixedregulator-evm12v0 {
Signature · 7 lines
2.40.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#6 lore raw

PATCH v2 5/5 arm64: dts: ti: k3-j721s2-common-proc-board: Drop bootargs

In reply to Nishanth Menon

Drop bootargs from the dts. The console arguments are already covered in stdout-path property and earlycon is a debug property that should be enabled only when debug is desired and not as default.

---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs

Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof

V1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts +0 -1
index b4b9edfe2d12..1299c715f34c 100644
@@ -16,7 +16,6 @@ / {
 
 	chosen {
 		stdout-path = "serial2:115200n8";
-		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,2880000";
 	};
 
 	aliases {
Signature · 1 line
2.40.0
maintainer Applied
#7 lore raw
In reply to Nishanth Menon

Hi Nishanth Menon,

Quoted 10 lines · Nishanth Menon

The bootargs atm contains (generally) two information: console and earlycon - console is already covered by stdout-path and earlycon is really meant to be used when debug is needed and not something of a default to spin out to all users.

This has come up multiple times, so cleaning it all up.
See [1] for context. AM64 is covered in [2]. There are quite a few other instances of the same in mailing list[3].

[...]

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/5] arm64: dts: ti: k3-am62x-sk-common: Drop bootargs

      commit: d525ef9c7f077bfa8202b4b47ca9242ab936a1dc
[2/5] arm64: dts: ti: k3-am65*: Drop bootargs
      commit: da4159a776593f802ee211ad4823f3aed31e5375
[3/5] arm64: dts: ti: k3-j721e-*: Drop bootargs
      commit: af2cda7df7769d3353170b6a72d73bc4ea703480
[4/5] arm64: dts: ti: k3-j7200-common-proc-board: Drop bootargs
      commit: f920c49f1e46a99c410e2aaf486ffb7ce3d12270
[5/5] arm64: dts: ti: k3-j721s2-common-proc-board: Drop bootargs
      commit: cf82a026f54f54c241903add9b9bdbeb2a449db0

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh