Skip to contentSkip to conversation

RISC-V: include cpufeature.h in cpufeature.c

PATCH Applied Conor Dooley 3 participants 3 messages Apr 20, 2023 – May 2, 2023 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RISC-V: include cpufeature.h in cpufeature.c

From: Conor Dooley <[email protected]>

Automation complains:
warning: symbol '__pcpu_scope_misaligned_access_speed' was not declared. Should it be static?

cpufeature.c doesn't actually include the header of the same name, as it had not previously used anything from it.
The per-cpu variable is declared there, so include it to silence the complaints.

Fixes 62a31d6e38bd ("RISC-V: hwprobe: Support probing of misaligned access performance")

---
CC: Evan Green <[email protected]>
CC: Palmer Dabbelt <[email protected]>
CC: Paul Walmsley <[email protected]>
CC: [email protected]

---
 arch/riscv/kernel/cpufeature.c | 1 +
 1 file changed, 1 insertion(+)
arch/riscv/kernel/cpufeature.c +1 -0
index 52585e088873..00f9f57a8566 100644
@@ -14,6 +14,7 @@
 #include <linux/of.h>
 #include <asm/alternative.h>
 #include <asm/cacheflush.h>
+#include <asm/cpufeature.h>
 #include <asm/hwcap.h>
 #include <asm/patch.h>
 #include <asm/processor.h>
Signature · 7 lines
2.39.2


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Conor Dooley

From: Conor Dooley <[email protected]>

Automation complains:
warning: symbol '__pcpu_scope_misaligned_access_speed' was not declared. Should it be static?

cpufeature.c doesn't actually include the header of the same name, as it had not previously used anything from it.
The per-cpu variable is declared there, so include it to silence the complaints.

Quoted 8 lines
Fixes 62a31d6e38bd ("RISC-V: hwprobe: Support probing of misaligned access performance")

---
CC: Evan Green <[email protected]>
CC: Palmer Dabbelt <[email protected]>
CC: Paul Walmsley <[email protected]>
CC: [email protected]
---

Thanks Conor!

ps - I'm working on that modprobe fix now, will send something shortly.

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#2 lore raw
In reply to Conor Dooley
Quoted 9 lines · Conor Dooley

Automation complains:
warning: symbol '__pcpu_scope_misaligned_access_speed' was not declared. Should it be static?

cpufeature.c doesn't actually include the header of the same name, as it had not previously used anything from it.
The per-cpu variable is declared there, so include it to silence the complaints.

[...]

Applied, thanks!

[1/1] RISC-V: include cpufeature.h in cpufeature.c

      https://git.kernel.org/palmer/c/c2d3c8441e3d

Best regards,

Signature · 7 lines
Palmer Dabbelt <[email protected]>


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv