Skip to contentSkip to conversation

iio: adc: palmas_gpadc: fix NULL dereference on rmmod

PATCH New Sasha Levin 1 participant 1 message Apr 20, 2023

Subsystems (2)
Stable branch IIO
lore
Share & tools
lore

Sasha Levin

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: palmas_gpadc: fix NULL dereference on rmmod

From: Patrik Dahlström <[email protected]>

[ Upstream commit 49f76c499d38bf67803438eee88c8300d0f6ce09 ]

Calling dev_to_iio_dev() on a platform device pointer is undefined and will make adc NULL.

Signed-off-by Patrik Dahlström <[email protected]>
Link https://lore.kernel.org/r/[email protected] open here
Signed-off-by Jonathan Cameron <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
---
 drivers/iio/adc/palmas_gpadc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/palmas_gpadc.c +1 -1
index f5218461ae255..f422df4daadcb 100644
@@ -634,7 +634,7 @@ static int palmas_gpadc_probe(struct platform_device *pdev)
 
 static int palmas_gpadc_remove(struct platform_device *pdev)
 {
-	struct iio_dev *indio_dev = dev_to_iio_dev(&pdev->dev);
+	struct iio_dev *indio_dev = dev_get_drvdata(&pdev->dev);
 	struct palmas_gpadc *adc = iio_priv(indio_dev);
 
 	if (adc->wakeup1_enable || adc->wakeup2_enable)
Signature · 1 line
2.39.2