devtools: allow patch to multiple groups for the same driver
PATCH 1/1 devtools: allow patch to multiple groups for the same driver
The PMD's source code resides in the ./drivers folder of the DPDK project and split into the several groups depending on the PMD class (common, net, regex, etc.).
For some vendors the drivers of different classes operate over the same hardware, for example Nvidia PMDs operate over ConnectX NIC series. It often happens the same minor fixes should be applied to the multiple drivers of the same vendor in the different classes.
The check-git-log.sh script checks the consistence of patch affected files and patch commit message headline and prevents updating multiple drivers in single commit.
This patch mitigates this strict check and allows to update multiple drivers in different classes for the single vendor.
--- devtools/check-git-log.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
devtools/check-git-log.sh +3 -1
@@ -80,7 +80,9 @@ bad=$(for commit in $commits ; do continue drv=$(echo "$files" | grep '^drivers/' | cut -d "/" -f 2,3 | sort -u) drvgrp=$(echo "$drv" | cut -d "/" -f 1 | uniq) - if [ $(echo "$drvgrp" | wc -l) -gt 1 ] ; then + drvpmd=$(echo "$drv" | cut -d "/" -f 2 | uniq) + if [ $(echo "$drvgrp" | wc -l) -gt 1 ] && \ + [ $(echo "$drvpmd" | wc -l) -gt 1 ] ; then echo "$headline" | grep -v '^drivers:' elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then echo "$headline" | grep -v "^drivers/$drvgrp"
Signature · 1 line
2.18.1
Quoted 13 lines · On Thu, 20 Apr 2023 15:12:40 +0300 Viacheslav Ovsiienko…
The PMD's source code resides in the ./drivers folder of the DPDK project and split into the several groups depending on the PMD class (common, net, regex, etc.).
For some vendors the drivers of different classes operate over the same hardware, for example Nvidia PMDs operate over ConnectX NIC series. It often happens the same minor fixes should be applied to the multiple drivers of the same vendor in the different classes.
The
check-git-log.shscript checks the consistence of patch affected files and patch commit message headline and prevents updating multiple drivers in single commit.
Quoted 5 lines
This patch mitigates this strict check and allows to update multiple drivers in different classes for the single vendor.
Signed-off-by Viacheslav Ovsiienko <[email protected]>---
This patch has sat for years now with no response.
As a maintainer, using check-git-log is just advice and it doesn't need to be exact.
So marking this as Rejected due to lack of ack's