Skip to contentSkip to conversation

ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE

PATCH Applied Andreas Kemnade 3 participants 4 messages Apr 20, 2023 – May 2, 2023 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: i.MX: bbu: fix compilation without CONFIG_BAREBOX_UPDATE

Fix
include/mach/imx/bbu.h:208:1: error: expected identifier or ‘(’ before ‘{’ token

---
 include/mach/imx/bbu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/mach/imx/bbu.h +1 -1
index 451ae15740..50657d9895 100644
@@ -204,7 +204,7 @@ imx7_bbu_internal_spi_i2c_register_handler(const char *name, char *devicefile,
 
 static inline int
 imx8m_bbu_internal_flexspi_nor_register_handler(const char *name, const char *devicefile,
-						unsigned long flags);
+						unsigned long flags)
 {
 	return -ENOSYS;
 }
Signature · 1 line
2.39.2
#1 lore raw
Quoted 4 lines · On Thu, 20 Apr 2023 21:52:55 +0200 Andreas Kemnade <[email protected]> wrote:

Fix
include/mach/imx/bbu.h:208:1: error: expected identifier or ‘(’ before ‘{’ token

should probably have added a fixes:

Fixes 6e0cb133be ("ARM: i.MX: bbu: add FlexSPI update handler")
Reviewed-by on v1 1/1
#2 lore raw
In reply to Andreas Kemnade

Hi Andreas,

Quoted 2 lines · Andreas Kemnade

Fix
include/mach/imx/bbu.h:208:1: error: expected identifier or ‘(’ before ‘{’ token

argh.. thanks a lot.

Quoted 1 line
Quoted 22 lines
---
 include/mach/imx/bbu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/mach/imx/bbu.h +1 -1
index 451ae15740..50657d9895 100644
@@ -204,7 +204,7 @@ imx7_bbu_internal_spi_i2c_register_handler(const char *name, char *devicefile,
 
 static inline int
 imx8m_bbu_internal_flexspi_nor_register_handler(const char *name, const char *devicefile,
-						unsigned long flags);
+						unsigned long flags)
 {
 	return -ENOSYS;
 }
Signature · 1 line
2.39.2
Applied
#3 lore raw
In reply to Andreas Kemnade
Quoted 7 lines · Andreas Kemnade

Fix
include/mach/imx/bbu.h:208:1: error: expected identifier or ‘(’ before ‘{’ token

---
 include/mach/imx/bbu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

Quoted 19 lines
include/mach/imx/bbu.h +1 -1
index 451ae15740..50657d9895 100644
@@ -204,7 +204,7 @@ imx7_bbu_internal_spi_i2c_register_handler(const char *name, char *devicefile,
 
 static inline int
 imx8m_bbu_internal_flexspi_nor_register_handler(const char *name, const char *devicefile,
-						unsigned long flags);
+						unsigned long flags)
 {
 	return -ENOSYS;
 }
Signature · 1 line
2.39.2
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |