Skip to contentSkip to conversation

NFS: set varaiable nfs_netfs_debug_id storage-class-specifier to static

PATCH New Tom Rix 1 participant 1 message Apr 21, 2023

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 NFS: set varaiable nfs_netfs_debug_id storage-class-specifier to static

smatch reports
fs/nfs/fscache.c:260:10: warning: symbol
'nfs_netfs_debug_id' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static

---
 fs/nfs/fscache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/fscache.c +1 -1
index 95c2b3056e2b..8c35d88a84b1 100644
@@ -257,7 +257,7 @@ int nfs_netfs_readahead(struct readahead_control *ractl)
 	return 0;
 }
 
-atomic_t nfs_netfs_debug_id;
+static atomic_t nfs_netfs_debug_id;
 static int nfs_netfs_init_request(struct netfs_io_request *rreq, struct file *file)
 {
 	rreq->netfs_priv = get_nfs_open_context(nfs_file_open_context(file));
Signature · 1 line
2.27.0