media: v4l2-mc: Drop subdev check in v4l2_create_fwnode_links_to_pad()
PATCH 1/1 media: v4l2-mc: Drop subdev check in v4l2_create_fwnode_links_to_pad()
While updating v4l2_create_fwnode_links_to_pad() to accept non-subdev sinks, the check is_media_entity_v4l2_subdev() was not removed which prevented the function from being used with non-subdev sinks, Drop the unnecessary check.
--- drivers/media/v4l2-core/v4l2-mc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/v4l2-core/v4l2-mc.c +1 -2
@@ -314,8 +314,7 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd, {struct fwnode_handle *endpoint; -if (!(sink->flags &MEDIA_PAD_FL_SINK ) || - !is_media_entity_v4l2_subdev (sink->entity)) +if (!(sink->flags &MEDIA_PAD_FL_SINK ))return -EINVAL ;fwnode_graph_for_each_endpoint (dev_fwnode (src_sd->dev), endpoint) {
Signature · 1 line
2.17.1
Hi Vaishnav,
Thank you for the patch.
Quoted 8 lines · Vaishnav Achath
While updating
v4l2_create_fwnode_links_to_pad()to accept non-subdev sinks, the checkis_media_entity_v4l2_subdev()was not removed which prevented the function from being used with non-subdev sinks, Drop the unnecessary check.Fixes bd5a03bc5be8 ("media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad()")Signed-off-by Vaishnav Achath <[email protected]>
Sakari, the commit this patch fixes will land in v6.4, should this be merged as a v6.4 fix ?
Quoted 18 lines
--- drivers/media/v4l2-core/v4l2-mc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/media/v4l2-core/v4l2-mc.c +1
-2@@ -314,8 +314,7 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd, {struct fwnode_handle *endpoint; -if (!(sink->flags &MEDIA_PAD_FL_SINK ) || - !is_media_entity_v4l2_subdev (sink->entity)) +if (!(sink->flags &MEDIA_PAD_FL_SINK ))return -EINVAL ;fwnode_graph_for_each_endpoint (dev_fwnode (src_sd->dev), endpoint) {
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 10 lines · Laurent Pinchart
Hi Vaishnav,
Thank you for the patch.
Quoted 5 lines · Vaishnav Achath
While updating
v4l2_create_fwnode_links_to_pad()to accept non-subdev sinks, the checkis_media_entity_v4l2_subdev()was not removed which prevented the function from being used with non-subdev sinks, Drop the unnecessary check.
Quoted 8 lines
Quoted 3 lines
Fixes bd5a03bc5be8 ("media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad()")Signed-off-by Vaishnav Achath <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>Sakari, the commit this patch fixes will land in v6.4, should this be merged as a v6.4 fix ?
I'd think so. I'll take this soonish.
Signature · 1 line
Sakari Ailus