transport-pci: msix register desc improve
v3 cover transport-pci: msix register desc improve
Problem:
Current wording queue_msix_vector and config_msix_vector says "for MSI-X", which is bit confusing.
config_msix_vector and queue_msix_vector are the msix vector number for configuration change and queue related interrupts.
Hence, reword it.
---
changelog:v2->v3:
- rewordv1->v2:
- rewrote to indicate MSI-X table entry indexv0->v1:
- added 'here'
- dropped 'receiving'
- dropped already merged patch for empty line
Parav Pandit (2):
transport-pci: Improve config msix vector description
transport-pci: Improve queue msix vector register desc
transport-pci.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 18 lines
2.26.2 This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: [email protected] Unsubscribe: [email protected] List help: [email protected] List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/
PATCH v3 1/2 transport-pci: Improve config msix vector description
config_msix_vector is the register that holds the MSI-X vector number for receiving configuration change related interrupts.
It is not "for MSI-X".
Hence, replace the confusing text with appropriate one.
---
changelog:v2->v3:
- rewritev1->v2:
- rewrote to indicate MSI-X table entry indexv0->v1:
- added 'here'
- dropped 'receiving'
--- transport-pci.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
transport-pci.tex +1 -1
@@ -343,7 +343,7 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport Driver Feature Bits selected by \field{driver_feature_select}. \item[\field{config_msix_vector}] - The driver sets the Configuration Vector for MSI-X. + Set by the driver to the MSI-X vector for configuration change notifications. \item[\field{num_queues}] The device specifies the maximum number of virtqueues supported here.
Signature · 6 lines
2.26.2 --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
PATCH v3 2/2 transport-pci: Improve queue msix vector register desc
In reply to Parav Panditqueue_msix_vector register is for receiving virtqueue notification interrupts from the device for the virtqueue.
"for MSI-X" is confusing term.
Also it is the register that driver "writes" to, similar to many other registers such as queue_desc, queue_driver etc.
Hence, replace the verb from use to write.
---
changelog:v2->v3:
- rewritev1->v2:
- rewrote to indicate MSI-X table entry indexv0->v1:
- added 'here'
- dropped 'receiving'
--- transport-pci.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
transport-pci.tex +1 -1
@@ -366,7 +366,7 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport A 0 means the queue is unavailable. \item[\field{queue_msix_vector}] - The driver uses this to specify the queue vector for MSI-X. + Set by the driver to the MSI-X vector for virtqueue notifications. \item[\field{queue_enable}] The driver uses this to selectively prevent the device from executing requests from this virtqueue.
Signature · 18 lines
2.26.2 This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: [email protected] Unsubscribe: [email protected] List help: [email protected] List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/
Quoted 9 lines · Parav Pandit
Problem:
Current wording
queue_msix_vectorandconfig_msix_vectorsays "for MSI-X", which is bit confusing.
config_msix_vectorandqueue_msix_vectorare the msix vector number for configuration change and queue related interrupts.Hence, reword it.
LGTM.
Given the amount of back and forth, I guess we should vote.
Quoted 12 lines
---
changelog:v2->v3:
- rewordv1->v2:
- rewrote to indicate MSI-X table entry indexv0->v1:
- added 'here'
- dropped 'receiving'
- dropped already merged patch for empty line
Quoted 9 lines
Parav Pandit (2):
transport-pci: Improve config msix vector description
transport-pci: Improve queue msix vector register desctransport-pci.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Signature · 1 line
2.26.2
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.
Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Quoted 10 lines
From: Michael S. Tsirkin <[email protected]>
Sent: Saturday, April 22, 2023 6:11 AMQuoted 5 lines · Parav Pandit
Problem:
Current wording
queue_msix_vectorandconfig_msix_vectorsays "for MSI-X", which is bit confusing.
Quoted 8 lines
Quoted 4 lines
config_msix_vectorandqueue_msix_vectorare the msix vector number for configuration change and queue related interrupts.Hence, reword it.
LGTM.
Given the amount of back and forth, I guess we should vote.
Ok. created github at [1].
Will wait for few more days to ask for vote for any other review comments.
[1] https://github.com/oasis-tcs/virtio-spec/issues/169
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.
Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Hi,
Quoted 11 lines
From: [email protected] <[email protected] open.org> On Behalf Of Parav Pandit
Sent: Monday, April 24, 2023 11:15 AMQuoted 3 lines
LGTM.
Given the amount of back and forth, I guess we should vote.Ok. created github at [1].
Will wait for few more days to ask for vote for any other review comments.
Can you please raise the ballot for this?
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.
Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Quoted 9 lines · Parav Pandit
Hi,
Quoted 7 lines
From: [email protected] <[email protected] open.org> On Behalf Of Parav Pandit
Sent: Monday, April 24, 2023 11:15 AMQuoted 3 lines
LGTM.
Given the amount of back and forth, I guess we should vote.
Quoted 6 lines
Quoted 4 lines
Ok. created github at [1].
Will wait for few more days to ask for vote for any other review comments.Can you please raise the ballot for this?
ok if you put in link to lore, not to oasis archive, then please also include date and subject so people can still locate it in the oasis archive if they need to.
Signature · 6 lines
MST --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Quoted 13 lines · Michael S. Tsirkin
Quoted 12 lines · Parav Pandit
Hi,
Quoted 10 lines
From: [email protected] <[email protected] open.org> On Behalf Of Parav Pandit
Sent: Monday, April 24, 2023 11:15 AMQuoted 3 lines
LGTM.
Given the amount of back and forth, I guess we should vote.Ok. created github at [1].
Will wait for few more days to ask for vote for any other review comments.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Can you please raise the ballot for this?
ok if you put in link to lore, not to oasis archive, then please also include date and subject so people can still locate it in the oasis archive if they need to.
Also please link to virtio-comment archive. virtio-dev is for device/driver developers not for comments.
Quoted 2 lines
Signature · 1 line
MST
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.
Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Quoted 7 lines
From: Michael S. Tsirkin <[email protected]>
Sent: Friday, April 28, 2023 12:47 AMQuoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Can you please raise the ballot for this?
ok if you put in link to lore, not to oasis archive, then please also include date and subject so people can still locate it in the oasis archive if they need to.
Also please link to virtio-comment archive. virtio-dev is for device/driver developers not for comments.
Added OASIS virtio comment link.
Updated lore link to virtio-comment as well.
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.
Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Quoted 13 lines
From: Parav Pandit <[email protected]>
Sent: Friday, April 28, 2023 12:10 AM
To: Parav Pandit <[email protected]>; Michael S. Tsirkin <[email protected]>Hi,
Quoted 7 lines
From: [email protected] <[email protected] open.org> On Behalf Of Parav Pandit
Sent: Monday, April 24, 2023 11:15 AMQuoted 3 lines
LGTM.
Given the amount of back and forth, I guess we should vote.
Quoted 6 lines
Quoted 4 lines
Ok. created github at [1].
Will wait for few more days to ask for vote for any other review comments.Can you please raise the ballot for this?
Can you please merge the patches in the tree?
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.
Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
Quoted 9 lines · Parav Pandit
Hi,
Quoted 7 lines
From: [email protected] <[email protected] open.org> On Behalf Of Parav Pandit
Sent: Monday, April 24, 2023 11:15 AMQuoted 3 lines
LGTM.
Given the amount of back and forth, I guess we should vote.
Quoted 6 lines
Quoted 4 lines
Ok. created github at [1].
Will wait for few more days to ask for vote for any other review comments.Can you please raise the ballot for this?
FWIW the proper format is
as documented in our README.md
Quoted 8 lines
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.
Quoted 9 lines
Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]