misc-utils: flashcp: correct casting for percent display
PATCH 1/1 misc-utils: flashcp: correct casting for percent display
Add correct casting for written to prevent overflow that size_t is only 32 bits on a 32-bit platform.
Signed-off-by cchoux <[email protected]>
--- misc-utils/flashcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
misc-utils/flashcp.c +2 -2
@@ -371,7 +371,7 @@ int main (int argc,char *argv[])log_verbose ("\rWriting data: %dk/%lluk (%llu%%)" ,KB (written + i),KB ((unsigned long long )filestat.st_size), -PERCENTAGE (written + i,(unsigned long long )filestat.st_size)); +PERCENTAGE ((unsigned long long )written + i,(unsigned long long )filestat.st_size));/* read from filename */ safe_read (fil_fd,filename,src,i);
@@ -403,7 +403,7 @@ int main (int argc,char *argv[])log_verbose ("\rVerifying data: %luk/%lluk (%llu%%)" ,KB (written + i),KB ((unsigned long long )filestat.st_size), -PERCENTAGE (written + i,(unsigned long long )filestat.st_size)); +PERCENTAGE ((unsigned long long )written + i,(unsigned long long )filestat.st_size));/* read from filename */ safe_read (fil_fd,filename,src,i);
Signature · 6 lines
2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 4 lines · cchoux
Add correct casting for written to prevent overflow that
size_tis only 32 bits on a 32-bit platform.Signed-off-by cchoux <[email protected]>
Reviewed-by Zhihao Cheng <[email protected]>
Quoted 19 lines
--- misc-utils/flashcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)misc-utils/flashcp.c +1
-1@@ -371,7 +371,7 @@ int main (int argc,char *argv[])log_verbose ("\rWriting data: %dk/%lluk (%llu%%)" ,KB (written + i),KB ((unsigned long long )filestat.st_size), -PERCENTAGE (written + i,(unsigned long long )filestat.st_size)); +PERCENTAGE ((unsigned long long )written + i,(unsigned long long )filestat.st_size));/* read from filename */ safe_read (fil_fd,filename,src,i);
misc-utils/flashcp.c int main (int argc,char *argv[]) · line 409
Quoted 8 lines
misc-utils/flashcp.c +1
-1@@ -403,7 +403,7 @@ int main (int argc,char *argv[])log_verbose ("\rVerifying data: %luk/%lluk (%llu%%)" ,KB (written + i),KB ((unsigned long long )filestat.st_size), -PERCENTAGE (written + i,(unsigned long long )filestat.st_size)); +PERCENTAGE ((unsigned long long )written + i,(unsigned long long )filestat.st_size));/* read from filename */ safe_read (fil_fd,filename,src,i);
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
David Oberhollenzer
AppliedApplied to mtd-utils.git master.
Thanks,
David
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/