Skip to contentSkip to conversation

configs: stm32f746-disco: remove a useless comment

PATCH In review Dario Binacchi 3 participants 4 messages Apr 22, 2023 – Jun 16, 2023 Arm STM32

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: stm32f746-disco: remove a useless comment

Commit 8fc78fc73b7f9d ("configs: migrate CONFIG_BMP_16/24/32BPP to defconfigs") made the comment useless.

---

 include/configs/stm32f746-disco.h | 2 --
 1 file changed, 2 deletions(-)
include/configs/stm32f746-disco.h +0 -2
index 34856d300403..9bf01cac47a4 100644
@@ -36,6 +36,4 @@
 #define CFG_SYS_UBOOT_BASE		(CFG_SYS_FLASH_BASE + \
 					 CONFIG_SPL_PAD_TO)
 
-/* For splashcreen */
-
 #endif /* __CONFIG_H */
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw

Hi Dario

Quoted 14 lines · Dario Binacchi

Commit 8fc78fc73b7f9d ("configs: migrate CONFIG_BMP_16/24/32BPP to defconfigs") made the comment useless.

---

 include/configs/stm32f746-disco.h | 2 --
 1 file changed, 2 deletions(-)
include/configs/stm32f746-disco.h +0 -0
index 34856d300403..9bf01cac47a4 100644

include/configs/stm32f746-disco.h line 39

Quoted 6 lines
include/configs/stm32f746-disco.h +0 -2
@@ -36,6 +36,4 @@
 #define CFG_SYS_UBOOT_BASE		(CFG_SYS_FLASH_BASE + \
 					 CONFIG_SPL_PAD_TO)
 
-/* For splashcreen */
-
 #endif /* __CONFIG_H */

Thanks
Patrice

Reviewed-by on v1 1/1
#2 lore raw
In reply to Dario Binacchi

Hi,

Quoted 14 lines · Dario Binacchi

Commit 8fc78fc73b7f9d ("configs: migrate CONFIG_BMP_16/24/32BPP to defconfigs") made the comment useless.

---

  include/configs/stm32f746-disco.h | 2 --
  1 file changed, 2 deletions(-)
include/configs/stm32f746-disco.h +0 -0
index 34856d300403..9bf01cac47a4 100644

include/configs/stm32f746-disco.h line 39

Quoted 6 lines
include/configs/stm32f746-disco.h +0 -2
@@ -36,6 +36,4 @@
  #define CFG_SYS_UBOOT_BASE		(CFG_SYS_FLASH_BASE + \
  					 CONFIG_SPL_PAD_TO)
 
-/* For splashcreen */
-
  #endif /* __CONFIG_H */

Thanks
Patrick

#3 lore raw
In reply to Dario Binacchi
Quoted 14 lines · Dario Binacchi

Commit 8fc78fc73b7f9d ("configs: migrate CONFIG_BMP_16/24/32BPP to defconfigs") made the comment useless.

---

 include/configs/stm32f746-disco.h | 2 --
 1 file changed, 2 deletions(-)
include/configs/stm32f746-disco.h +0 -0
index 34856d300403..9bf01cac47a4 100644

include/configs/stm32f746-disco.h line 39

Quoted 6 lines
include/configs/stm32f746-disco.h +0 -2
@@ -36,6 +36,4 @@
 #define CFG_SYS_UBOOT_BASE		(CFG_SYS_FLASH_BASE + \
 					 CONFIG_SPL_PAD_TO)
 
-/* For splashcreen */
-
 #endif /* __CONFIG_H */

Applied to u-boot-stm/next

Thanks
Patrice