Skip to contentSkip to conversation

drivers/net/phy/marvell.c:2887 m88e1318_led_blink_set() warn: inconsistent indenting

PATCH kernel test robot 1 participant 1 message Apr 23, 2023 Memory management

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   d3e1ee0e67e7603d36f4fa2fec6b881c01aabe89
commit: ea9e86485decb2ac1750005bd96c166c9b780406 [12586/13717] net: phy: marvell: Implement led_blink_set()
config: csky-randconfig-m031-20230423 (https://download.01.org/0day-ci/archive/20230424/[email protected]/config)
compiler: csky-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/

smatch warnings:
drivers/net/phy/marvell.c:2887 m88e1318_led_blink_set() warn: inconsistent indenting

vim +2887 drivers/net/phy/marvell.c

2866
2867 static int m88e1318_led_blink_set(struct phy_device *phydev, u8 index,
2868 unsigned long *delay_on,
2869 unsigned long *delay_off)
2870 {
2871 int reg;
2872
2873 reg = phy_read_paged(phydev, MII_MARVELL_LED_PAGE,
2874 MII_88E1318S_PHY_LED_FUNC);
2875 if (reg < 0)
2876 return reg;
2877
2878 switch (index) {
2879 case 0:
2880 case 1:
2881 case 2:
2882 reg &= ~(0xf << (4 * index));
2883 reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
2884 /* Reset default is 84ms */
2885 *delay_on = 84 / 2;
2886 *delay_off = 84 / 2;

> 2887			break;

2888 default:
2889 return -EINVAL;
2890 }
2891
2892 return phy_write_paged(phydev, MII_MARVELL_LED_PAGE,
2893 MII_88E1318S_PHY_LED_FUNC, reg);
2894 }
2895

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests