drm/i915/mtl: add PTE encode function
Subsystems (3)
cover drm/i915/mtl: add PTE encode function
From: Fei Yang <[email protected]>
These patches are extracted from series
https://patchwork.freedesktop.org/series/115980/
This series start with adding PTE encode functions for MTL as it can no longer reuse the PTE encode functions for GEN8 due to PAT index changes. Then there are patches refactoring the cache policy programming so that the PTE encode functions can be unified across all GEN12 platforms. This refactor is also important in implementing the design which allows uerspace to directly set cache policy for each Buffer Object.
Fei Yang (4):
drm/i915/mtl: Add PTE encode function
drm/i915: preparation for using PAT index
drm/i915: use pat_index instead of cache_level
drm/i915: make sure correct pte encode is used
drivers/gpu/drm/i915/display/intel_dpt.c | 14 ++-- drivers/gpu/drm/i915/gem/i915_gem_domain.c | 27 ++---- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 10 ++- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_object.c | 61 +++++++++++++- drivers/gpu/drm/i915/gem/i915_gem_object.h | 8 ++ .../gpu/drm/i915/gem/i915_gem_object_types.h | 26 +++++- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 - drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 4 +- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 16 ++-- .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- .../drm/i915/gem/selftests/i915_gem_migrate.c | 2 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 10 ++- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 76 ++++++++++++----- drivers/gpu/drm/i915/gt/gen8_ppgtt.h | 3 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 84 +++++++++++++------ drivers/gpu/drm/i915/gt/intel_gtt.h | 31 ++++--- drivers/gpu/drm/i915/gt/intel_migrate.c | 47 ++++++----- drivers/gpu/drm/i915/gt/intel_migrate.h | 13 ++- drivers/gpu/drm/i915/gt/intel_ppgtt.c | 6 +- drivers/gpu/drm/i915/gt/selftest_migrate.c | 47 ++++++----- drivers/gpu/drm/i915/gt/selftest_reset.c | 8 +- drivers/gpu/drm/i915/gt/selftest_timeline.c | 2 +- drivers/gpu/drm/i915/gt/selftest_tlb.c | 4 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 10 ++- drivers/gpu/drm/i915/i915_debugfs.c | 55 +++++++++--- drivers/gpu/drm/i915/i915_gem.c | 16 +++- drivers/gpu/drm/i915/i915_gpu_error.c | 8 +- drivers/gpu/drm/i915/i915_pci.c | 79 +++++++++++++++-- drivers/gpu/drm/i915/i915_vma.c | 16 ++-- drivers/gpu/drm/i915/i915_vma.h | 2 +- drivers/gpu/drm/i915/i915_vma_types.h | 2 - drivers/gpu/drm/i915/intel_device_info.h | 5 ++ drivers/gpu/drm/i915/selftests/i915_gem.c | 5 +- .../gpu/drm/i915/selftests/i915_gem_evict.c | 4 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 15 ++-- .../drm/i915/selftests/intel_memory_region.c | 4 +- .../gpu/drm/i915/selftests/mock_gem_device.c | 9 ++ drivers/gpu/drm/i915/selftests/mock_gtt.c | 8 +- 40 files changed, 527 insertions(+), 219 deletions(-)
Signature · 1 line
2.25.1
PATCH 1/4 drm/i915/mtl: Add PTE encode function
From: Fei Yang <[email protected]>
PTE encode functions are platform dependent. This patch implements PTE functions for MTL, and ensures the correct PTE encode function is used by calling pte_encode function pointer instead of the hardcoded gen8 version of PTE encode.
--- drivers/gpu/drm/i915/display/intel_dpt.c | 2 +- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 45 ++++++++++++++++++++---- drivers/gpu/drm/i915/gt/intel_ggtt.c | 36 +++++++++++++++++-- drivers/gpu/drm/i915/gt/intel_gtt.h | 13 +++++-- 4 files changed, 83 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/display/intel_dpt.c +1 -1
@@ -300,7 +300,7 @@ intel_dpt_create(struct intel_framebuffer *fb) vm->vma_ops.bind_vma = dpt_bind_vma; vm->vma_ops.unbind_vma = dpt_unbind_vma; - vm->pte_encode = gen8_ggtt_pte_encode; + vm->pte_encode = vm->gt->ggtt->vm.pte_encode; dpt->obj = dpt_obj; dpt->obj->is_dpt = true;
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +38 -7
87 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_ggtt.c +33 -3
@@ -220,6 +220,33 @@ static void guc_ggtt_invalidate(struct i915_ggtt *ggtt) } } +static u64 mtl_ggtt_pte_encode (dma_addr_t addr, +enum i915_cache_level level, +u32 flags) +{ +gen8_pte_t pte = addr |GEN8_PAGE_PRESENT ; + +WARN_ON_ONCE (addr & ~GEN12_GGTT_PTE_ADDR_MASK ); + +if (flags &PTE_LM ) + pte |=GEN12_GGTT_PTE_LM ; + +switch (level) { +case I915_CACHE_NONE : + pte |=MTL_GGTT_PTE_PAT1 ; +break ; +case I915_CACHE_LLC : +case I915_CACHE_L3_LLC : + pte |=MTL_GGTT_PTE_PAT0 |MTL_GGTT_PTE_PAT1 ; +break ; +case I915_CACHE_WT : + pte |=MTL_GGTT_PTE_PAT0 ; +break ; + } + +return pte; +} +u64 gen8_ggtt_pte_encode (dma_addr_t addr,enum i915_cache_level level,u32 flags)
@@ -247,7 +274,7 @@ static void gen8_ggtt_insert_page(struct i915_address_space *vm,gen8_pte_t __iomem *pte = (gen8_pte_t __iomem *)ggtt->gsm + offset /I915_GTT_PAGE_SIZE ; -gen8_set_pte (pte,gen8_ggtt_pte_encode (addr, level, flags)); +gen8_set_pte (pte, ggtt->vm.pte_encode (addr, level, flags)); ggtt->invalidate (ggtt); }
@@ -257,8 +284,8 @@ static void gen8_ggtt_insert_entries(struct i915_address_space *vm, enum i915_cache_level level, u32 flags) { -const gen8_pte_t pte_encode =gen8_ggtt_pte_encode (0 , level, flags);struct i915_ggtt *ggtt =i915_vm_to_ggtt (vm); +const gen8_pte_t pte_encode = ggtt->vm.pte_encode (0 , level, flags);gen8_pte_t __iomem *gte;gen8_pte_t __iomem *end;struct sgt_iter iter;
@@ -981,7 +1008,10 @@ static int gen8_gmch_probe(struct i915_ggtt *ggtt) ggtt->vm.vma_ops.bind_vma = intel_ggtt_bind_vma; ggtt->vm.vma_ops.unbind_vma = intel_ggtt_unbind_vma; - ggtt->vm.pte_encode = gen8_ggtt_pte_encode; +if (GRAPHICS_VER_FULL (i915) >=IP_VER (12 ,70 )) + ggtt->vm.pte_encode = mtl_ggtt_pte_encode; +else + ggtt->vm.pte_encode = gen8_ggtt_pte_encode;return ggtt_probe_common (ggtt, size); }
drivers/gpu/drm/i915/gt/intel_gtt.h +11 -2
@@ -88,9 +88,18 @@ typedef u64 gen8_pte_t;#define BYT_PTE_SNOOPED_BY_CPU_CACHES REG_BIT(2)#define BYT_PTE_WRITEABLE REG_BIT(1) +#define MTL_PPGTT_PTE_PAT3 BIT_ULL(62)#define GEN12_PPGTT_PTE_LM BIT_ULL(11) - -#define GEN12_GGTT_PTE_LM BIT_ULL(1) +#define GEN12_PPGTT_PTE_PAT2 BIT_ULL(7) +#define GEN12_PPGTT_PTE_NC BIT_ULL(5) +#define GEN12_PPGTT_PTE_PAT1 BIT_ULL(4) +#define GEN12_PPGTT_PTE_PAT0 BIT_ULL(3) + +#define GEN12_GGTT_PTE_LM BIT_ULL(1) +#define MTL_GGTT_PTE_PAT0 BIT_ULL(52) +#define MTL_GGTT_PTE_PAT1 BIT_ULL(53) +#define GEN12_GGTT_PTE_ADDR_MASK GENMASK_ULL(45, 12) +#define MTL_GGTT_PTE_PAT_MASK GENMASK_ULL(53, 52)#define GEN12_PDE_64K BIT(6)#define GEN12_PTE_PS64 BIT(8)
Signature · 1 line
2.25.1
PATCH 2/4 drm/i915: preparation for using PAT index
In reply to [email protected]From: Fei Yang <[email protected]>
This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware.
Preparing the transition by adding some platform dependent data structures and helper functions to translate the cache_level to pat_index.
cachelevel_to_pat: a platform dependent array mapping cache_level to
pat_index.
max_pat_index: the maximum PAT index recommended in hardware specification
Needed for validating the PAT index passed in from user space.
i915_gem_get_pat_index: function to convert cache_level to PAT index.
obj_to_i915(obj): macro moved to header file for wider usage.
I915_MAX_CACHE_LEVEL: upper bound of i915_cache_level for the
convenience of coding.
--- drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 +++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 + .../gpu/drm/i915/gem/i915_gem_object_types.h | 1 + drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 - drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 6 ++ drivers/gpu/drm/i915/gt/intel_ggtt.c | 6 ++ drivers/gpu/drm/i915/i915_pci.c | 79 ++++++++++++++++--- drivers/gpu/drm/i915/intel_device_info.h | 5 ++ .../gpu/drm/i915/selftests/mock_gem_device.c | 9 +++ 9 files changed, 110 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object.c +9 -0
@@ -45,6 +45,15 @@ static struct kmem_cache *slab_objects;static const struct drm_gem_object_funcs i915_gem_object_funcs; +unsigned int i915_gem_get_pat_index (struct drm_i915_private *i915, +enum i915_cache_level level) +{ +if (drm_WARN_ON (&i915->drm, level >=I915_MAX_CACHE_LEVEL )) +return 0 ; + +return INTEL_INFO (i915)->cachelevel_to_pat[level]; +} +struct drm_i915_gem_object *i915_gem_object_alloc (void ) {struct drm_i915_gem_object *obj;
drivers/gpu/drm/i915/gem/i915_gem_object.h +4 -0
@@ -20,6 +20,8 @@enum intel_region_id ; +#define obj_to_i915 (obj__) to_i915((obj__)->base.dev) +static inline bool i915_gem_object_size_2big (u64 size) {struct drm_i915_gem_object *obj;
@@ -30,6 +32,8 @@ static inline bool i915_gem_object_size_2big(u64 size)return false; } +unsigned int i915_gem_get_pat_index (struct drm_i915_private *i915, +enum i915_cache_level level);void i915_gem_init__objects (struct drm_i915_private *i915);void i915_objects_module_exit (void );
drivers/gpu/drm/i915/gem/i915_gem_object_types.h +1 -0
@@ -194,6 +194,7 @@ enum i915_cache_level {* engine. */ I915_CACHE_WT , + I915_MAX_CACHE_LEVEL, }; enum i915_map_type {
drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +0 -2
@@ -460,8 +460,6 @@ void i915_gem_shrinker_taints_mutex(struct drm_i915_private *i915,fs_reclaim_release (GFP_KERNEL ); } -#define obj_to_i915 (obj__) to_i915((obj__)->base.dev) -/** * i915_gem_object_make_unshrinkable - Hide the object from the shrinker. By * default all object types that support shrinking(see IS_SHRINKABLE), will also
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +6 -0
@@ -78,6 +78,12 @@ static u64 mtl_pte_encode(dma_addr_t addr,case I915_CACHE_WT : pte |=GEN12_PPGTT_PTE_PAT0 ;break ; +default : +/* This should never happen. Added to deal with the compile +* error due to the addition of I915_MAX_CACHE_LEVEL. Will +* be removed by the pat_index patch. +*/ +break ; }return pte;
drivers/gpu/drm/i915/gt/intel_ggtt.c +6 -0
@@ -242,6 +242,12 @@ static u64 mtl_ggtt_pte_encode(dma_addr_t addr,case I915_CACHE_WT : pte |=MTL_GGTT_PTE_PAT0 ;break ; +default : +/* This should never happen. Added to deal with the compile +* error due to the addition of I915_MAX_CACHE_LEVEL. Will +* be removed by the pat_index patch. +*/ +break ; }return pte;
drivers/gpu/drm/i915/i915_pci.c +70 -9
239 lines not on this page · raw message
drivers/gpu/drm/i915/intel_device_info.h +5 -0
@@ -35,6 +35,8 @@#include "gt/intel_context_types.h" #include "gt/intel_sseu.h" +#include "gem/i915_gem_object_types.h" +struct drm_printer ;struct drm_i915_private ;struct intel_gt_definition ;
@@ -308,6 +310,9 @@ struct intel_device_info {* Initial runtime info. Do not access outside of i915_driver_create(). */ const struct intel_runtime_info __runtime; + +u32 cachelevel_to_pat[I915_MAX_CACHE_LEVEL ]; +u32 max_pat_index; };struct intel_driver_caps {
drivers/gpu/drm/i915/selftests/mock_gem_device.c +9 -0
@@ -123,7 +123,9 @@ struct drm_i915_private *mock_gem_device(void)static struct dev_iommu fake_iommu = { .priv = (void *)-1 };#endif struct drm_i915_private *i915; +struct intel_device_info *i915_info;struct pci_dev *pdev; +unsigned int i;int ret; pdev =kzalloc (sizeof (*pdev),GFP_KERNEL );
@@ -180,6 +182,13 @@ struct drm_i915_private *mock_gem_device(void)I915_GTT_PAGE_SIZE_2M ;RUNTIME_INFO (i915)->memory_regions =REGION_SMEM ; + +/* simply use legacy cache level for mock device */ + i915_info = (struct intel_device_info *)INTEL_INFO (i915); + i915_info->max_pat_index =3 ; +for (i =0 ; i <I915_MAX_CACHE_LEVEL ; i++) + i915_info->cachelevel_to_pat[i] = i; +intel_memory_regions_hw_probe (i915);spin_lock_init (&i915->gpu_error.lock);
Signature · 1 line
2.25.1
PATCH 3/4 drm/i915: use pat_index instead of cache_level
In reply to [email protected]From: Fei Yang <[email protected]>
Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent, having to translate between i915_cache_level and PAT index is not reliable, and makes the code more complicated.
From UMD's perspective there is also a necessity to set caching policy for performance fine tuning. It's much easier for the UMD to directly use PAT index because the behavior of each PAT index is clearly defined in Bspec. Having the abstracted i915_cache_level sitting in between would only cause more ambiguity.
For these reasons this patch replaces i915_cache_level with PAT index. Also note, the cache_level is not completely removed yet, because the KMD still has the need of creating buffer objects with simple cache settings such as cached, uncached, or writethrough. For such simple cases, using cache_level would help simplify the code.
--- drivers/gpu/drm/i915/display/intel_dpt.c | 12 +-- drivers/gpu/drm/i915/gem/i915_gem_domain.c | 27 ++---- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 10 ++- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_object.c | 52 +++++++++++- drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 + .../gpu/drm/i915/gem/i915_gem_object_types.h | 25 +++++- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 4 +- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 16 ++-- .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- .../drm/i915/gem/selftests/i915_gem_migrate.c | 2 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 10 ++- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 71 ++++++++-------- drivers/gpu/drm/i915/gt/gen8_ppgtt.h | 3 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 82 +++++++++---------- drivers/gpu/drm/i915/gt/intel_gtt.h | 20 ++--- drivers/gpu/drm/i915/gt/intel_migrate.c | 47 ++++++----- drivers/gpu/drm/i915/gt/intel_migrate.h | 13 ++- drivers/gpu/drm/i915/gt/intel_ppgtt.c | 6 +- drivers/gpu/drm/i915/gt/selftest_migrate.c | 47 ++++++----- drivers/gpu/drm/i915/gt/selftest_reset.c | 8 +- drivers/gpu/drm/i915/gt/selftest_timeline.c | 2 +- drivers/gpu/drm/i915/gt/selftest_tlb.c | 4 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 10 ++- drivers/gpu/drm/i915/i915_debugfs.c | 55 ++++++++++--- drivers/gpu/drm/i915/i915_gem.c | 16 +++- drivers/gpu/drm/i915/i915_gpu_error.c | 8 +- drivers/gpu/drm/i915/i915_vma.c | 16 ++-- drivers/gpu/drm/i915/i915_vma.h | 2 +- drivers/gpu/drm/i915/i915_vma_types.h | 2 - drivers/gpu/drm/i915/selftests/i915_gem.c | 5 +- .../gpu/drm/i915/selftests/i915_gem_evict.c | 4 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 15 ++-- .../drm/i915/selftests/intel_memory_region.c | 4 +- drivers/gpu/drm/i915/selftests/mock_gtt.c | 8 +- 36 files changed, 378 insertions(+), 239 deletions(-)
drivers/gpu/drm/i915/display/intel_dpt.c +6 -6
@@ -43,24 +43,24 @@ static void gen8_set_pte(void __iomem *addr, gen8_pte_t pte)static void dpt_insert_page (struct i915_address_space *vm,dma_addr_t addr,u64 offset, -enum i915_cache_level level, +unsigned int pat_index,u32 flags) {struct i915_dpt *dpt =i915_vm_to_dpt (vm);gen8_pte_t __iomem *base = dpt->iomem;gen8_set_pte (base + offset /I915_GTT_PAGE_SIZE , - vm->pte_encode (addr, level, flags)); + vm->pte_encode (addr, pat_index, flags)); }static void dpt_insert_entries (struct i915_address_space *vm,struct i915_vma_resource *vma_res, -enum i915_cache_level level, +unsigned int pat_index,u32 flags) {struct i915_dpt *dpt =i915_vm_to_dpt (vm);gen8_pte_t __iomem *base = dpt->iomem; -const gen8_pte_t pte_encode = vm->pte_encode (0 , level, flags); +const gen8_pte_t pte_encode = vm->pte_encode (0 , pat_index, flags);struct sgt_iter sgt_iter;dma_addr_t addr;int i;
@@ -83,7 +83,7 @@ static void dpt_clear_range(struct i915_address_space *vm,static void dpt_bind_vma (struct i915_address_space *vm,struct i915_vm_pt_stash *stash,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags) {u32 pte_flags;
@@ -98,7 +98,7 @@ static void dpt_bind_vma(struct i915_address_space *vm,if (vma_res->bi.lmem) pte_flags |=PTE_LM ; - vm->insert_entries (vm, vma_res, cache_level, pte_flags); + vm->insert_entries (vm, vma_res, pat_index, pte_flags); vma_res->page_sizes_gtt =I915_GTT_PAGE_SIZE ;
drivers/gpu/drm/i915/gem/i915_gem_domain.c +9 -18
@@ -27,8 +27,8 @@ static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj)if (IS_DGFX (i915))return false; -return !(obj->cache_level ==I915_CACHE_NONE || - obj->cache_level ==I915_CACHE_WT ); +return !(i915_gem_object_has_cache_level (obj,I915_CACHE_NONE ) || +i915_gem_object_has_cache_level (obj,I915_CACHE_WT )); }bool i915_gem_cpu_write_needs_clflush (struct drm_i915_gem_object *obj)
@@ -267,7 +267,7 @@ int i915_gem_object_set_cache_level(struct drm_i915_gem_object *obj, {int ret; -if (obj->cache_level == cache_level) +if (i915_gem_object_has_cache_level (obj, cache_level))return 0 ; ret = i915_gem_object_wait(obj,
@@ -278,10 +278,8 @@ int i915_gem_object_set_cache_level(struct drm_i915_gem_object *obj,return ret;/* Always invalidate stale cachelines */ -if (obj->cache_level != cache_level) { -i915_gem_object_set_cache_coherency (obj, cache_level); - obj->cache_dirty = true; - } +i915_gem_object_set_cache_coherency (obj, cache_level); + obj->cache_dirty = true;/* The cache-level will be applied when each vma is rebound. */ return i915_gem_object_unbind(obj,
@@ -306,20 +304,13 @@ int i915_gem_get_caching_ioctl(struct drm_device *dev, void *data, goto out; } -switch (obj->cache_level) { -case I915_CACHE_LLC : -case I915_CACHE_L3_LLC : +if (i915_gem_object_has_cache_level (obj,I915_CACHE_LLC ) || +i915_gem_object_has_cache_level (obj,I915_CACHE_L3_LLC )) args->caching =I915_CACHING_CACHED ; -break ; - -case I915_CACHE_WT : +else if (i915_gem_object_has_cache_level (obj,I915_CACHE_WT )) args->caching =I915_CACHING_DISPLAY ; -break ; - -default : +else args->caching =I915_CACHING_NONE ; -break ; - } out:rcu_read_unlock ();return err;
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +6 -4
@@ -642,7 +642,7 @@ static inline int use_cpu_reloc(const struct reloc_cache *cache,return (cache->has_llc || obj->cache_dirty || - obj->cache_level !=I915_CACHE_NONE ); + !i915_gem_object_has_cache_level (obj,I915_CACHE_NONE )); } static int eb_reserve_vma(struct i915_execbuffer *eb,
@@ -1323,8 +1323,10 @@ static void *reloc_iomap(struct i915_vma *batch, offset = cache->node.start;if (drm_mm_node_allocated (&cache->node)) { ggtt->vm.insert_page (&ggtt->vm, -i915_gem_object_get_dma_address (obj, page), - offset,I915_CACHE_NONE ,0 ); +i915_gem_object_get_dma_address (obj, page), + offset, +i915_gem_get_pat_index (ggtt->vm.i915,I915_CACHE_NONE ), +0 ); }else { offset += page <<PAGE_SHIFT ; }
@@ -1464,7 +1466,7 @@ eb_relocate_entry(struct i915_execbuffer *eb,reloc_cache_unmap (&eb->reloc_cache);mutex_lock (&vma->vm->mutex); err =i915_vma_bind (target->vma, - target->vma->obj->cache_level, + target->vma->obj->pat_index,PIN_GLOBAL ,NULL ,NULL );mutex_unlock (&vma->vm->mutex);reloc_cache_remap (&eb->reloc_cache, ev->vma->obj);
drivers/gpu/drm/i915/gem/i915_gem_mman.c +2 -1
@@ -383,7 +383,8 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf) }/* Access to snoopable pages through the GTT is incoherent. */ -if (obj->cache_level !=I915_CACHE_NONE && !HAS_LLC (i915)) { +if (!(i915_gem_object_has_cache_level (obj,I915_CACHE_NONE ) || +HAS_LLC (i915))) { ret = -EFAULT ; goto err_unpin; }
drivers/gpu/drm/i915/gem/i915_gem_object.c +51 -1
70 lines not on this page · raw message
drivers/gpu/drm/i915/gem/i915_gem_object.h +4 -0
@@ -34,6 +34,8 @@ static inline bool i915_gem_object_size_2big(u64 size)unsigned int i915_gem_get_pat_index (struct drm_i915_private *i915,enum i915_cache_level level); +bool i915_gem_object_has_cache_level (const struct drm_i915_gem_object *obj, +enum i915_cache_level lvl);void i915_gem_init__objects (struct drm_i915_private *i915);void i915_objects_module_exit (void );
@@ -764,6 +766,8 @@ bool i915_gem_object_has_unknown_state(struct drm_i915_gem_object *obj);void i915_gem_object_set_cache_coherency (struct drm_i915_gem_object *obj,unsigned int cache_level); +void i915_gem_object_set_pat_index (struct drm_i915_gem_object *obj, +unsigned int pat_index);bool i915_gem_object_can_bypass_llc (struct drm_i915_gem_object *obj);void i915_gem_object_flush_if_display (struct drm_i915_gem_object *obj);void i915_gem_object_flush_if_display_locked (struct drm_i915_gem_object *obj);
drivers/gpu/drm/i915/gem/i915_gem_object_types.h +22 -3
@@ -195,6 +195,7 @@ enum i915_cache_level {*/ I915_CACHE_WT ,I915_MAX_CACHE_LEVEL , + I915_CACHE_INVAL = I915_MAX_CACHE_LEVEL, }; enum i915_map_type {
@@ -358,10 +359,28 @@ struct drm_i915_gem_object {#define I915_BO_FLAG_STRUCT_PAGE BIT(0)/* Object backed by struct pages */ #define I915_BO_FLAG_IOMEM BIT(1)/* Object backed by IO memory */ /** -* @cache_level: The desired GTT caching level. +* @pat_index: The desired PAT index. +* +* See hardware specification for valid PAT indices for each platform. +* This field used to contain a value of enum i915_cache_level. It's +* changed to an unsigned int because PAT indices are being used by +* both UMD and KMD for caching policy control after GEN12. +* For backward compatibility, this field will continue to contain +* value of i915_cache_level for pre-GEN12 platforms so that the PTE +* encode functions for these legacy platforms can stay the same. +* In the meantime platform specific tables are created to translate +* i915_cache_level into pat index, for more details check the macros +* defined i915/i915_pci.c, e.g. PVC_CACHELEVEL. +*/ + unsigned int pat_index:6; +/** +* @cache_level: Indicate whether pat_index is set by UMD * -* See enum i915_cache_level for possible values, along with what -* each does. +* This used to hold desired GTT caching level, but is now replaced by +* pat_index. It's kept here for KMD to tell whether the pat_index is +* set by UMD or converted from enum i915_cache_level. +* This field should be 0 by default, but I915_CACHE_INVAL if the +* pat_index is set by UMD. */ unsigned int cache_level:3;/**
drivers/gpu/drm/i915/gem/i915_gem_stolen.c +3 -1
@@ -565,7 +565,9 @@ static void dbg_poison(struct i915_ggtt *ggtt, ggtt->vm.insert_page (&ggtt->vm, addr, ggtt->error_capture.start, -I915_CACHE_NONE ,0 ); +i915_gem_get_pat_index (ggtt->vm.i915, +I915_CACHE_NONE ), +0 );mb (); s = io_mapping_map_wc(&ggtt->iomap,
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +9 -7
@@ -214,7 +214,8 @@ static struct dma_fence *i915_ttm_accel_move(struct ttm_buffer_object *bo,intel_engine_pm_get (to_gt (i915)->migrate.context->engine); ret =intel_context_migrate_clear (to_gt (i915)->migrate.context, deps, - dst_st->sgl, dst_level, + dst_st->sgl, +i915_gem_get_pat_index (i915, dst_level),i915_ttm_gtt_binds_lmem (dst_mem),0 , &rq); }else {
@@ -227,12 +228,13 @@ static struct dma_fence *i915_ttm_accel_move(struct ttm_buffer_object *bo, src_level =i915_ttm_cache_level (i915, bo->resource, src_ttm);intel_engine_pm_get (to_gt (i915)->migrate.context->engine); ret =intel_context_migrate_copy (to_gt (i915)->migrate.context, - deps, src_rsgt->table.sgl, - src_level, -i915_ttm_gtt_binds_lmem (bo->resource), - dst_st->sgl, dst_level, -i915_ttm_gtt_binds_lmem (dst_mem), - &rq); + deps, src_rsgt->table.sgl, +i915_gem_get_pat_index (i915, src_level), +i915_ttm_gtt_binds_lmem (bo->resource), + dst_st->sgl, +i915_gem_get_pat_index (i915, dst_level), +i915_ttm_gtt_binds_lmem (dst_mem), + &rq);i915_refct_sgt_put (src_rsgt); }
drivers/gpu/drm/i915/gem/selftests/huge_pages.c +1 -1
@@ -354,7 +354,7 @@ fake_huge_pages_object(struct drm_i915_private *i915, u64 size, bool single) obj->write_domain =I915_GEM_DOMAIN_CPU ; obj->read_domains =I915_GEM_DOMAIN_CPU ; - obj->cache_level =I915_CACHE_NONE ; + obj->pat_index =i915_gem_get_pat_index (i915,I915_CACHE_NONE );return obj; }
drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c +1 -1
@@ -219,7 +219,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt,continue ; err =intel_migrate_clear (>->migrate, &ww, deps, - obj->mm.pages->sgl, obj->cache_level, + obj->mm.pages->sgl, obj->pat_index,i915_gem_object_is_lmem (obj),0xdeadbeaf , &rq);if (rq) {
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +1 -1
@@ -1222,7 +1222,7 @@ static int __igt_mmap_migrate(struct intel_memory_region **placements, } err =intel_context_migrate_clear (to_gt (i915)->migrate.context,NULL , - obj->mm.pages->sgl, obj->cache_level, + obj->mm.pages->sgl, obj->pat_index,i915_gem_object_is_lmem (obj),expand32 (POISON_INUSE ), &rq);i915_gem_object_unpin_pages (obj);
drivers/gpu/drm/i915/gt/gen6_ppgtt.c +6 -4
@@ -109,7 +109,7 @@ static void gen6_ppgtt_clear_range(struct i915_address_space *vm,static void gen6_ppgtt_insert_entries (struct i915_address_space *vm,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags) {struct i915_ppgtt *ppgtt =i915_vm_to_ppgtt (vm);
@@ -117,7 +117,7 @@ static void gen6_ppgtt_insert_entries(struct i915_address_space *vm,unsigned int first_entry = vma_res->start /I915_GTT_PAGE_SIZE ;unsigned int act_pt = first_entry /GEN6_PTES ;unsigned int act_pte = first_entry %GEN6_PTES ; -const u32 pte_encode = vm->pte_encode (0 , cache_level, flags); +const u32 pte_encode = vm->pte_encode (0 , pat_index, flags);struct sgt_dma iter =sgt_dma (vma_res);gen6_pte_t *vaddr;
@@ -227,7 +227,9 @@ static int gen6_ppgtt_init_scratch(struct gen6_ppgtt *ppgtt) vm->scratch[0 ]->encode = vm->pte_encode (px_dma (vm->scratch[0 ]), -I915_CACHE_NONE ,PTE_READ_ONLY ); +i915_gem_get_pat_index (vm->i915, +I915_CACHE_NONE ), +PTE_READ_ONLY ); vm->scratch[1 ] = vm->alloc_pt_dma (vm,I915_GTT_PAGE_SIZE_4K );if (IS_ERR (vm->scratch[1 ])) {
@@ -278,7 +280,7 @@ static void gen6_ppgtt_cleanup(struct i915_address_space *vm)static void pd_vma_bind (struct i915_address_space *vm,struct i915_vm_pt_stash *stash,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 unused) {struct i915_ggtt *ggtt =i915_vm_to_ggtt (vm);
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +34 -37
174 lines not on this page · raw message
drivers/gpu/drm/i915/gt/gen8_ppgtt.h +1 -2
@@ -10,13 +10,12 @@struct i915_address_space ;struct intel_gt ; -enum i915_cache_level ;struct i915_ppgtt *gen8_ppgtt_create (struct intel_gt *gt,unsigned long lmem_pt_obj_flags);u64 gen8_ggtt_pte_encode (dma_addr_t addr, -enum i915_cache_level level, +unsigned int pat_index,u32 flags);#endif
drivers/gpu/drm/i915/gt/intel_ggtt.c +40 -42
229 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_gtt.h +9 -11
@@ -164,8 +164,6 @@ typedef u64 gen8_pte_t;#define MTL_3_COH_2W REG_FIELD_PREP(MTL_PAT_INDEX_COH_MODE_MASK, 3)#define MTL_2_COH_1W REG_FIELD_PREP(MTL_PAT_INDEX_COH_MODE_MASK, 2) -enum i915_cache_level ; -struct drm_i915_gem_object ;struct i915_fence_reg ;struct i915_vma ;
@@ -233,7 +231,7 @@ struct i915_vma_ops {void (*bind_vma)(struct i915_address_space *vm,struct i915_vm_pt_stash *stash,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags);/* * Unmap an object from an address space. This usually consists of
@@ -305,7 +303,7 @@ struct i915_address_space { (*alloc_scratch_dma)(struct i915_address_space *vm, int sz);u64 (*pte_encode)(dma_addr_t addr, -enum i915_cache_level level, +unsigned int pat_index,u32 flags);/* Create a valid PTE */ #define PTE_READ_ONLY BIT(0)#define PTE_LM BIT(1)
@@ -320,20 +318,20 @@ struct i915_address_space {void (*insert_page)(struct i915_address_space *vm,dma_addr_t addr,u64 offset, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags);void (*insert_entries)(struct i915_address_space *vm,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags);void (*raw_insert_page)(struct i915_address_space *vm,dma_addr_t addr,u64 offset, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags);void (*raw_insert_entries)(struct i915_address_space *vm,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags);void (*cleanup)(struct i915_address_space *vm);
@@ -580,7 +578,7 @@ void ppgtt_init(struct i915_ppgtt *ppgtt, struct intel_gt *gt,void intel_ggtt_bind_vma (struct i915_address_space *vm,struct i915_vm_pt_stash *stash,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags);void intel_ggtt_unbind_vma (struct i915_address_space *vm,struct i915_vma_resource *vma_res);
@@ -638,7 +636,7 @@ void __set_pd_entry(struct i915_page_directory * const pd, const unsigned short idx, struct i915_page_table *pt, - u64 (*encode)(const dma_addr_t, const enum i915_cache_level)); + u64 (*encode)(const dma_addr_t, const unsigned int pat_index));#define set_pd_entry (pd, idx, to) \ __set_pd_entry((pd), (idx), px_pt(to), gen8_pde_encode)
@@ -658,7 +656,7 @@ void gen6_ggtt_invalidate(struct i915_ggtt *ggtt);void ppgtt_bind_vma (struct i915_address_space *vm,struct i915_vm_pt_stash *stash,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags);void ppgtt_unbind_vma (struct i915_address_space *vm,struct i915_vma_resource *vma_res);
drivers/gpu/drm/i915/gt/intel_migrate.c +26 -21
156 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_migrate.h +6 -7
@@ -16,7 +16,6 @@ struct i915_request;struct i915_gem_ww_ctx ;struct intel_gt ;struct scatterlist ; -enum i915_cache_level ;int intel_migrate_init (struct intel_migrate *m,struct intel_gt *gt);
@@ -26,20 +25,20 @@ int intel_migrate_copy(struct intel_migrate *m,struct i915_gem_ww_ctx *ww, const struct i915_deps *deps, struct scatterlist *src, - enum i915_cache_level src_cache_level, + unsigned int src_pat_index, bool src_is_lmem, struct scatterlist *dst, - enum i915_cache_level dst_cache_level, + unsigned int dst_pat_index, bool dst_is_lmem, struct i915_request **out);int intel_context_migrate_copy (struct intel_context *ce,const struct i915_deps *deps,struct scatterlist *src, -enum i915_cache_level src_cache_level, +unsigned int src_pat_index,bool src_is_lmem,struct scatterlist *dst, -enum i915_cache_level dst_cache_level, +unsigned int dst_pat_index,bool dst_is_lmem,struct i915_request **out);
@@ -48,7 +47,7 @@ intel_migrate_clear(struct intel_migrate *m,struct i915_gem_ww_ctx *ww, const struct i915_deps *deps, struct scatterlist *sg, - enum i915_cache_level cache_level, + unsigned int pat_index, bool is_lmem, u32 value, struct i915_request **out);
@@ -56,7 +55,7 @@ int intel_context_migrate_clear(struct intel_context *ce, const struct i915_deps *deps, struct scatterlist *sg, - enum i915_cache_level cache_level, + unsigned int pat_index, bool is_lmem, u32 value, struct i915_request **out);
drivers/gpu/drm/i915/gt/intel_ppgtt.c +3 -3
@@ -98,7 +98,7 @@ void __set_pd_entry(struct i915_page_directory * const pd, const unsigned short idx, struct i915_page_table * const to, - u64 (*encode)(const dma_addr_t, const enum i915_cache_level)) + u64 (*encode)(const dma_addr_t, const unsigned int)) { /* Each thread pre-pins the pd, and we may have a thread per pde. */ GEM_BUG_ON(atomic_read(px_used(pd)) > NALLOC * I915_PDES);
@@ -181,7 +181,7 @@ struct i915_ppgtt *i915_ppgtt_create(struct intel_gt *gt,void ppgtt_bind_vma (struct i915_address_space *vm,struct i915_vm_pt_stash *stash,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags) {u32 pte_flags;
@@ -199,7 +199,7 @@ void ppgtt_bind_vma(struct i915_address_space *vm,if (vma_res->bi.lmem) pte_flags |=PTE_LM ; - vm->insert_entries (vm, vma_res, cache_level, pte_flags); + vm->insert_entries (vm, vma_res, pat_index, pte_flags);wmb (); }
drivers/gpu/drm/i915/gt/selftest_migrate.c +25 -22
156 lines not on this page · raw message
drivers/gpu/drm/i915/gt/selftest_reset.c +6 -2
@@ -86,7 +86,9 @@ __igt_reset_stolen(struct intel_gt *gt, ggtt->vm.insert_page (&ggtt->vm, dma, ggtt->error_capture.start, -I915_CACHE_NONE ,0 ); +i915_gem_get_pat_index (gt->i915, +I915_CACHE_NONE ), +0 );mb (); s = io_mapping_map_wc(&ggtt->iomap,
@@ -127,7 +129,9 @@ __igt_reset_stolen(struct intel_gt *gt, ggtt->vm.insert_page (&ggtt->vm, dma, ggtt->error_capture.start, -I915_CACHE_NONE ,0 ); +i915_gem_get_pat_index (gt->i915, +I915_CACHE_NONE ), +0 );mb (); s = io_mapping_map_wc(&ggtt->iomap,
drivers/gpu/drm/i915/gt/selftest_timeline.c +1 -1
@@ -836,7 +836,7 @@ static int setup_watcher(struct hwsp_watcher *w, struct intel_gt *gt,return PTR_ERR (obj);/* keep the same cache settings as timeline */ -i915_gem_object_set_cache_coherency (obj, tl->hwsp_ggtt->obj->cache_level); +i915_gem_object_set_pat_index (obj, tl->hwsp_ggtt->obj->pat_index); w->map =i915_gem_object_pin_map_unlocked (obj,page_unmask_bits (tl->hwsp_ggtt->obj->mm.mapping));if (IS_ERR (w->map)) {
drivers/gpu/drm/i915/gt/selftest_tlb.c +3 -1
@@ -36,6 +36,8 @@ pte_tlbinv(struct intel_context *ce, u64 length, struct rnd_state *prng) { +const unsigned int pat_index = +i915_gem_get_pat_index (ce->vm->i915,I915_CACHE_NONE );struct drm_i915_gem_object *batch;struct drm_mm_node vb_node;struct i915_request *rq;
@@ -155,7 +157,7 @@ pte_tlbinv(struct intel_context *ce,/* Flip the PTE between A and B */ if (i915_gem_object_is_lmem (vb->obj)) pte_flags |=PTE_LM ; - ce->vm->insert_entries (ce->vm, &vb_res,0 , pte_flags); + ce->vm->insert_entries (ce->vm, &vb_res, pat_index, pte_flags);/* Flush the PTE update to concurrent HW */ tlbinv (ce->vm, addr & -length, length);
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +8 -2
@@ -890,9 +890,15 @@ static void uc_fw_bind_ggtt(struct intel_uc_fw *uc_fw) pte_flags |=PTE_LM ;if (ggtt->vm.raw_insert_entries) - ggtt->vm.raw_insert_entries (&ggtt->vm, dummy,I915_CACHE_NONE , pte_flags); + ggtt->vm.raw_insert_entries (&ggtt->vm, dummy, +i915_gem_get_pat_index (ggtt->vm.i915, +I915_CACHE_NONE ), + pte_flags);else - ggtt->vm.insert_entries (&ggtt->vm, dummy,I915_CACHE_NONE , pte_flags); + ggtt->vm.insert_entries (&ggtt->vm, dummy, +i915_gem_get_pat_index (ggtt->vm.i915, +I915_CACHE_NONE ), + pte_flags); }static void uc_fw_unbind_ggtt (struct intel_uc_fw *uc_fw)
drivers/gpu/drm/i915/i915_debugfs.c +45 -10
73 lines not on this page · raw message
drivers/gpu/drm/i915/i915_gem.c +12 -4
@@ -420,8 +420,12 @@ i915_gem_gtt_pread(struct drm_i915_gem_object *obj, page_length = remain < page_length ? remain : page_length;if (drm_mm_node_allocated (&node)) { ggtt->vm.insert_page (&ggtt->vm, -i915_gem_object_get_dma_address (obj, offset >>PAGE_SHIFT ), - node.start,I915_CACHE_NONE ,0 ); +i915_gem_object_get_dma_address (obj, + offset >>PAGE_SHIFT ), + node.start, +i915_gem_get_pat_index (i915, +I915_CACHE_NONE ), +0 ); }else { page_base += offset &PAGE_MASK ; }
@@ -598,8 +602,12 @@ i915_gem_gtt_pwrite_fast(struct drm_i915_gem_object *obj,/* flush the write before we modify the GGTT */ intel_gt_flush_ggtt_writes (ggtt->vm.gt); ggtt->vm.insert_page (&ggtt->vm, -i915_gem_object_get_dma_address (obj, offset >>PAGE_SHIFT ), - node.start,I915_CACHE_NONE ,0 ); +i915_gem_object_get_dma_address (obj, + offset >>PAGE_SHIFT ), + node.start, +i915_gem_get_pat_index (i915, +I915_CACHE_NONE ), +0 );wmb ();/* flush modifications to the GGTT (insert_page) */ }else { page_base += offset &PAGE_MASK ;
drivers/gpu/drm/i915/i915_gpu_error.c +6 -2
@@ -1117,10 +1117,14 @@ i915_vma_coredump_create(const struct intel_gt *gt,mutex_lock (&ggtt->error_mutex);if (ggtt->vm.raw_insert_page) ggtt->vm.raw_insert_page (&ggtt->vm, dma, slot, -I915_CACHE_NONE ,0 ); +i915_gem_get_pat_index (gt->i915, +I915_CACHE_NONE ), +0 );else ggtt->vm.insert_page (&ggtt->vm, dma, slot, -I915_CACHE_NONE ,0 ); +i915_gem_get_pat_index (gt->i915, +I915_CACHE_NONE ), +0 );mb (); s =io_mapping_map_wc (&ggtt->iomap, slot,PAGE_SIZE );
drivers/gpu/drm/i915/i915_vma.c +8 -8
@@ -315,7 +315,7 @@ struct i915_vma_work {struct i915_vma_resource *vma_res;struct drm_i915_gem_object *obj;struct i915_sw_dma_fence_cb cb; -enum i915_cache_level cache_level; +unsigned int pat_index;unsigned int flags; };
@@ -334,7 +334,7 @@ static void __vma_bind(struct dma_fence_work *work)return ; vma_res->ops->bind_vma (vma_res->vm, &vw->stash, - vma_res, vw->cache_level, vw->flags); + vma_res, vw->pat_index, vw->flags); }static void __vma_release (struct dma_fence_work *work)
@@ -426,7 +426,7 @@ i915_vma_resource_init_from_vma(struct i915_vma_resource *vma_res,/** * i915_vma_bind - Sets up PTEs for an VMA in it's corresponding address space. * @vma: VMA to map -* @cache_level: mapping cache level +* @pat_index: PAT index to set in PTE * @flags: flags like global or local mapping * @work: preallocated worker for allocating and binding the PTE * @vma_res: pointer to a preallocated vma resource. The resource is either
@@ -437,7 +437,7 @@ i915_vma_resource_init_from_vma(struct i915_vma_resource *vma_res,* Note that DMA addresses are also the only part of the SG table we care about. */ int i915_vma_bind (struct i915_vma *vma, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags,struct i915_vma_work *work,struct i915_vma_resource *vma_res)
@@ -507,7 +507,7 @@ int i915_vma_bind(struct i915_vma *vma,struct dma_fence *prev; work->vma_res =i915_vma_resource_get (vma->resource); - work->cache_level = cache_level; + work->pat_index = pat_index; work->flags = bind_flags;/*
@@ -537,7 +537,7 @@ int i915_vma_bind(struct i915_vma *vma,return ret; } - vma->ops->bind_vma (vma->vm,NULL , vma->resource, cache_level, + vma->ops->bind_vma (vma->vm,NULL , vma->resource, pat_index, bind_flags); }
@@ -814,7 +814,7 @@ i915_vma_insert(struct i915_vma *vma, struct i915_gem_ww_ctx *ww, color =0 ;if (i915_vm_has_cache_coloring (vma->vm)) - color = vma->obj->cache_level; + color = vma->obj->pat_index;if (flags &PIN_OFFSET_FIXED ) {u64 offset = flags &PIN_OFFSET_MASK ;
@@ -1518,7 +1518,7 @@ int i915_vma_pin_ww(struct i915_vma *vma, struct i915_gem_ww_ctx *ww,GEM_BUG_ON (!vma->pages); err =i915_vma_bind (vma, - vma->obj->cache_level, + vma->obj->pat_index, flags, work, vma_res); vma_res =NULL ;if (err)
drivers/gpu/drm/i915/i915_vma.h +1 -1
@@ -250,7 +250,7 @@ i915_vma_compare(struct i915_vma *vma,struct i915_vma_work *i915_vma_work (void );int i915_vma_bind (struct i915_vma *vma, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags,struct i915_vma_work *work,struct i915_vma_resource *vma_res);
drivers/gpu/drm/i915/i915_vma_types.h +0 -2
@@ -32,8 +32,6 @@#include "gem/i915_gem_object_types.h" -enum i915_cache_level ; -/** * DOC: Global GTT views *
drivers/gpu/drm/i915/selftests/i915_gem.c +4 -1
@@ -57,7 +57,10 @@ static void trash_stolen(struct drm_i915_private *i915)u32 __iomem *s;int x; - ggtt->vm.insert_page (&ggtt->vm, dma, slot,I915_CACHE_NONE ,0 ); + ggtt->vm.insert_page (&ggtt->vm, dma, slot, +i915_gem_get_pat_index (i915, +I915_CACHE_NONE ), +0 ); s =io_mapping_map_atomic_wc (&ggtt->iomap, slot);for (x =0 ; x <PAGE_SIZE /sizeof (u32); x++) {
drivers/gpu/drm/i915/selftests/i915_gem_evict.c +2 -2
@@ -245,7 +245,7 @@ static int igt_evict_for_cache_color(void *arg)struct drm_mm_node target = { .start =I915_GTT_PAGE_SIZE *2 , .size =I915_GTT_PAGE_SIZE , - .color =I915_CACHE_LLC , + .color =i915_gem_get_pat_index (gt->i915,I915_CACHE_LLC ), };struct drm_i915_gem_object *obj;struct i915_vma *vma;
@@ -308,7 +308,7 @@ static int igt_evict_for_cache_color(void *arg)/* Attempt to remove the first *pinned* vma, by removing the (empty) * neighbour -- this should fail. */ - target.color =I915_CACHE_L3_LLC ; + target.color =i915_gem_get_pat_index (gt->i915,I915_CACHE_L3_LLC );mutex_lock (&ggtt->vm.mutex); err =i915_gem_evict_for_node (&ggtt->vm,NULL , &target,0 );
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +10 -5
@@ -135,7 +135,7 @@ fake_dma_object(struct drm_i915_private *i915, u64 size) obj->write_domain =I915_GEM_DOMAIN_CPU ; obj->read_domains =I915_GEM_DOMAIN_CPU ; - obj->cache_level =I915_CACHE_NONE ; + obj->pat_index =i915_gem_get_pat_index (i915,I915_CACHE_NONE );/* Preallocate the "backing storage" */ if (i915_gem_object_pin_pages_unlocked (obj))
@@ -359,7 +359,9 @@ static int lowlevel_hole(struct i915_address_space *vm,with_intel_runtime_pm (vm->gt->uncore->rpm, wakeref) vm->insert_entries(vm, mock_vma_res, -I915_CACHE_NONE ,0 ); +i915_gem_get_pat_index (vm->i915, +I915_CACHE_NONE ), +0 ); } count = n;
@@ -1377,7 +1379,10 @@ static int igt_ggtt_page(void *arg) ggtt->vm.insert_page (&ggtt->vm,i915_gem_object_get_dma_address (obj,0 ), - offset,I915_CACHE_NONE ,0 ); + offset, +i915_gem_get_pat_index (i915, +I915_CACHE_NONE ), +0 ); } order =i915_random_order (count, &prng);
@@ -1510,7 +1515,7 @@ static int reserve_gtt_with_resource(struct i915_vma *vma, u64 offset)mutex_lock (&vm->mutex); err =i915_gem_gtt_reserve (vm,NULL , &vma->node, obj->base.size, offset, - obj->cache_level, + obj->pat_index,0 );if (!err) {i915_vma_resource_init_from_vma (vma_res, vma);
@@ -1690,7 +1695,7 @@ static int insert_gtt_with_resource(struct i915_vma *vma)mutex_lock (&vm->mutex); err =i915_gem_gtt_insert (vm,NULL , &vma->node, obj->base.size,0 , - obj->cache_level,0 , vm->total,0 ); + obj->pat_index,0 , vm->total,0 );if (!err) {i915_vma_resource_init_from_vma (vma_res, vma); vma->resource = vma_res;
drivers/gpu/drm/i915/selftests/intel_memory_region.c +3 -1
@@ -1070,7 +1070,9 @@ static int igt_lmem_write_cpu(void *arg)/* Put the pages into a known state -- from the gpu for added fun */ intel_engine_pm_get (engine); err =intel_context_migrate_clear (engine->gt->migrate.context,NULL , - obj->mm.pages->sgl,I915_CACHE_NONE , + obj->mm.pages->sgl, +i915_gem_get_pat_index (i915, +I915_CACHE_NONE ), true,0xdeadbeaf , &rq);if (rq) { dma_resv_add_fence(obj->base.resv, &rq->fence,
drivers/gpu/drm/i915/selftests/mock_gtt.c +4 -4
@@ -27,21 +27,21 @@static void mock_insert_page (struct i915_address_space *vm,dma_addr_t addr,u64 offset, -enum i915_cache_level level, +unsigned int pat_index,u32 flags) { }static void mock_insert_entries (struct i915_address_space *vm,struct i915_vma_resource *vma_res, -enum i915_cache_level level,u32 flags) +unsigned int pat_index,u32 flags) { }static void mock_bind_ppgtt (struct i915_address_space *vm,struct i915_vm_pt_stash *stash,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags) {GEM_BUG_ON (flags &I915_VMA_GLOBAL_BIND );
@@ -94,7 +94,7 @@ struct i915_ppgtt *mock_ppgtt(struct drm_i915_private *i915, const char *name)static void mock_bind_ggtt (struct i915_address_space *vm,struct i915_vm_pt_stash *stash,struct i915_vma_resource *vma_res, -enum i915_cache_level cache_level, +unsigned int pat_index,u32 flags) { }
Signature · 1 line
2.25.1
PATCH 4/4 drm/i915: make sure correct pte encode is used
In reply to [email protected]From: Fei Yang <[email protected]>
PTE encode is platform dependent. After replacing cache_level with pat_index, the newly introduced mtl_pte_encode is actually generic for all gen12 platforms, thus rename it to gen12_pte_encode and apply it to all gen12 platforms.
--- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +5 -5
@@ -55,9 +55,9 @@ static u64 gen8_pte_encode(dma_addr_t addr,return pte; } -static u64 mtl_pte_encode (dma_addr_t addr, -unsigned int pat_index, -u32 flags) +static u64 gen12_pte_encode (dma_addr_t addr, +unsigned int pat_index, +u32 flags) {gen8_pte_t pte = addr |GEN8_PAGE_PRESENT |GEN8_PAGE_RW ;
@@ -994,8 +994,8 @@ struct i915_ppgtt *gen8_ppgtt_create(struct intel_gt *gt,*/ ppgtt->vm.alloc_scratch_dma = alloc_pt_dma; -if (GRAPHICS_VER_FULL (gt->i915) >=IP_VER (12 ,70 )) - ppgtt->vm.pte_encode = mtl_pte_encode; +if (GRAPHICS_VER (gt->i915) >=12 ) + ppgtt->vm.pte_encode = gen12_pte_encode;else ppgtt->vm.pte_encode = gen8_pte_encode;
Signature · 1 line
2.25.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: add PTE encode function
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/mtl: add PTE encode function
URL : https://patchwork.freedesktop.org/series/116868/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: add PTE encode function
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/mtl: add PTE encode function
URL : https://patchwork.freedesktop.org/series/116868/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13050 -> Patchwork_116868v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_116868v1 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_116868v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v1/index.html
Participating hosts (37 -> 35)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_116868v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@guc:
- bat-jsl-3: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13050/bat-jsl-3/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v1/bat-jsl-3/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_116868v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][3] ([i915#3546]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v1/bat-adlp-9/igt@[email protected]
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-FAIL][4] ([i915#6367]) -> [DMESG-FAIL][5] ([i915#6367] / [i915#7996])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13050/bat-rpls-1/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v1/bat-rpls-1/igt@i915_selftest@[email protected]
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* Linux: CI_DRM_13050 -> Patchwork_116868v1
CI-20190529: 20190529
CI_DRM_13050: 9687e107450f2d5b270c04f8d17183e603d2c4f1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7264: 2f0a07378e58e5c7d7b589b39ace7e3a2317f6b2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_116868v1: 9687e107450f2d5b270c04f8d17183e603d2c4f1 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
ca2b7e23992b drm/i915: make sure correct pte encode is used 151ad09f5b58 drm/i915: use pat_index instead of cache_level 4b0bed9fd5a6 drm/i915: preparation for using PAT index 3768dd1d2eb8 drm/i915/mtl: Add PTE encode function
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v1/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: add PTE encode function (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/mtl: add PTE encode function (rev2)
URL : https://patchwork.freedesktop.org/series/116868/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: add PTE encode function (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/mtl: add PTE encode function (rev2)
URL : https://patchwork.freedesktop.org/series/116868/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13055 -> Patchwork_116868v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/index.html
Participating hosts (38 -> 38)
------------------------------
Additional (1): bat-mtlp-8
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_116868v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334] / [i915#7872])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-FAIL][3] ([i915#6367])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-1: NOTRUN -> [SKIP][4] ([i915#7828])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-rpls-1/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
- bat-dg2-8: [PASS][5] -> [FAIL][6] ([i915#7932])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][7] ([i915#3546]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-adlp-9/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-1: NOTRUN -> [SKIP][8] ([i915#1845])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-rpls-1/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@lmem0:
- bat-dg2-9: [FAIL][9] ([fdo#103375]) -> [PASS][10] +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/bat-dg2-9/igt@gem_exec_suspend@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-dg2-9/igt@gem_exec_suspend@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: [ABORT][11] ([i915#6687] / [i915#7978]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/bat-rpls-1/igt@gem_exec_suspend@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-rpls-1/igt@gem_exec_suspend@[email protected]
* igt@i915_selftest@live@mman:
- bat-rpls-1: [TIMEOUT][13] ([i915#6794]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/bat-rpls-1/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
- bat-dg2-8: [FAIL][15] ([i915#7932]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-3:
- bat-dg2-9: [FAIL][17] ([fdo#103375] / [i915#7932]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/bat-dg2-9/igt@kms_pipe_crc_basic@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/bat-dg2-9/igt@kms_pipe_crc_basic@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8176]: https://gitlab.freedesktop.org/drm/intel/issues/8176
Build changes
-------------
* Linux: CI_DRM_13055 -> Patchwork_116868v2
CI-20190529: 20190529
CI_DRM_13055: 584c38171a55960f8181409f9485445f7b7fed24 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7267: a267f0236e06fc282e3dc3b8c7d76f9ed6088d9b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_116868v2: 584c38171a55960f8181409f9485445f7b7fed24 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
764b3df6d5d4 drm/i915: make sure correct pte encode is used 5a01e0b9eb82 drm/i915: use pat_index instead of cache_level 208fec75b5cf drm/i915: preparation for using PAT index a2fb0188ca33 drm/i915/mtl: Add PTE encode function
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: add PTE encode function (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915/mtl: add PTE encode function (rev2)
URL : https://patchwork.freedesktop.org/series/116868/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13055_full -> Patchwork_116868v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 8)
------------------------------
Additional (1): shard-rkl0
Known issues
------------
Here are the changes found in Patchwork_116868v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_barrier_race@remote-request@rcs0:
- shard-glk: [PASS][1] -> [ABORT][2] ([i915#8211])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-glk2/igt@gem_barrier_race@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-glk1/igt@gem_barrier_race@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2846])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-glk2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-glk1/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-apl: [PASS][5] -> [FAIL][6] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-apl2/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-apl6/igt@gem_exec_fair@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2521])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-glk3/igt@kms_async_flips@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-glk5/igt@kms_async_flips@[email protected]
* igt@kms_color@ctm-green-to-red@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271]) +35 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-snb1/igt@kms_color@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][10] -> [FAIL][11] ([i915#2346])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][12] ([i915#7742]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-rkl-4/igt@drm_fdinfo@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-rkl-6/igt@drm_fdinfo@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][14] ([i915#2842]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-apl7/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-apl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-tglu-6/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-tglu-8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-rkl-1/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-rkl-2/igt@gem_exec_fair@[email protected]
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][20] ([i915#1397]) -> [PASS][21] +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-rkl-3/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-rkl-7/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [DMESG-FAIL][22] ([i915#5334]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-apl3/igt@i915_selftest@live@gt_heartbeat.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_cursor_legacy@forked-move@pipe-b:
- {shard-rkl}: [INCOMPLETE][24] ([i915#8011]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-rkl-6/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
- shard-glk: [FAIL][26] ([i915#79]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13055/shard-glk2/igt@kms_flip@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/shard-glk6/igt@kms_flip@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8150]: https://gitlab.freedesktop.org/drm/intel/issues/8150
[i915#8155]: https://gitlab.freedesktop.org/drm/intel/issues/8155
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
Build changes
-------------
* Linux: CI_DRM_13055 -> Patchwork_116868v2
CI-20190529: 20190529
CI_DRM_13055: 584c38171a55960f8181409f9485445f7b7fed24 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7267: a267f0236e06fc282e3dc3b8c7d76f9ed6088d9b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_116868v2: 584c38171a55960f8181409f9485445f7b7fed24 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116868v2/index.html