Skip to contentSkip to conversation

Fix addition on an uninitialized variable 'run'

PATCH Superseded Colin Ian King 1 participant 2 messages Apr 24, 2023

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix addition on an uninitialized variable 'run'

The variable run is not initialized however it is being accumulated by the return value from the call to ikm_run_monitor. Fix this by initializing run to zero at the start of the function.

Fixes 4bc4b131d44c ("rv: Add rv tool")
---
 tools/verification/rv/src/rv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/verification/rv/src/rv.c +1 -1
index e601cd9c411e..1ddb85532816 100644
@@ -74,7 +74,7 @@ static void rv_list(int argc, char **argv)
 static void rv_mon(int argc, char **argv)
 {
 	char *monitor_name;
-	int i, run;
+	int i, run = 0;
 
 	static const char *const usage[] = {
 		"",
Signature · 1 line
2.30.2
#1 lore raw
Quoted 16 lines · Colin Ian King

The variable run is not initialized however it is being accumulated by the return value from the call to ikm_run_monitor. Fix this by initializing run to zero at the start of the function.

Fixes 4bc4b131d44c ("rv: Add rv tool")
---
  tools/verification/rv/src/rv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tools/verification/rv/src/rv.c +0 -0
index e601cd9c411e..1ddb85532816 100644

tools/verification/rv/src/rv.c static void rv_list(int argc, char **argv) · line 80

Quoted 8 lines
tools/verification/rv/src/rv.c +1 -1
@@ -74,7 +74,7 @@ static void rv_list(int argc, char **argv)
  static void rv_mon(int argc, char **argv)
  {
  	char *monitor_name;
-	int i, run;
+	int i, run = 0;
 
  	static const char *const usage[] = {
  		"",

Oops, I forgot the V2, will re-send as a V3. My bad.