evaluate: bail out if new flowtable does not specify hook and priority
Pablo Neira Ayuso
maintainerPATCH 1/1 evaluate: bail out if new flowtable does not specify hook and priority
If user forgets to specify the hook and priority and the flowtable does not exist, then bail out:
# cat flowtable-incomplete.nft
table t {
flowtable f {
devices = { lo }
}
}
# nft -f /tmp/k
flowtable-incomplete.nft:2:12-12: Error: missing hook and priority in flowtable declaration
flowtable f {
^Update one existing tests/shell to specify a hook and priority.
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- src/evaluate.c | 6 +++++- tests/shell/testcases/owner/0001-flowtable-uaf | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-)
src/evaluate.c +5 -1
@@ -4732,8 +4732,12 @@ static int flowtable_evaluate(struct eval_ctx *ctx, struct flowtable *ft)if (table ==NULL )return table_not_found (ctx); -if (!ft_cache_find (table, ft->handle.flowtable.name)) +if (!ft_cache_find (table, ft->handle.flowtable.name)) { +if (!ft->hook.name) +return chain_error (ctx, ft,"missing hook and priority in flowtable declaration" ); +ft_cache_add (flowtable_get (ft), table); + }if (ft->hook.name) { ft->hook.num =str2hooknum (NFPROTO_NETDEV , ft->hook.name);
tests/shell/testcases/owner/0001-flowtable-uaf +2 -0
@@ -6,6 +6,7 @@ $NFT -f - <<EOF table t { flags owner flowtable f { + hook ingress priority 0 devices = { lo } } }
@@ -16,6 +17,7 @@ $NFT -f - <<EOF table t { flags owner flowtable f { + hook ingress priority 0 devices = { lo } } }
Signature · 1 line
2.30.2