migration: Disable postcopy + multifd migration
PATCH v2 1/1 migration: Disable postcopy + multifd migration
Since the introduction of multifd, it's possible to perform a multifd migration and finish it using postcopy.
A bug introduced by yank (fixed on cfc3bcf373) was previously preventing a successful use of this migration scenario, and now thing should be working on most scenarios.
But since there is not enough testing/support nor any reported users for this scenario, we should disable this combination before it may cause any problems for users.
---
Changes since RFC:
- Updated to latest master branch
- Included Acks and Reviews
migration/options.c | 5 +++++ 1 file changed, 5 insertions(+)
migration/options.c +5 -0
@@ -322,6 +322,11 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps, Error **errp)error_setg (errp,"Postcopy is not compatible with ignore-shared" );return false; } + +if (cap_list[MIGRATION_CAPABILITY_MULTIFD ]) { +error_setg (errp,"Postcopy is not yet compatible with multifd" ); +return false; + } }if (new_caps[MIGRATION_CAPABILITY_BACKGROUND_SNAPSHOT ]) {
Signature · 1 line
2.40.0
Quoted 7 lines · Leonardo Bras
Since the introduction of multifd, it's possible to perform a multifd migration and finish it using postcopy.
A bug introduced by yank (fixed on
cfc3bcf373) was previously preventing a successful use of this migration scenario, and now thing should be working on most scenarios.
Quoted 8 lines
But since there is not enough testing/support nor any reported users for this scenario, we should disable this combination before it may cause any problems for users.
Suggested-by Dr. David Alan Gilbert <[email protected]>Signed-off-by Leonardo Bras <[email protected]>Acked-by Peter Xu <[email protected]>Reviewed-by Dr. David Alan Gilbert <[email protected]>
queued.