Skip to contentSkip to conversation

mnl: incomplete extended error reporting for singleton device in chain

PATCH New Pablo Neira Ayuso 1 participant 1 message Apr 25, 2023 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 mnl: incomplete extended error reporting for singleton device in chain

Fix error reporting when single device is specifies in chain:

 # nft add chain netdev filter ingress '{ devices = { x }; }'
 add chain netdev filter ingress { devices = { x }; }
                                               ^
Fixes a66b5ad9540d ("src: allow for updating devices on existing netdev chain")
---
 src/mnl.c | 1 +
 1 file changed, 1 insertion(+)
src/mnl.c +1 -0
index 5dcfd9a04c4b..adc0bd3d61cf 100644
@@ -790,6 +790,7 @@ static void mnl_nft_chain_devs_build(struct nlmsghdr *nlh, struct cmd *cmd)
 
 	dev_array = nft_dev_array(dev_expr, &num_devs);
 	if (num_devs == 1) {
+		cmd_add_loc(cmd, nlh->nlmsg_len, dev_array[0].location);
 		mnl_attr_put_strz(nlh, NFTA_HOOK_DEV, dev_array[0].ifname);
 	} else {
 		nest_dev = mnl_attr_nest_start(nlh, NFTA_HOOK_DEVS);
Signature · 1 line
2.30.2