drm/amd/display: set variable custom_backlight_curve0 storage-class-specifier to static
Subsystems (3)
PATCH 1/1 drm/amd/display: set variable custom_backlight_curve0 storage-class-specifier to static
smatch reports drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:119:31:
warning: symbol 'custom_backlight_curve0' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static
Signed-off-by Tom Rix <[email protected]>
--- drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/modules/power/power_helpers.c +1 -1
@@ -116,7 +116,7 @@ static const struct abm_parameters * const abm_settings[] = { abm_settings_config2, }; -const struct dm_bl_data_point custom_backlight_curve0[] = { +static const struct dm_bl_data_point custom_backlight_curve0[] = { {2 ,14 }, {4 ,16 }, {6 ,18 }, {8 ,21 }, {10 ,23 }, {12 ,26 }, {14 ,29 }, {16 ,32 }, {18 ,35 }, {20 ,38 }, {22 ,41 }, {24 ,44 }, {26 ,48 }, {28 ,52 }, {30 ,55 }, {32 ,59 }, {34 ,62 }, {36 ,67 }, {38 ,71 }, {40 ,75 }, {42 ,80 }, {44 ,84 }, {46 ,88 }, {48 ,93 }, {50 ,98 },
Signature · 1 line
2.27.0
Hamza Mahfooz
AppliedQuoted 6 lines · Tom Rix
smatch reports
drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:119:31:
warning: symbol 'custom_backlight_curve0' was not declared. Should it be static?This variable is only used in its defining file, so it should be static
Signed-off-by Tom Rix <[email protected]>
Applied, thanks!
Quoted 17 lines
--- drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/modules/power/power_helpers.c +1
-1@@ -116,7 +116,7 @@ static const struct abm_parameters * const abm_settings[] = { abm_settings_config2, }; -const struct dm_bl_data_point custom_backlight_curve0[] = { +static const struct dm_bl_data_point custom_backlight_curve0[] = { {2 ,14 }, {4 ,16 }, {6 ,18 }, {8 ,21 }, {10 ,23 }, {12 ,26 }, {14 ,29 }, {16 ,32 }, {18 ,35 }, {20 ,38 }, {22 ,41 }, {24 ,44 }, {26 ,48 }, {28 ,52 }, {30 ,55 }, {32 ,59 }, {34 ,62 }, {36 ,67 }, {38 ,71 }, {40 ,75 }, {42 ,80 }, {44 ,84 }, {46 ,88 }, {48 ,93 }, {50 ,98 },
Signature · 1 line
Hamza