Skip to contentSkip to conversation

xfs: drop EXPERIMENTAL tag for large extent counts

PATCH In review Darrick J. Wong 2 participants 3 messages Apr 20, 2023 – Apr 27, 2023 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: drop EXPERIMENTAL tag for large extent counts

From: Darrick J. Wong <[email protected]>

This feature has been baking in upstream for ~10mo with no bug reports. It seems to work fine here, let's get rid of the scary warnings?

---
 fs/xfs/xfs_super.c |    4 ----
 1 file changed, 4 deletions(-)
fs/xfs/xfs_super.c +0 -4
index 4d2e87462ac4..dc13ff4ea25e 100644
@@ -1683,10 +1683,6 @@ xfs_fs_fill_super(
 		goto out_filestream_unmount;
 	}
 
-	if (xfs_has_large_extent_counts(mp))
-		xfs_warn(mp,
-	"EXPERIMENTAL Large extent counts feature in use. Use at your own risk!");
-
 	error = xfs_mountfs(mp);
 	if (error)
 		goto out_filestream_unmount;
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

This feature has been baking in upstream for ~10mo with no bug reports. It seems to work fine here, let's get rid of the scary warnings?

Are you proposing this for the 6.4 cycle (next weeks merge window) or for the cycle after this? I don't see an issue with removing the experimental tag, but I do think it's a bit late for this cycle....

Quoted 10 lines
---
 fs/xfs/xfs_super.c |    4 ----
 1 file changed, 4 deletions(-)
fs/xfs/xfs_super.c +0 -0
index 4d2e87462ac4..dc13ff4ea25e 100644

fs/xfs/xfs_super.c xfs_fs_fill_super( · line 1689

Quoted 7 lines
fs/xfs/xfs_super.c +0 -4
@@ -1683,10 +1683,6 @@ xfs_fs_fill_super(
 		goto out_filestream_unmount;
 	}
 
-	if (xfs_has_large_extent_counts(mp))
-		xfs_warn(mp,
-	"EXPERIMENTAL Large extent counts feature in use. Use at your own risk!");
-
Signature · 2 lines
Dave Chinner
[email protected]
#2 lore raw
Quoted 9 lines · Dave Chinner
Quoted 4 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

This feature has been baking in upstream for ~10mo with no bug reports. It seems to work fine here, let's get rid of the scary warnings?

Are you proposing this for the 6.4 cycle (next weeks merge window) or for the cycle after this? I don't see an issue with removing the experimental tag, but I do think it's a bit late for this cycle....

Doh, I totally forgot to reply to this. I /was/ actually targetting 6.4, but I don't have any particular problem if this slips to 6.5.

--D

Quoted 23 lines
Quoted 10 lines
---
 fs/xfs/xfs_super.c |    4 ----
 1 file changed, 4 deletions(-)
fs/xfs/xfs_super.c +0 -0
index 4d2e87462ac4..dc13ff4ea25e 100644

fs/xfs/xfs_super.c xfs_fs_fill_super( · line 1689

Quoted 7 lines
fs/xfs/xfs_super.c +0 -4
@@ -1683,10 +1683,6 @@ xfs_fs_fill_super(
 		goto out_filestream_unmount;
 	}
 
-	if (xfs_has_large_extent_counts(mp))
-		xfs_warn(mp,
-	"EXPERIMENTAL Large extent counts feature in use. Use at your own risk!");
-
Signature · 2 lines
Dave Chinner
[email protected]