Skip to contentSkip to conversation

gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()

PATCH Applied Yang Li 5 participants 5 messages Apr 28, 2023 – May 23, 2023

Subsystems (3)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 gpio: brcmstb: Use devm_platform_get_and_ioremap_resource()

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
 drivers/gpio/gpio-brcmstb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpio/gpio-brcmstb.c +1 -2
index c55b35da61a0..6566517fe0d8 100644
@@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, priv);
 	INIT_LIST_HEAD(&priv->bank_list);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	reg_base = devm_ioremap_resource(dev, res);
+	reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(reg_base))
 		return PTR_ERR(reg_base);
 
Signature · 1 line
2.20.1.7.g153144c
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Yang Li
Quoted 14 lines · Yang Li

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
  drivers/gpio/gpio-brcmstb.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpio/gpio-brcmstb.c +0 -0
index c55b35da61a0..6566517fe0d8 100644

drivers/gpio/gpio-brcmstb.c static int brcmstb_gpio_probe(struct platform_device *pdev) · line 615

Quoted 9 lines
drivers/gpio/gpio-brcmstb.c +1 -2
@@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
  	platform_set_drvdata(pdev, priv);
  	INIT_LIST_HEAD(&priv->bank_list);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	reg_base = devm_ioremap_resource(dev, res);
+	reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
  	if (IS_ERR(reg_base))
  		return PTR_ERR(reg_base);
 
#4 lore raw
In reply to Yang Li
Quoted 25 lines · Yang Li

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
 drivers/gpio/gpio-brcmstb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpio/gpio-brcmstb.c +1 -3
index c55b35da61a0..6566517fe0d8 100644
@@ -609,8 +609,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, priv);
        INIT_LIST_HEAD(&priv->bank_list);
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       reg_base = devm_ioremap_resource(dev, res);
+       reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
        if (IS_ERR(reg_base))
                return PTR_ERR(reg_base);
 
--
Quoted 2 lines

2.20.1.7.g153144c

Applied, thanks!

Bart

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel