tests/qtest: Disable the spice test of readconfig-test on FreeBSD
PATCH 1/1 tests/qtest: Disable the spice test of readconfig-test on FreeBSD
The spice test is currently hanging on FreeBSD. It likely was never working before, since in the past, our configure script was failing to detect this feature due to a bug in the spice package there (it just got enabled recently by the commit
https://cgit.freebsd.org/ports/commit/?id=cf16b1c9063351325f0 ). To get the CI working again, let's disable the failing test for now until someone has enough spare time to debug and fix the real underlying problem.
--- tests/qtest/readconfig-test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tests/qtest/readconfig-test.c +3 -3
@@ -86,8 +86,8 @@ static void test_x86_memdev(void)qtest_quit (qts); } - -#ifdef CONFIG_SPICE +/* FIXME: The test is currently broken on FreeBSD */ +#if defined(CONFIG_SPICE ) && !defined(__FreeBSD__)static void test_spice_resp (QObject *res) {Visitor *v;
@@ -209,7 +209,7 @@ int main(int argc, char *argv[])qtest_add_func ("readconfig/x86/memdev" , test_x86_memdev);qtest_add_func ("readconfig/x86/ich9-ehci-uhci" , test_docs_config_ich9); } -#ifdef CONFIG_SPICE +#if defined(CONFIG_SPICE ) && !defined(__FreeBSD__)qtest_add_func ("readconfig/spice" , test_spice);#endif
Signature · 1 line
2.31.1
Quoted 11 lines · Thomas Huth
The spice test is currently hanging on FreeBSD. It likely was never working before, since in the past, our configure script was failing to detect this feature due to a bug in the spice package there (it just got enabled recently by the commit
https://cgit.freebsd.org/ports/commit/?id=cf16b1c9063351325f0 ). To get the CI working again, let's disable the failing test for now until someone has enough spare time to debug and fix the real underlying problem.Signed-off-by Thomas Huth <[email protected]>
Quoted 33 lines
--- tests/qtest/readconfig-test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)tests/qtest/readconfig-test.c +3
-4@@ -86,8 +86,8 @@ static void test_x86_memdev(void)qtest_quit (qts); } - -#ifdef CONFIG_SPICE +/* FIXME: The test is currently broken on FreeBSD */ +#if defined(CONFIG_SPICE ) && !defined(__FreeBSD__)static void test_spice_resp (QObject *res) {Visitor *v;@@ -209,7 +209,7 @@ int main(int argc, char *argv[])qtest_add_func ("readconfig/x86/memdev" , test_x86_memdev);qtest_add_func ("readconfig/x86/ich9-ehci-uhci" , test_docs_config_ich9); } -#ifdef CONFIG_SPICE +#if defined(CONFIG_SPICE ) && !defined(__FreeBSD__)qtest_add_func ("readconfig/spice" , test_spice);#endif --2.31.1
Quoted 9 lines · Thomas Huth
The spice test is currently hanging on FreeBSD. It likely was never working before, since in the past, our configure script was failing to detect this feature due to a bug in the spice package there (it just got enabled recently by the commit
https://cgit.freebsd.org/ports/commit/?id=cf16b1c9063351325f0 ). To get the CI working again, let's disable the failing test for now until someone has enough spare time to debug and fix the real underlying problem.
Quoted 4 lines
Signed-off-by Thomas Huth <[email protected]>--- tests/qtest/readconfig-test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
though could you file a gitlab bug report and link the bug report in a comment at the #ifdef the code change, and in the commit message.
Quoted 28 lines
tests/qtest/readconfig-test.c +3
-3@@ -86,8 +86,8 @@ static void test_x86_memdev(void)qtest_quit (qts); } - -#ifdef CONFIG_SPICE +/* FIXME: The test is currently broken on FreeBSD */ +#if defined(CONFIG_SPICE ) && !defined(__FreeBSD__)static void test_spice_resp (QObject *res) {Visitor *v;@@ -209,7 +209,7 @@ int main(int argc, char *argv[])qtest_add_func ("readconfig/x86/memdev" , test_x86_memdev);qtest_add_func ("readconfig/x86/ich9-ehci-uhci" , test_docs_config_ich9); } -#ifdef CONFIG_SPICE +#if defined(CONFIG_SPICE ) && !defined(__FreeBSD__)qtest_add_func ("readconfig/spice" , test_spice);#endif Signature · 1 line
2.31.1
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|