selftests/ftrace: Add tests for kprobes and optimized probes
v3 cover selftests/ftrace: Add tests for kprobes and optimized probes
This patchset adds a stress test for kprobes and a test for checking optimized probes.
The two tests are being added based on the below discussion:
https://lore.kernel.org/all/[email protected]/
kprobe_opt_types.tc is modified as per the below review comments:
https://lore.kernel.org/all/[email protected]/#t
Changelog:
v3:
* Add Acked-by for kprobe_insn_boundary.tc
* Simplify test for optimized probe, as suggested by Masami
* Add exit_unresolved to exit as unresolved in case no probe was optimized
v2:
* Add an explicit fork after enabling the events ( echo "forked" )
* Remove the extended test from multiple_kprobe_types.tc which adds multiple consecutive probes in a function and add it as a separate test case.
* Add new test case which checks for optimized probes.
Akanksha J N (2):
selftests/ftrace: Add new test case which adds multiple consecutive
probes in a function
selftests/ftrace: Add new test case which checks for optimized probes
.../test.d/kprobe/kprobe_insn_boundary.tc | 19 +++++++++++ .../ftrace/test.d/kprobe/kprobe_opt_types.tc | 34 +++++++++++++++++++ 2 files changed, 53 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_insn_boundary.tc create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_opt_types.tc
Signature · 1 line
2.31.1
PATCH v3 1/2 selftests/ftrace: Add new test case which adds multiple consecutive probes in a function
Commit 97f88a3d723162 ("powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe()") fixed a recent kernel oops that was caused as ftrace-based kprobe does not generate kprobe::ainsn::insn and it gets set to NULL.
Add new test case kprobe_insn_boundary.tc which adds a kprobe at every byte within $FUNCTION_FORK up to an offset of 256 bytes, to be able to test potential issues with kprobes on successive instructions.
The '|| continue' is added with the echo statement to ignore errors that are caused by trying to add kprobes to non probeable lines and continue with the test.
--- .../test.d/kprobe/kprobe_insn_boundary.tc | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_insn_boundary.tc
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_insn_boundary.tc new file +19 -0
@@ -0,0 +1,19 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (C) 2023 Akanksha J N, IBM corporation +# description: Register multiple kprobe events in a function +# requires: kprobe_events + +for i in `seq 0 255`; do + echo p $FUNCTION_FORK+${i} >> kprobe_events || continue +done + +cat kprobe_events >> $testlog + +echo 1 > events/kprobes/enable +( echo "forked" ) +echo 0 > events/kprobes/enable +echo > kprobe_events +echo "Waiting for unoptimizing & freeing" +sleep 5 +echo "Done"
Signature · 1 line
2.31.1
PATCH v3 2/2 selftests/ftrace: Add new test case which checks for optimized probes
In reply to Akanksha J NAdd new test case kprobe_opt_types.tc which enables and checks if each probe has been optimized in order to test potential issues with optimized probes.
The '|| continue' is added with the echo statement to ignore errors that are caused by trying to add kprobes to non probeable lines and continue with the test.
--- .../ftrace/test.d/kprobe/kprobe_opt_types.tc | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_opt_types.tc
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_opt_types.tc new file +34 -0
@@ -0,0 +1,34 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (C) 2023 Akanksha J N, IBM corporation +# description: Register/unregister optimized probe +# requires: kprobe_events + +case `uname -m` in +x86_64) +;; +arm*) +;; +ppc*) +;; +*) + echo "Please implement other architecture here" + exit_unsupported +esac + +DEFAULT=$(cat /proc/sys/debug/kprobes-optimization) +echo 1 > /proc/sys/debug/kprobes-optimization +for i in `seq 0 255`; do + echo "p:testprobe $FUNCTION_FORK+${i}" > kprobe_events || continue + echo 1 > events/kprobes/enable || continue + (echo "forked") + PROBE=$(grep $FUNCTION_FORK /sys/kernel/debug/kprobes/list) + echo 0 > events/kprobes/enable + echo > kprobe_events + if echo $PROBE | grep -q OPTIMIZED; then + echo "$DEFAULT" > /proc/sys/debug/kprobes-optimization + exit_pass + fi +done +echo "$DEFAULT" > /proc/sys/debug/kprobes-optimization +exit_unresolved
Signature · 1 line
2.31.1
Re: [PATCH v3 2/2] selftests/ftrace: Add new test case which checks for optimized probes
Quoted 8 lines · On Fri, 28 Apr 2023 22:08:42 +0530 Akanksha J N <[email protected]> wrote:
Add new test case kprobe_opt_types.tc which enables and checks if each probe has been optimized in order to test potential issues with optimized probes.
The '|| continue' is added with the echo statement to ignore errors that are caused by trying to add kprobes to non probeable lines and continue with the test.Signed-off-by Akanksha J N <[email protected]>
Thanks! This looks good to me.
Quoted 48 lines
--- .../ftrace/test.d/kprobe/kprobe_opt_types.tc | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_opt_types.tctools/testing/selftests/ftrace/test.d/kprobe/kprobe_opt_types.tc new file +34
-0@@ -0,0 +1,34 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (C) 2023 Akanksha J N, IBM corporation +# description: Register/unregister optimized probe +# requires: kprobe_events + +case `uname -m` in +x86_64) +;; +arm*) +;; +ppc*) +;; +*) + echo "Please implement other architecture here" + exit_unsupported +esac + +DEFAULT=$(cat /proc/sys/debug/kprobes-optimization) +echo 1 > /proc/sys/debug/kprobes-optimization +for i in `seq 0 255`; do + echo "p:testprobe $FUNCTION_FORK+${i}" > kprobe_events || continue + echo 1 > events/kprobes/enable || continue + (echo "forked") + PROBE=$(grep $FUNCTION_FORK /sys/kernel/debug/kprobes/list) + echo 0 > events/kprobes/enable + echo > kprobe_events + if echo $PROBE | grep -q OPTIMIZED; then + echo "$DEFAULT" > /proc/sys/debug/kprobes-optimization + exit_pass + fi +done +echo "$DEFAULT" > /proc/sys/debug/kprobes-optimization +exit_unresolvedSignature · 1 line
2.31.1
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>
Re: [PATCH v3 2/2] selftests/ftrace: Add new test case which checks for optimized probes
Quoted 10 lines · Masami Hiramatsu (Google)
Quoted 7 lines · On Fri, 28 Apr 2023 22:08:42 +0530 Akanksha J N <[email protected]> wrote:
Add new test case kprobe_opt_types.tc which enables and checks if each probe has been optimized in order to test potential issues with optimized probes.
The '|| continue' is added with the echo statement to ignore errors that are caused by trying to add kprobes to non probeable lines and continue with the test.
Quoted 6 lines
Quoted 1 line
Signed-off-by Akanksha J N <[email protected]>Thanks! This looks good to me.
Would you like this patch to go through kselftest tree? If not here is my Ack:
thanks,
-- Shuah
Re: [PATCH v3 2/2] selftests/ftrace: Add new test case which checks for optimized probes
Quoted 4 lines · On Mon, 8 May 2023 11:36:28 -0600 Shuah Khan <[email protected]> wrote:
Quoted 2 lines
Would you like this patch to go through kselftest tree?
Shuah, you can take it through your kselftest tree.
Thanks!
-- Steve
Shuah Khan
maintainerRe: [PATCH v3 2/2] selftests/ftrace: Add new test case which checks for optimized probes
Quoted 6 lines · Steven Rostedt
Quoted 3 lines · On Mon, 8 May 2023 11:36:28 -0600 Shuah Khan <[email protected]> wrote:
Quoted 2 lines
Quoted 8 lines
Quoted 1 line
Would you like this patch to go through kselftest tree?
Shuah, you can take it through your kselftest tree.
Thanks!
Applied to linux-kselftest next for 6.5-rc1
thanks,
-- Shuah
Masami Hiramatsu (Google)
maintainerRe: [PATCH v3 2/2] selftests/ftrace: Add new test case which checks for optimized probes
Quoted 9 lines · On Wed, 17 May 2023 10:26:43 -0600 Shuah Khan <[email protected]> wrote:
Quoted 8 lines · Steven Rostedt
Quoted 4 lines · On Mon, 8 May 2023 11:36:28 -0600 Shuah Khan <[email protected]> wrote:
Quoted 2 lines
Would you like this patch to go through kselftest tree?
Quoted 8 lines
Quoted 6 lines
Shuah, you can take it through your kselftest tree.
Thanks!
Applied to linux-kselftest next for 6.5-rc1
Thank you Shuah!
Quoted 4 lines
thanks,
-- Shuah
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>