ext4: Optimize memory usage in xattr
PATCH 1/1 ext4: Optimize memory usage in xattr
Currently struct ext4_attr_info->in_inode use int, but the value is only 0 or 1, so replace int with bool.
Signed-off-by JunChao Sun <[email protected]>
--- fs/ext4/xattr.c | 8 ++++---- fs/ext4/xattr.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)
fs/ext4/xattr.c +4 -4
@@ -1639,7 +1639,7 @@ static int ext4_xattr_set_entry(struct ext4_xattr_info *i,struct ext4_xattr_entry *last, *next;struct ext4_xattr_entry *here = s->here;size_t min_offs = s->end - s->base, name_len =strlen (i->name); -int in_inode = i->in_inode; +bool in_inode = i->in_inode;struct inode *old_ea_inode =NULL ;struct inode *new_ea_inode =NULL ;size_t old_size, new_size;
@@ -2354,7 +2354,7 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode) .name = name, .value = value, .value_len = value_len, - .in_inode = 0, + .in_inode = false, };struct ext4_xattr_ibody_find is = { .s = { .not_found = -ENODATA , },
@@ -2441,7 +2441,7 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode)if (ext4_has_feature_ea_inode (inode->i_sb) && (EXT4_XATTR_SIZE (i.value_len) >EXT4_XATTR_MIN_LARGE_EA_SIZE (inode->i_sb->s_blocksize))) - i.in_inode =1 ; + i.in_inode = true; retry_inode: error =ext4_xattr_ibody_set (handle, inode, &i, &is);if (!error && !bs.s.not_found) {
@@ -2467,7 +2467,7 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode)*/ if (ext4_has_feature_ea_inode (inode->i_sb) && i.value_len && !i.in_inode) { - i.in_inode =1 ; + i.in_inode = true; goto retry_inode; } }
fs/ext4/xattr.h +1 -1
@@ -113,7 +113,7 @@ struct ext4_xattr_info {const void *value;size_t value_len;int name_index; -int in_inode; +bool in_inode; };struct ext4_xattr_search {
Signature · 1 line
1.8.3.1
Quoted 4 lines · JunChao Sun
Currently struct
ext4_attr_info->in_inodeuse int, but the value is only 0 or 1, so replace int with bool.Signed-off-by JunChao Sun <[email protected]>
Looks fine. Feel free to add:
Reviewed-by Jan Kara <[email protected]>
Honza
Quoted 61 lines
--- fs/ext4/xattr.c | 8 ++++---- fs/ext4/xattr.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)fs/ext4/xattr.c +4
-4@@ -1639,7 +1639,7 @@ static int ext4_xattr_set_entry(struct ext4_xattr_info *i,struct ext4_xattr_entry *last, *next;struct ext4_xattr_entry *here = s->here;size_t min_offs = s->end - s->base, name_len =strlen (i->name); -int in_inode = i->in_inode; +bool in_inode = i->in_inode;struct inode *old_ea_inode =NULL ;struct inode *new_ea_inode =NULL ;size_t old_size, new_size;@@ -2354,7 +2354,7 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode) .name = name, .value = value, .value_len = value_len, - .in_inode = 0, + .in_inode = false, };struct ext4_xattr_ibody_find is = { .s = { .not_found = -ENODATA , },@@ -2441,7 +2441,7 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode)if (ext4_has_feature_ea_inode (inode->i_sb) && (EXT4_XATTR_SIZE (i.value_len) >EXT4_XATTR_MIN_LARGE_EA_SIZE (inode->i_sb->s_blocksize))) - i.in_inode =1 ; + i.in_inode = true; retry_inode: error =ext4_xattr_ibody_set (handle, inode, &i, &is);if (!error && !bs.s.not_found) {@@ -2467,7 +2467,7 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode)*/ if (ext4_has_feature_ea_inode (inode->i_sb) && i.value_len && !i.in_inode) { - i.in_inode =1 ; + i.in_inode = true; goto retry_inode; } }fs/ext4/xattr.h +1
-1@@ -113,7 +113,7 @@ struct ext4_xattr_info {const void *value;size_t value_len;int name_index; -int in_inode; +bool in_inode; };struct ext4_xattr_search {Signature · 1 line
1.8.3.1
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Friendly ping...
Quoted 77 lines · Jan Kara <[email protected]> 于2023年5月2日周二 17:41写道:
Quoted 4 lines · JunChao Sun
Currently struct
ext4_attr_info->in_inodeuse int, but the value is only 0 or 1, so replace int with bool.Signed-off-by JunChao Sun <[email protected]>Looks fine. Feel free to add:
Reviewed-by Jan Kara <[email protected]>Honza
Quoted 59 lines
--- fs/ext4/xattr.c | 8 ++++---- fs/ext4/xattr.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)fs/ext4/xattr.c +4
-4@@ -1639,7 +1639,7 @@ static int ext4_xattr_set_entry(struct ext4_xattr_info *i,struct ext4_xattr_entry *last, *next;struct ext4_xattr_entry *here = s->here;size_t min_offs = s->end - s->base, name_len =strlen (i->name); -int in_inode = i->in_inode; +bool in_inode = i->in_inode;struct inode *old_ea_inode =NULL ;struct inode *new_ea_inode =NULL ;size_t old_size, new_size;@@ -2354,7 +2354,7 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode) .name = name, .value = value, .value_len = value_len, - .in_inode = 0, + .in_inode = false, };struct ext4_xattr_ibody_find is = { .s = { .not_found = -ENODATA , },@@ -2441,7 +2441,7 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode)if (ext4_has_feature_ea_inode (inode->i_sb) && (EXT4_XATTR_SIZE (i.value_len) >EXT4_XATTR_MIN_LARGE_EA_SIZE (inode->i_sb->s_blocksize))) - i.in_inode =1 ; + i.in_inode = true; retry_inode: error =ext4_xattr_ibody_set (handle, inode, &i, &is);if (!error && !bs.s.not_found) {@@ -2467,7 +2467,7 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode)*/ if (ext4_has_feature_ea_inode (inode->i_sb) && i.value_len && !i.in_inode) { - i.in_inode =1 ; + i.in_inode = true; goto retry_inode; } }fs/ext4/xattr.h +1
-2@@ -113,7 +113,7 @@ struct ext4_xattr_info {const void *value;size_t value_len;int name_index; -int in_inode; +bool in_inode; };struct ext4_xattr_search { --Quoted 2 lines
1.8.3.1
--
Jan Kara <[email protected]>
SUSE Labs, CR