Skip to contentSkip to conversation

pinctrl:sprd: Check if the pinctrl_dev still exists

PATCH In review Lizhe 2 participants 2 messages Apr 30, 2023

Subsystems (3)
lore
Share & tools
lore

Lizhe

author
#0 lore raw

PATCH 1/1 pinctrl:sprd: Check if the pinctrl_dev still exists

to check if the pinctrl_dev still exists before calling pinctrl_unregister().

---
 drivers/pinctrl/sprd/pinctrl-sprd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pinctrl/sprd/pinctrl-sprd.c +3 -1
index ca9659f4e4b1..52089e34435c 100644
@@ -1114,8 +1114,10 @@ EXPORT_SYMBOL_GPL(sprd_pinctrl_core_probe);
 int sprd_pinctrl_remove(struct platform_device *pdev)
 {
 	struct sprd_pinctrl *sprd_pctl = platform_get_drvdata(pdev);
+	
+	if (sprd_pctl->pctl)
+		pinctrl_unregister(sprd_pctl->pctl);
 
-	pinctrl_unregister(sprd_pctl->pctl);
 	return 0;
 }
 EXPORT_SYMBOL_GPL(sprd_pinctrl_remove);
Signature · 1 line
2.34.1
#1 lore raw

Sun, Apr 30, 2023 at 10:01:29PM +0800, Lizhe kirjoitti:

Quoted 2 lines

to check if the pinctrl_dev still exists before calling pinctrl_unregister().

Sending a duplicate won't give anything new here, the patch itself is bogus.

Signature · 2 lines
With Best Regards,
Andy Shevchenko