Skip to contentSkip to conversation

together: Minor fixups

PATCH In review SeongJae Park 4 participants 9 messages Apr 29, 2023 – Apr 30, 2023

lore
Share & tools
lore
#0 lore raw

cover together: Minor fixups

From: SeongJae Park <[email protected]>

This patchset contains minor fixups for together/, which found while doing Korean translation[1].

[1] https://github.com/sjp38/perfbook-ko_KR

SeongJae Park (2):
together/refcnt: Use \tco{} for code quoting together/seqlock: Use term 'sequence lock' consistently

 together/refcnt.tex  | 8 ++++----
 together/seqlock.tex | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 together/refcnt: Use \tco{} for code quoting

From: SeongJae Park <[email protected]>

Some sentences in refcnt.tex is using only quote for some code words. Use \tco{} instead, as it is intended to be used for the case.

---
 together/refcnt.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
together/refcnt.tex +4 -4
index 56caed67..4abe1c60 100644
@@ -467,15 +467,15 @@ as shown below.
 
 \QuickQuiz{
 	Why can't the check for a zero reference count be
-	made in a simple ``if'' statement with an atomic
-	increment in its ``then'' clause?
+	made in a simple \tco{if} statement with an atomic
+	increment in its \tco{then} clause?
 }\QuickQuizAnswer{
-	Suppose that the ``if'' condition completed, finding
+	Suppose that the \tco{if} condition completed, finding
 	the reference counter value equal to one.
 	Suppose that a release operation executes, decrementing
 	the reference counter to zero and therefore starting
 	cleanup operations.
-	But now the ``then'' clause can increment the counter
+	But now the \tco{then} clause can increment the counter
 	back to a value of one, allowing the object to be
 	used after it has been cleaned up.
 
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting

Hi,

Quoted 4 lines · SeongJae Park

From: SeongJae Park <[email protected]>

Some sentences in refcnt.tex is using only quote for some code words. Use \tco{} instead, as it is intended to be used for the case.

\tco{} doesn't put quotes around it.
Didn't you mean \qco{} ?

Thanks, Akira

Quoted 30 lines
---
 together/refcnt.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
together/refcnt.tex +4 -4
index 56caed67..4abe1c60 100644
@@ -467,15 +467,15 @@ as shown below.
 
 \QuickQuiz{
 	Why can't the check for a zero reference count be
-	made in a simple ``if'' statement with an atomic
-	increment in its ``then'' clause?
+	made in a simple \tco{if} statement with an atomic
+	increment in its \tco{then} clause?
 }\QuickQuizAnswer{
-	Suppose that the ``if'' condition completed, finding
+	Suppose that the \tco{if} condition completed, finding
 	the reference counter value equal to one.
 	Suppose that a release operation executes, decrementing
 	the reference counter to zero and therefore starting
 	cleanup operations.
-	But now the ``then'' clause can increment the counter
+	But now the \tco{then} clause can increment the counter
 	back to a value of one, allowing the object to be
 	used after it has been cleaned up.
 
#3 lore raw

Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting

Hi Akira,

Quoted 10 lines · On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <[email protected]> wrote:

Hi,

Quoted 4 lines · SeongJae Park

From: SeongJae Park <[email protected]>

Some sentences in refcnt.tex is using only quote for some code words. Use \tco{} instead, as it is intended to be used for the case.

\tco{} doesn't put quotes around it.
Didn't you mean \qco{} ?

You're correct, I was out of my mind. I also mistakenly used an email account that different from what I signed patches off. I will send a new spin tomorrow.

Thanks,
SJ

Quoted 33 lines

Thanks, Akira

Quoted 30 lines
---
 together/refcnt.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
together/refcnt.tex +4 -4
index 56caed67..4abe1c60 100644
@@ -467,15 +467,15 @@ as shown below.
 
 \QuickQuiz{
 	Why can't the check for a zero reference count be
-	made in a simple ``if'' statement with an atomic
-	increment in its ``then'' clause?
+	made in a simple \tco{if} statement with an atomic
+	increment in its \tco{then} clause?
 }\QuickQuizAnswer{
-	Suppose that the ``if'' condition completed, finding
+	Suppose that the \tco{if} condition completed, finding
 	the reference counter value equal to one.
 	Suppose that a release operation executes, decrementing
 	the reference counter to zero and therefore starting
 	cleanup operations.
-	But now the ``then'' clause can increment the counter
+	But now the \tco{then} clause can increment the counter
 	back to a value of one, allowing the object to be
 	used after it has been cleaned up.
 
#4 lore raw

Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting

Quoted 12 lines · SeongJae Park

Hi Akira,

Quoted 8 lines · On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <[email protected]> wrote:

Hi,

Quoted 4 lines · SeongJae Park

From: SeongJae Park <[email protected]>

Some sentences in refcnt.tex is using only quote for some code words. Use \tco{} instead, as it is intended to be used for the case.

Quoted 6 lines
Quoted 2 lines

\tco{} doesn't put quotes around it.
Didn't you mean \qco{} ?

You're correct, I was out of my mind. I also mistakenly used an email account that different from what I signed patches off. I will send a new spin tomorrow.

Looks like Paul has already pulled and pushed this (commit 0e96cb8283ca).

Can you send a fix on top ?

Thanks, Akira

Quoted 38 lines

Thanks,
SJ

Quoted 33 lines

Thanks, Akira

Quoted 30 lines
---
 together/refcnt.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
together/refcnt.tex +4 -4
index 56caed67..4abe1c60 100644
@@ -467,15 +467,15 @@ as shown below.
 
 \QuickQuiz{
 	Why can't the check for a zero reference count be
-	made in a simple ``if'' statement with an atomic
-	increment in its ``then'' clause?
+	made in a simple \tco{if} statement with an atomic
+	increment in its \tco{then} clause?
 }\QuickQuizAnswer{
-	Suppose that the ``if'' condition completed, finding
+	Suppose that the \tco{if} condition completed, finding
 	the reference counter value equal to one.
 	Suppose that a release operation executes, decrementing
 	the reference counter to zero and therefore starting
 	cleanup operations.
-	But now the ``then'' clause can increment the counter
+	But now the \tco{then} clause can increment the counter
 	back to a value of one, allowing the object to be
 	used after it has been cleaned up.
 
#5 lore raw

Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting

Quoted 16 lines · Akira Yokosawa
Quoted 15 lines · SeongJae Park

Hi Akira,

Quoted 10 lines · On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <[email protected]> wrote:

Hi,

Quoted 4 lines · SeongJae Park

From: SeongJae Park <[email protected]>

Some sentences in refcnt.tex is using only quote for some code words. Use \tco{} instead, as it is intended to be used for the case.

\tco{} doesn't put quotes around it.
Didn't you mean \qco{} ?

Quoted 7 lines
Quoted 3 lines

You're correct, I was out of my mind. I also mistakenly used an email account that different from what I signed patches off. I will send a new spin tomorrow.

Looks like Paul has already pulled and pushed this (commit 0e96cb8283ca).

Can you send a fix on top ?

Or I can remove that commit if that makes things easier. When you send me the patch, please just let me know if it is to replace 0e96cb8283ca or to go on top of it. Your choice! ;-)

And thank you, Akira, for checking.

Thanx, Paul

Quoted 40 lines

Thanks, Akira

Quoted 38 lines

Thanks,
SJ

Quoted 33 lines

Thanks, Akira

Quoted 30 lines
---
 together/refcnt.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
together/refcnt.tex +4 -4
index 56caed67..4abe1c60 100644
@@ -467,15 +467,15 @@ as shown below.
 
 \QuickQuiz{
 	Why can't the check for a zero reference count be
-	made in a simple ``if'' statement with an atomic
-	increment in its ``then'' clause?
+	made in a simple \tco{if} statement with an atomic
+	increment in its \tco{then} clause?
 }\QuickQuizAnswer{
-	Suppose that the ``if'' condition completed, finding
+	Suppose that the \tco{if} condition completed, finding
 	the reference counter value equal to one.
 	Suppose that a release operation executes, decrementing
 	the reference counter to zero and therefore starting
 	cleanup operations.
-	But now the ``then'' clause can increment the counter
+	But now the \tco{then} clause can increment the counter
 	back to a value of one, allowing the object to be
 	used after it has been cleaned up.
 
#6 lore raw

Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting

Hi Akira and Paul,

Quoted 21 lines · On Sat, 29 Apr 2023 20:17:25 -0700 "Paul E. McKenney" <[email protected]>…
Quoted 20 lines · Akira Yokosawa
Quoted 18 lines · SeongJae Park

Hi Akira,

Quoted 10 lines · On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <[email protected]> wrote:

Hi,

Quoted 4 lines · SeongJae Park

From: SeongJae Park <[email protected]>

Some sentences in refcnt.tex is using only quote for some code words. Use \tco{} instead, as it is intended to be used for the case.

\tco{} doesn't put quotes around it.
Didn't you mean \qco{} ?

You're correct, I was out of my mind. I also mistakenly used an email account that different from what I signed patches off. I will send a new spin tomorrow.

Quoted 7 lines
Quoted 3 lines

Looks like Paul has already pulled and pushed this (commit 0e96cb8283ca).

Can you send a fix on top ?

Or I can remove that commit if that makes things easier. When you send me the patch, please just let me know if it is to replace 0e96cb8283ca or to go on top of it. Your choice! ;-)

Sorry, I found this mail after I sent the patch. Just for a record. I sent the patch on top of it. If you'd prefer to, please feel free to squash it into the old one. I have no preference but just want to make the trivial nit fixed.

Quoted 2 lines

And thank you, Akira, for checking.

Thank you all.

Thanks,
SJ

Quoted 43 lines

Thanx, Paul

Quoted 40 lines

Thanks, Akira

Quoted 38 lines

Thanks,
SJ

Quoted 33 lines

Thanks, Akira

Quoted 30 lines
---
 together/refcnt.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
together/refcnt.tex +4 -4
index 56caed67..4abe1c60 100644
@@ -467,15 +467,15 @@ as shown below.
 
 \QuickQuiz{
 	Why can't the check for a zero reference count be
-	made in a simple ``if'' statement with an atomic
-	increment in its ``then'' clause?
+	made in a simple \tco{if} statement with an atomic
+	increment in its \tco{then} clause?
 }\QuickQuizAnswer{
-	Suppose that the ``if'' condition completed, finding
+	Suppose that the \tco{if} condition completed, finding
 	the reference counter value equal to one.
 	Suppose that a release operation executes, decrementing
 	the reference counter to zero and therefore starting
 	cleanup operations.
-	But now the ``then'' clause can increment the counter
+	But now the \tco{then} clause can increment the counter
 	back to a value of one, allowing the object to be
 	used after it has been cleaned up.
 
#7 lore raw

Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting

Quoted 29 lines · SeongJae Park

Hi Akira and Paul,

Quoted 25 lines · On Sat, 29 Apr 2023 20:17:25 -0700 "Paul E. McKenney" <[email protected]>…
Quoted 23 lines · Akira Yokosawa
Quoted 12 lines · SeongJae Park

Hi Akira,

Quoted 8 lines · On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <[email protected]> wrote:

Hi,

Quoted 4 lines · SeongJae Park

From: SeongJae Park <[email protected]>

Some sentences in refcnt.tex is using only quote for some code words. Use \tco{} instead, as it is intended to be used for the case.

Quoted 6 lines
Quoted 2 lines

\tco{} doesn't put quotes around it.
Didn't you mean \qco{} ?

You're correct, I was out of my mind. I also mistakenly used an email account that different from what I signed patches off. I will send a new spin tomorrow.

Looks like Paul has already pulled and pushed this (commit 0e96cb8283ca).

Can you send a fix on top ?

Quoted 7 lines
Quoted 3 lines

Or I can remove that commit if that makes things easier. When you send me the patch, please just let me know if it is to replace 0e96cb8283ca or to go on top of it. Your choice! ;-)

Sorry, I found this mail after I sent the patch. Just for a record. I sent the patch on top of it. If you'd prefer to, please feel free to squash it into the old one. I have no preference but just want to make the trivial nit fixed.

And fixed it is! ;-)

Thanx, Paul

Quoted 51 lines
Quoted 1 line

And thank you, Akira, for checking.

Thank you all.

Thanks,
SJ

Quoted 43 lines

Thanx, Paul

Quoted 40 lines

Thanks, Akira

Quoted 38 lines

Thanks,
SJ

Quoted 33 lines

Thanks, Akira

Quoted 30 lines
---
 together/refcnt.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
together/refcnt.tex +4 -4
index 56caed67..4abe1c60 100644
@@ -467,15 +467,15 @@ as shown below.
 
 \QuickQuiz{
 	Why can't the check for a zero reference count be
-	made in a simple ``if'' statement with an atomic
-	increment in its ``then'' clause?
+	made in a simple \tco{if} statement with an atomic
+	increment in its \tco{then} clause?
 }\QuickQuizAnswer{
-	Suppose that the ``if'' condition completed, finding
+	Suppose that the \tco{if} condition completed, finding
 	the reference counter value equal to one.
 	Suppose that a release operation executes, decrementing
 	the reference counter to zero and therefore starting
 	cleanup operations.
-	But now the ``then'' clause can increment the counter
+	But now the \tco{then} clause can increment the counter
 	back to a value of one, allowing the object to be
 	used after it has been cleaned up.
 
#8 lore raw

PATCH 2/2 together/seqlock: Use term 'sequence lock' consistently

In reply to SeongJae Park

From: SeongJae Park <[email protected]>

A sentence in seqlock.tex is calling sequence locks as sequence counters, while all other sentences in the file is calling those sequence locks. Use the term consistently.

---
 together/seqlock.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
together/seqlock.tex +1 -1
index 5fd31d83..b77b5184 100644
@@ -8,7 +8,7 @@
 \epigraph{The girl who can't dance says the band can't play.}
 	 {Yiddish proverb}
 
-This section looks at some special uses of sequence counters.
+This section looks at some special uses of sequence locks.
 
 \subsection{Dueling Sequence Locks}
 \label{sec:together:Dueling Sequence Locks}
Signature · 1 line
2.17.1