fs: fix incorrect fmode_t casts
Subsystems (2)
PATCH 1/1 fs: fix incorrect fmode_t casts
Use __FMODE_NONOTIFY instead of FMODE_NONOTIFY to fixes
the following sparce warnings:fs/overlayfs/file.c:48:37: sparse: warning: restricted fmode_t degrades to integer fs/overlayfs/file.c:128:13: sparse: warning: restricted fmode_t degrades to integer fs/open.c:1159:21: sparse: warning: restricted fmode_t degrades to integer
--- fs/open.c | 2 +- fs/overlayfs/file.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
fs/open.c +1 -1
@@ -1156,7 +1156,7 @@ inline struct open_how build_open_how(int flags, umode_t mode)inline int build_open_flags (const struct open_how *how,struct open_flags *op) {u64 flags = how->flags; -u64 strip =FMODE_NONOTIFY |O_CLOEXEC ; +u64 strip = __FMODE_NONOTIFY |O_CLOEXEC ;int lookup_flags =0 ;int acc_mode =ACC_MODE (flags);
fs/overlayfs/file.c +1 -1
@@ -35,7 +35,7 @@ static char ovl_whatisit(struct inode *inode, struct inode *realinode) }/* No atime modification nor notify on underlying */ -#define OVL_OPEN_FLAGS (O_NOATIME | FMODE_NONOTIFY) +#define OVL_OPEN_FLAGS (O_NOATIME | __FMODE_NONOTIFY)static struct file *ovl_open_realfile (const struct file *file,const struct path *realpath)
Signature · 1 line
2.34.1
Quoted 8 lines · Min-Hua Chen
Use
__FMODE_NONOTIFYinstead ofFMODE_NONOTIFYto fixes
the following sparce warnings:fs/overlayfs/file.c:48:37: sparse: warning: restrictedfmode_tdegrades to integerfs/overlayfs/file.c:128:13: sparse: warning: restrictedfmode_tdegrades to integerfs/open.c:1159:21: sparse: warning: restrictedfmode_tdegrades to integer[...]
Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc
[1/1] fs: fix incorrect fmode_t casts
https://git.kernel.org/vfs/vfs/c/079ad16ded46