usb: dwc3: Add error logs for unknown endpoint events
Subsystems (2)
PATCH v2 1/1 usb: dwc3: Add error logs for unknown endpoint events
In cases where the controller somehow fails to write to event buffer memory (e.g. due to incorrect MMU config), the driver would receive all-zero dwc3 events. However, the abnormal event is silently dropped as a regular ep0out event.
Add error logs when an unknown endpoint event is received to highlight the anomaly.
--- drivers/usb/dwc3/ep0.c | 3 +++ drivers/usb/dwc3/gadget.c | 3 +++ 2 files changed, 6 insertions(+)
drivers/usb/dwc3/ep0.c +3 -0
@@ -1207,5 +1207,8 @@ void dwc3_ep0_interrupt(struct dwc3 *dwc, dep->flags &= ~DWC3_EP_TRANSFER_STARTED ; }break ; +default : +dev_err (dwc->dev,"unknown endpoint event %d\n" , event->endpoint_event); +break ; } }
drivers/usb/dwc3/gadget.c +3 -0
@@ -3803,6 +3803,9 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,break ;case DWC3_DEPEVT_RXTXFIFOEVT :break ; +default : +dev_err (dwc->dev,"unknown endpoint event %d\n" , event->endpoint_event); +break ; } }
base-commit: c8c655c34e33544aec9d64b660872ab33c29b5f1
Signature · 1 line
2.40.1.495.gc816e09b53d-goog
Quoted 41 lines · Roy Luo
In cases where the controller somehow fails to write to event buffer memory (e.g. due to incorrect MMU config), the driver would receive all-zero dwc3 events. However, the abnormal event is silently dropped as a regular ep0out event.
Add error logs when an unknown endpoint event is received to highlight the anomaly.Signed-off-by Roy Luo <[email protected]>--- drivers/usb/dwc3/ep0.c | 3 +++ drivers/usb/dwc3/gadget.c | 3 +++ 2 files changed, 6 insertions(+)drivers/usb/dwc3/ep0.c +3
-0@@ -1207,5 +1207,8 @@ void dwc3_ep0_interrupt(struct dwc3 *dwc, dep->flags &= ~DWC3_EP_TRANSFER_STARTED ; }break ; +default : +dev_err (dwc->dev,"unknown endpoint event %d\n" , event->endpoint_event); +break ; } }drivers/usb/dwc3/gadget.c +3
-0@@ -3803,6 +3803,9 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc,break ;case DWC3_DEPEVT_RXTXFIFOEVT :break ; +default : +dev_err (dwc->dev,"unknown endpoint event %d\n" , event->endpoint_event); +break ; } }
Quoted 4 lines
base-commit:
c8c655c34e33544aec9d64b660872ab33c29b5f1Signature · 1 line
2.40.1.495.gc816e09b53d-goog
Thanks,
Thinh