LTP release preparations
Hi!
I would like to start with LTP pre-release preparations a bit sooner than usuall, since quite a lot of things have accumulated in May, e.g. there is a SUSE Labs conference right in the middle of the month.
I would like to start with reviewe of patches that should go in now, freeze the git somewhere at the end of the first week of May and aim for a release somewhere in the middle of the month. Does that sound Ok to everyone?
Either way if you have patches that should land in the upcomming release, please point them out now, so that we have a chance to review them.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 10 lines · Cyril Hrubis
Hi!
I would like to start with LTP pre-release preparations a bit sooner than usuall, since quite a lot of things have accumulated in May, e.g. there is a SUSE Labs conference right in the middle of the month.I would like to start with reviewe of patches that should go in now, freeze the git somewhere at the end of the first week of May and aim for a release somewhere in the middle of the month. Does that sound Ok to everyone?
Basically agree, but it'd be better if we extend one more week in May. Since the first week is China's public holiday, I don't wanna miss the release this time again.
Quoted 5 lines
Either way if you have patches that should land in the upcomming release, please point them out now, so that we have a chance to review them.
I'll be working on the hugemmap24 failure you pointed out before, to send an effective fixing patch.
https://lists.linux.it/pipermail/ltp/2023-March/033117.html
Also, I'd vote for the cgroup_core03.c test, which basically gets passed on my review and testing.
I will additionally start a separate patch on new improvements based on Wei's patchset to let LTP Cgroup test avoid V1nV2 mixing test.
https://lists.linux.it/pipermail/ltp/2023-April/033604.html
https://lists.linux.it/pipermail/ltp/2023-April/033605.html
More widely LTP LTP pre-release will be deployed base on RHEL products as well.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 15 lines · Li Wang
Quoted 10 lines · Cyril Hrubis
Hi!
I would like to start with LTP pre-release preparations a bit sooner than usuall, since quite a lot of things have accumulated in May, e.g. there is a SUSE Labs conference right in the middle of the month.I would like to start with reviewe of patches that should go in now, freeze the git somewhere at the end of the first week of May and aim for a release somewhere in the middle of the month. Does that sound Ok to everyone?
Quoted 4 lines
Basically agree, but it'd be better if we extend one more week in May. Since the first week is China's public holiday, I don't wanna miss the release this time again.
Ah, your plan should be well, I just check my calendar, the holiday is only three days in May (1-3). That wouldn't impact a lot, sorry.
Quoted 20 lines
Quoted 8 lines
Either way if you have patches that should land in the upcomming release, please point them out now, so that we have a chance to review them.
I'll be working on the hugemmap24 failure you pointed out before, to send an effective fixing patch.
https://lists.linux.it/pipermail/ltp/2023-March/033117.htmlAlso, I'd vote for the
cgroup_core03.ctest, which basically gets passed on my review and testing.
I will additionally start a separate patch on new improvements based on Wei's patchset to let LTP Cgroup test avoid V1nV2 mixing test.
https://lists.linux.it/pipermail/ltp/2023-April/033604.html
https://lists.linux.it/pipermail/ltp/2023-April/033605.html
Quoted 3 lines
More widely LTP LTP pre-release will be deployed base on RHEL products as well.
===> LTP pre-release test.
sorry for the typos.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi All,
Quoted 3 lines · Li Wang
More widely LTP pre-release test will be deployed base on RHEL products as well.
I have completed the LTP pre-release test against RHEL 8 and 9, all looks good except one test warning as below, but I suppose it's a tiny problem caused by the ppc64le configuration.
This only observed on ppc64le arch:
3 cmdline="hugemmap32"
4 contacts=""
5 analysis=exit
6 <<<test_output>>>
7 tst_test.c:1558: TINFO: Timeout per run is 0h 01m 00s
8 hugemmap32.c:34: TWARN: Failed to close FILE'/sys/kernel/mm/hugepages/hugepages-16777216kB/nr_hugepages'
9 hugemmap32.c:35: TCONF: Can't update the gigantic hugepages.
10 hugemmap32.c:69: TWARN: Failed to close FILE '/sys/kernel/mm/hugepages/hugepages-16777216kB/nr_hugepages': EINVAL (22)
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 17 lines
Quoted 3 lines
More widely LTP pre-release test will be deployed base on RHEL products as well.
I have completed the LTP pre-release test against RHEL 8 and 9, all looks good except one test warning as below, but I suppose it's a tiny problem caused by the ppc64le configuration.
This only observed on ppc64le arch:
3 cmdline="hugemmap32"
4 contacts="" 5 analysis=exit 6 <<<test_output>>> 7 tst_test.c:1558: TINFO: Timeout per run is 0h 01m 00s 8 hugemmap32.c:34: TWARN: Failed to close FILE
Quoted 5 lines
'
/sys/kernel/mm/hugepages/hugepages-16777216kB/nr_hugepages'
9 hugemmap32.c:35: TCONF: Can't update the gigantic hugepages.10 hugemmap32.c:69: TWARN: Failed to close FILE '
/sys/kernel/mm/hugepages/hugepages-16777216kB/nr_hugepages': EINVAL (22)
Looking at the file_printf() the test uses it does produce a warning when we fail to write to the file.
Also we seems to be using FILE_PRINTF() exactly in these tests:
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c testcases/kernel/mem/hugetlb/hugemmap/hugemmap32.c testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.c testcases/kernel/syscalls/fcntl/fcntl33.c testcases/kernel/syscalls/readahead/readahead02.c
In three cases we use the FILE_PRINTF() in the test cleanup, which does not matter, since we do not break test on TBROK when we run in the test cleanup.
That leaves us just hugemmap32 and readahead02 in both cases I think that generating TWARN in just plain wrong.
So what about:
* changing FILE_PRINTF() to SAFE_FILE_PRINTF() in test cleanup
* changing TWARN to TINFO in FILE_PRINTF()
I guess that we should have been using TINFO in the file_fprintf() from the start.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril,
Quoted 43 lines · Cyril Hrubis
Hi!
Quoted 12 lines
Quoted 3 lines
More widely LTP pre-release test will be deployed base on RHEL products as well.
I have completed the LTP pre-release test against RHEL 8 and 9, all looks good except one test warning as below, but I suppose it's a tiny problem caused by the ppc64le configuration.
This only observed on ppc64le arch:
3 cmdline="hugemmap32"
Quoted 7 lines
4 contacts="" 5 analysis=exit 6 <<<test_output>>> 7 tst_test.c:1558: TINFO: Timeout per run is 0h 01m 00s 8 hugemmap32.c:34: TWARN: Failed to close FILE'
/sys/kernel/mm/hugepages/hugepages-16777216kB/nr_hugepages'
9 hugemmap32.c:35: TCONF: Can't update the gigantichugepages.
Quoted 3 lines
10 hugemmap32.c:69: TWARN: Failed to close FILE '
/sys/kernel/mm/hugepages/hugepages-16777216kB/nr_hugepages': EINVAL (22)Looking at the
file_printf()the test uses it does produce a warning when we fail to write to the file.Also we seems to be using
FILE_PRINTF()exactly in these tests:
testcases/kernel/device-drivers/cpufreq/cpufreq_boost.ctestcases/kernel/mem/hugetlb/hugemmap/hugemmap32.ctestcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.ctestcases/kernel/syscalls/fcntl/fcntl33.ctestcases/kernel/syscalls/readahead/readahead02.cIn three cases we use the
FILE_PRINTF()in the test cleanup, which does not matter, since we do not break test on TBROK when we run in the test cleanup.That leaves us just hugemmap32 and readahead02 in both cases I think that generating TWARN in just plain wrong.
Quoted 8 lines
So what about:
* changing
FILE_PRINTF()toSAFE_FILE_PRINTF()in test cleanup
* changing TWARN to TINFO inFILE_PRINTF()I guess that we should have been using TINFO in the
file_fprintf()from the start.
Yes, sure. I think this will be better for the FILE_PRINTF macro use. Should we change that in a separate patch after the release?
But, I suppose that we still need to check the available memory in hugemmap32, because that might be the reason, is unable to write to the '.../nr_hugepages' file even with zero.
# cat /sys/kernel/mm/hugepages/hugepages-16777216kB/nr_hugepages 0
# echo 0 >/sys/kernel/mm/hugepages/hugepages-16777216kB/nr_hugepages -bash: echo: write error: Invalid argument
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril, Li, others,
I see we're still discussing hugemmap test issues with FILE_PRINTF(). Do we want to solve these before release?
Because if we want to release on Friday, we should start writing release notes and announcement. We're on a LABS conference next week. But not sure if it's a good idea to postpone (Cyril is and will be even more busy, I'll be away for few weeks before the end of the month).
From the list we agreed previously [1]:
- announcement email,
- collecting patch lists for a new release,
- writing release notes, or paperwork,
- new release commit and tag and create release in github from it (not in [1], but obvious)
- uploading tarballs
- pre-testing against different Linux distribution
I'll can do, what I did previously:
- new release commit and tag and create release in github from it
- uploading tarballs
- release notes for shell API (mostly network shell API)
It'd be big help if Cyril managed to do release notes and the announcement.
Kind regards,
Petr
[1] https://lore.kernel.org/ltp/CAEemH2eSJQ-_30_Y3A567oqBFSOo=1tt7LJMtPq_BodjVNsm8w@mail.gmail.com/
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 5 lines · Petr Vorel
Hi Cyril, Li, others,
I see we're still discussing hugemmap test issues with
FILE_PRINTF(). Do we want to solve these before release?
I have merged the quick fix with Cryil's ack. So FILE_PRINTF() improvement work can be delayed after release.
Quoted 9 lines
Because if we want to release on Friday, we should start writing release notes
and announcement. We're on a LABS conference next week. But not sure if it's a
good idea to postpone (Cyril is and will be even more busy, I'll be away for few
weeks before the end of the month).
IMO, it's OK to release on Friday, new test based on the latest commit looks good.
Quoted 25 lines
From the list we agreed previously [1]:
- announcement email,
- collecting patch lists for a new release,
- writing release notes, or paperwork,
- new release commit and tag and create release in github from it
(not in [1], but obvious)
- uploading tarballs
- pre-testing against different Linux distributionI'll can do, what I did previously:
- new release commit and tag and create release in github from it
- uploading tarballs
- release notes for shell API (mostly network shell API)It'd be big help if Cyril managed to do release notes and the announcement.
Kind regards,
Petr[1]
https://lore.kernel.org/ltp/CAEemH2eSJQ-_30_Y3A567oqBFSOo=1tt7LJMtPq_BodjVNsm8w@mail.gmail.com/
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 6 lines
I'll can do, what I did previously:
- new release commit and tag and create release in github from it
- uploading tarballs
- release notes for shell API (mostly network shell API)It'd be big help if Cyril managed to do release notes and the announcement.
I'm ready at my side. Peter can you please proceed with tagging the git and tarball upload?
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril,
Quoted 10 lines
Hi!
Quoted 6 lines
I'll can do, what I did previously:
- new release commit and tag and create release in github from it
- uploading tarballs
- release notes for shell API (mostly network shell API)It'd be big help if Cyril managed to do release notes and the announcement.
I'm ready at my side. Peter can you please proceed with tagging the git and tarball upload?
Sure, I'm about to do it now.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi all,
Quoted 8 lines
Hi Cyril,
Quoted 5 lines
Hi!
Quoted 4 lines
I'll can do, what I did previously:
- new release commit and tag and create release in github from it
- uploading tarballs
- release notes for shell API (mostly network shell API)
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
It'd be big help if Cyril managed to do release notes and the announcement.
I'm ready at my side. Peter can you please proceed with tagging the git and tarball upload?
Sure, I'm about to do it now.
I've tagged LTP, created release on Github, where I uploaded tarballs, checksums and html metadata. I'll upload pdf metadata shortly.
@Cyril please post the announcement and add it to the release (or let me know if I should add it from your mail).
Kind regards,
Petr
Quoted 2 lines
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 12 lines
Hi all,
Quoted 9 lines
Hi Cyril,
Quoted 7 lines
Hi!
Quoted 6 lines
I'll can do, what I did previously:
- new release commit and tag and create release in github from it
- uploading tarballs
- release notes for shell API (mostly network shell API)It'd be big help if Cyril managed to do release notes and the announcement.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
I'm ready at my side. Peter can you please proceed with tagging the git and tarball upload?
Sure, I'm about to do it now.
I've tagged LTP, created release on Github, where I uploaded tarballs, checksums and html metadata. I'll upload pdf metadata shortly.
OK, PDF metadata has 19 MB, let's not upload it. FYI HTML metadata has 2.3 MB.
Kind regards,
Petr
Quoted 8 lines
@Cyril please post the announcement and add it to the release (or let me know if I should add it from your mail).
Kind regards,
PetrQuoted 2 lines
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril,
Quoted 5 lines · Cyril Hrubis
Hi!
I would like to start with LTP pre-release preparations a bit sooner than usuall, since quite a lot of things have accumulated in May, e.g. there is a SUSE Labs conference right in the middle of the month.
Quoted 9 lines
I would like to start with reviewe of patches that should go in now, freeze the git somewhere at the end of the first week of May and aim for a release somewhere in the middle of the month. Does that sound Ok to everyone?
Either way if you have patches that should land in the upcomming release, please point them out now, so that we have a chance to review them.
It's not critical in the slightest, but we would appreciate if my setpgid series[0] could land for the release.
Happy to allocate a bit more time for quickly turning around additional versions if needed. It's a rather small series anyway.
Thanks very much in advance for the release !
Best regards,
Téo
[0]: https://lists.linux.it/pipermail/ltp/2023-April/033574.html
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi,
there's still one more patch to apply if we want to remove ltp_clone_quick deprecated function. That's "[v2] Remove ltp_clone_quick usage from pidns suite". Then we can safely remove libclone library which is not used anymore. There's also one patch which can be useful in the next release and it's "[PATCH v2] Support return value in TST_* macros", which add return code to some of the most used TST_* macros.
Regards,
Andrea Cervesato
Quoted 14 lines · Cyril Hrubis
Hi!
I would like to start with LTP pre-release preparations a bit sooner than usuall, since quite a lot of things have accumulated in May, e.g. there is a SUSE Labs conference right in the middle of the month.I would like to start with reviewe of patches that should go in now, freeze the git somewhere at the end of the first week of May and aim for a release somewhere in the middle of the month. Does that sound Ok to everyone?
Either way if you have patches that should land in the upcomming release, please point them out now, so that we have a chance to review them.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril
Quoted 5 lines
Hi!
I would like to start with LTP pre-release preparations a bit sooner than usuall, since quite a lot of things have accumulated in May, e.g. there is a SUSE Labs conference right in the middle of the month.
Quoted 8 lines
I would like to start with reviewe of patches that should go in now, freeze the git somewhere at the end of the first week of May and aim for a release somewhere in the middle of the month. Does that sound Ok to everyone?
Either way if you have patches that should land in the upcomming release, please point them out now, so that we have a chance to review them.
I prefer to include my STATX_DIO_ALIGN and mlock cleanup patchset before release.
Bes Regards
Yang Xu
Quoted 1 line
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Cyril Hrubis
AppliedHi!
Quoted 2 lines
I prefer to include my
STATX_DIO_ALIGNand mlock cleanup patchset before release.
I merged mlock04. I'm unsure about the mlock03 removal, it seems to be a regression test after all.
As for STAT_DIO_ALIGN I suppose that we need v5, right?
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril
Quoted 6 lines
Hi!
Quoted 2 lines
I prefer to include my
STATX_DIO_ALIGNand mlock cleanup patchset before release.I merged mlock04. I'm unsure about the mlock03 removal, it seems to be a regression test after all.
Thanks, I just back from a long and happy holidy, I will submit a v3 for mlock03.
Quoted 2 lines
As for
STAT_DIO_ALIGNI suppose that we need v5, right?
Yes, I will add some meaningful comment and modify to use in-tree definition on V5.
Best Regards
Yang Xu
Quoted 1 line
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi all,
* IMHO Martin's KVM patchset should be merged
https://patchwork.ozlabs.org/project/ltp/list/?series=351921&state=*
* nfslock01.sh: Don't test on NFS v3 on TCP
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
=> IMHO should go in to increase NFS tests stability
* NFS: test on all filesystems
https://patchwork.ozlabs.org/project/ltp/list/?series=352840&state=*
Kind regards,
Petr
Quoted 13 lines
Hi!
I would like to start with LTP pre-release preparations a bit sooner than usuall, since quite a lot of things have accumulated in May, e.g. there is a SUSE Labs conference right in the middle of the month.I would like to start with reviewe of patches that should go in now, freeze the git somewhere at the end of the first week of May and aim for a release somewhere in the middle of the month. Does that sound Ok to everyone?
Either way if you have patches that should land in the upcomming release, please point them out now, so that we have a chance to review them.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi all,
Also this one should be merged:
* nfs08.sh: Skip on vfat
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
Quoted 12 lines
* IMHO Martin's KVM patchset should be merged
https://patchwork.ozlabs.org/project/ltp/list/?series=351921&state=**
nfslock01.sh: Don't test on NFS v3 on TCP
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
=> IMHO should go in to increase NFS tests stability* NFS: test on all filesystems
https://patchwork.ozlabs.org/project/ltp/list/?series=352840&state=*Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 2 lines
*
nfs08.sh: Skip on vfat
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
This is workaround for bugs found by the "run nfs on all fs" patch, right?
I suppose that it may be better not to enable nfs on all filesystems for this release so that we have time to figure out what is wrong before next release.
I really do not like applying "temporary" workarounds for real bugs in the LTP codebase. There is always danger of "temporary" being forgotten and we end up masking the real bug for eternity.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 6 lines
Hi!
Quoted 2 lines
*
nfs08.sh: Skip on vfat
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/This is workaround for bugs found by the "run nfs on all fs" patch, right?
Well, this is the problem which was found by this patchset. If you use TMPDIR with vfat or exfat (unlikely, I know) on current master, it will fail. I tested it on both loop device (demonstrated below) and on separate disc in VM.
dd if=/dev/zero of=/tmp/dev bs=1M count=500
losetup /dev/loop0 /tmp/dev
mkfs.exfat /dev/loop0
mkdir -p /export
mount /dev/loop0 /export
df -hT /export/
Filesystem Type Size Used Avail Use% Mounted on /dev/loop0 vfat 500M 0 500M 0% /export
PATH="/opt/ltp/testcases/bin:$PATH" TMPDIR=/export nfs08.sh -v 4 -t tcp
...
nfs08 1 TINFO: timeout per run is 0h 5m 0s
nfs08 1 TINFO: mount.nfs: (linux nfs-utils 2.6.3)
nfs08 1 TINFO: setup NFSv4, socket type tcp
nfs08 1 TINFO: Mounting NFS: mount -v -t nfs -o proto=tcp,vers=4 10.0.0.2:/export/LTP_nfs08.R9JOL8zozk/4/tcp /export/LTP_nfs08.R9JOL8zozk/4/0 nfs08 1 TINFO: testing NFS cache invalidation for directories
1
nfs08 1 TPASS: ls | grep 1 passed as expected
nfs08 1 TFAIL: ls | grep 2 failed unexpectedly
Actually, nfs08.sh not working on vfat and exfat
=> therefore nfs_lib.sh should be without TST_SKIP_FILESYSTEMS (currently all tests whitelists exfat) and nfs08.sh should have: TST_SKIP_FILESYSTEMS="exfat,vfat"
umount /export
umount: /export: target is busy.
fuser -vm /dev/loop0
USER PID ACCESS COMMAND/dev/loop0: root kernel mount /export
root kernel knfsd /export
=> Forced me to umount with -l or reboot, regardless used filesystem on /dev/loop0. This is fixed in this patchset which uses TST_ALL_FILESYSTEMS, but I'd prefer to merge it instead of fixing master.
This is reproducible even if I just add new device (i.e. not a loop device) to VM.
Quoted 7 lines
I suppose that it may be better not to enable nfs on all filesystems for this release so that we have time to figure out what is wrong before next release.
I really do not like applying "temporary" workarounds for real bugs in the LTP codebase. There is always danger of "temporary" being forgotten and we end up masking the real bug for eternity.
We're masking the problems, because by default we test on what's on /tmp (often tmpfs, which is unlikely to be used for NFS or ext4 or btrfs).
I need to test more old distros, I suspect that nfs-utils 1.3.3 has problems with vfat, exfat, tmpfs and fuse, which is in Debian 11 (bullseye).
=> Maybe, as a start we could decide to run nfs_lib.sh only on modern linux
filesystems: i.e. btrfs, ext4, xfs
We could have:
TST_SKIP_FILESYSTEMS="btrfs,exfat,ext2,ext3,fuse,ntfs,vfat,tmpfs" That would shorten the runtime and have more test coverage. WDYT? I'm about to send v5 and run tests in the loop. Shell I include this change?
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 60 lines
Quoted 6 lines
Hi!
Quoted 2 lines
*
nfs08.sh: Skip on vfat
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/This is workaround for bugs found by the "run nfs on all fs" patch, right?
Well, this is the problem which was found by this patchset. If you use TMPDIR with vfat or exfat (unlikely, I know) on current master, it will fail. I tested it on both loop device (demonstrated below) and on separate disc in VM.
dd if=/dev/zero of=/tmp/dev bs=1M count=500
losetup/dev/loop0/tmp/dev
mkfs.exfat/dev/loop0
mkdir -p /export
mount/dev/loop0/export
df -hT /export/Filesystem Type Size Used Avail Use% Mounted on /dev/loop0 vfat 500M 0 500M 0% /exportPATH="/opt/ltp/testcases/bin:$PATH" TMPDIR=/export
nfs08.sh-v 4 -t tcp
...
nfs08 1 TINFO: timeout per run is 0h 5m 0s
nfs08 1 TINFO: mount.nfs: (linux nfs-utils 2.6.3)
nfs08 1 TINFO: setup NFSv4, socket type tcp
nfs08 1 TINFO: Mounting NFS: mount -v -t nfs -o proto=tcp,vers=4 10.0.0.2:/export/LTP_nfs08.R9JOL8zozk/4/tcp /export/LTP_nfs08.R9JOL8zozk/4/0 nfs08 1 TINFO: testing NFS cache invalidation for directories
1
nfs08 1 TPASS: ls | grep 1 passed as expected
nfs08 1 TFAIL: ls | grep 2 failed unexpectedlyActually,
nfs08.shnot working on vfat and exfat
=> thereforenfs_lib.shshould be withoutTST_SKIP_FILESYSTEMS(currently all tests whitelists exfat) andnfs08.shshould have: TST_SKIP_FILESYSTEMS="exfat,vfat"umount /export
umount: /export: target is busy.fuser -vm
/dev/loop0
USER PID ACCESS COMMAND/dev/loop0: root kernel mount /export
root kernel knfsd /export=> Forced me to umount with -l or reboot, regardless used filesystem on
/dev/loop0. This is fixed in this patchset which usesTST_ALL_FILESYSTEMS, but I'd prefer to merge it instead of fixing master.This is reproducible even if I just add new device (i.e. not a loop device) to VM.
Quoted 7 lines
I suppose that it may be better not to enable nfs on all filesystems for this release so that we have time to figure out what is wrong before next release.
I really do not like applying "temporary" workarounds for real bugs in the LTP codebase. There is always danger of "temporary" being forgotten and we end up masking the real bug for eternity.
We're masking the problems, because by default we test on what's on /tmp (often tmpfs, which is unlikely to be used for NFS or ext4 or btrfs).
Quoted 7 lines
I need to test more old distros, I suspect that nfs-utils 1.3.3 has problems with vfat, exfat, tmpfs and fuse, which is in Debian 11 (bullseye).
=> Maybe, as a start we could decide to run
nfs_lib.shonly on modern linux
filesystems: i.e. btrfs, ext4, xfs
We could have:
TST_SKIP_FILESYSTEMS="btrfs,exfat,ext2,ext3,fuse,ntfs,vfat,tmpfs"
I meant here TST_SKIP_FILESYSTEMS="exfat,ext2,ext3,fuse,ntfs,vfat,tmpfs" (i.e. to run on btrfs, ext4, xfs only)
Kind regards,
Petr
Quoted 6 lines
That would shorten the runtime and have more test coverage. WDYT? I'm about to send v5 and run tests in the loop. Shell I include this change?
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 2 lines
* IMHO Martin's KVM patchset should be merged
https://patchwork.ozlabs.org/project/ltp/list/?series=351921&state=*
Feel free to merge with my ack as long as it passes basic testsing.
Quoted 3 lines
*
nfslock01.sh: Don't test on NFS v3 on TCP
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
=> IMHO should go in to increase NFS tests stability
The discussion around it sounds like this is a kernel problem after all.
Quoted 2 lines
* NFS: test on all filesystems
https://patchwork.ozlabs.org/project/ltp/list/?series=352840&state=*
This is rather big change, is this important enough to get it in just before the git freeze?
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Cyril, all,
Quoted 5 lines
Hi!
Quoted 2 lines
* IMHO Martin's KVM patchset should be merged
https://patchwork.ozlabs.org/project/ltp/list/?series=351921&state=*Feel free to merge with my ack as long as it passes basic testsing.
I merged the first four patches, but the final patch (the test itself) has warnings. I hope they are trivial enough to be fixed so that we can merge it.
https://lore.kernel.org/ltp/20230503124240.GA3738345@pevik/
Quoted 5 lines
Quoted 3 lines
*
nfslock01.sh: Don't test on NFS v3 on TCP
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
=> IMHO should go in to increase NFS tests stabilityThe discussion around it sounds like this is a kernel problem after all.
Yes (kernel and rpcbind). I'd be for merging it, at least until the fix is released and we can give hints for update. Will you please post your ack to the patch?
Quoted 5 lines
Quoted 2 lines
* NFS: test on all filesystems
https://patchwork.ozlabs.org/project/ltp/list/?series=352840&state=*This is rather big change, is this important enough to get it in just before the git freeze?
Neil Brown asked me to cover more underlaying filesystems in NFS testing. I'm about to send new version, which increases timeouts a bit.
I did test it quite a lot (and will do some more tests today) and believe I'd be able to fix potential problems before release. I started to work on TST_ALL_FILESYSTEMS for shell API a year ago, it got merged in September. That's quite long time for quite simple change, that's why I'm a bit impatient to postpone it yet for another release.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi all,
Quoted 11 lines
Hi!
Quoted 2 lines
* IMHO Martin's KVM patchset should be merged
https://patchwork.ozlabs.org/project/ltp/list/?series=351921&state=*Feel free to merge with my ack as long as it passes basic testsing.
Quoted 3 lines
*
nfslock01.sh: Don't test on NFS v3 on TCP
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
=> IMHO should go in to increase NFS tests stabilityThe discussion around it sounds like this is a kernel problem after all.
I didn't get if we want to keep this *not* merged.
Quoted 5 lines
Quoted 2 lines
* NFS: test on all filesystems
https://patchwork.ozlabs.org/project/ltp/list/?series=352840&state=*This is rather big change, is this important enough to get it in just before the git freeze?
There is v5 which tests only btrfs, ext4 and xfs. That should be safe to merge.
https://patchwork.ozlabs.org/project/ltp/list/?series=353495
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
*
nfslock01.sh: Don't test on NFS v3 on TCP
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
=> IMHO should go in to increase NFS tests stabilityThe discussion around it sounds like this is a kernel problem after all.
I didn't get if we want to keep this *not* merged.
That goes against "do not work around real bugs in tests", if possible I wouldn't apply any workarounds even if there is no upstream fix yet, maybe just a message that this is a known bug.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
* NFS: test on all filesystems
https://patchwork.ozlabs.org/project/ltp/list/?series=352840&state=*This is rather big change, is this important enough to get it in just before the git freeze?
There is v5 which tests only btrfs, ext4 and xfs. That should be safe to merge.
https://patchwork.ozlabs.org/project/ltp/list/?series=353495
I will have a look.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 5 lines
Hi!
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
*
nfslock01.sh: Don't test on NFS v3 on TCP
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
=> IMHO should go in to increase NFS tests stability
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
The discussion around it sounds like this is a kernel problem after all.
I didn't get if we want to keep this *not* merged.
That goes against "do not work around real bugs in tests", if possible I wouldn't apply any workarounds even if there is no upstream fix yet, maybe just a message that this is a known bug.
Fair enough, I rejected my patch. If no fix come out of the suggestion, I'd be for adding a TINFO message, but let's wait.
Quoted 10 lines
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
* NFS: test on all filesystems
https://patchwork.ozlabs.org/project/ltp/list/?series=352840&state=*This is rather big change, is this important enough to get it in just before the git freeze?
There is v5 which tests only btrfs, ext4 and xfs. That should be safe to merge.
https://patchwork.ozlabs.org/project/ltp/list/?series=353495I will have a look.
Thanks.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi all,
I suggest to merge these:
* Martin's patchset (first and second commit; the third one I dared to merge as it's just doc fix)
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
* endian_switch01: Add HAVE_GETAUXVAL guarder
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
Build fix for uclibc toolchains (Jan already acked that)
I'd also consider merging these 2 fixes:
* [v2] syscalls/sockioctl: Make buf a struct ifreq array
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
* testcases:Fix the failure of shell script to get path
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
Kind regards,
Petr
Quoted 13 lines
Hi!
I would like to start with LTP pre-release preparations a bit sooner than usuall, since quite a lot of things have accumulated in May, e.g. there is a SUSE Labs conference right in the middle of the month.I would like to start with reviewe of patches that should go in now, freeze the git somewhere at the end of the first week of May and aim for a release somewhere in the middle of the month. Does that sound Ok to everyone?
Either way if you have patches that should land in the upcomming release, please point them out now, so that we have a chance to review them.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 5 lines · Cyril Hrubis
Hi!
I would like to start with LTP pre-release preparations a bit sooner than usuall, since quite a lot of things have accumulated in May, e.g. there is a SUSE Labs conference right in the middle of the month.
Quoted 8 lines
I would like to start with reviewe of patches that should go in now, freeze the git somewhere at the end of the first week of May and aim for a release somewhere in the middle of the month. Does that sound Ok to everyone?
Either way if you have patches that should land in the upcomming release, please point them out now, so that we have a chance to review them.
Hi,
I've sent two patches fixing new failures in the rewritten kernel/containers tests. The failures are caused by getpid() return value being cached in older glibc versions because child processes created by SAFE_CLONE() cannot update the PID cache. Thus getpid() will keep returning the parent PID instead of the correct one. Newer glibc versions are not affected.
The patches:
- Add tst_getpid() helper function
- containers/pidns*: Fix PID checks
Please merge them before release.
Signature · 11 lines
Martin Doucha [email protected] QA Engineer for Software Maintenance SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Pushed, thanks.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp