Skip to contentSkip to conversation

maintainers: update for gve

PATCH In review Junfeng Guo 7 participants 12 messages Nov 9, 2022 – May 8, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 maintainers: update for gve

Add co-maintainers from Google team for gve (Google Virtual Ethernet).

---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)
MAINTAINERS +3 -0
index 1c9922123e..d8c1d5272b 100644
@@ -698,6 +698,9 @@ F: doc/guides/nics/features/enic.ini
 
 Google Virtual Ethernet
 M: Junfeng Guo <[email protected]>
+M: Jeroen de Borst <[email protected]>
+M: Rushil Gupta <[email protected]>
+M: Jordan Kimbrough <[email protected]>
 F: drivers/net/gve/
 F: doc/guides/nics/gve.rst
 F: doc/guides/nics/features/gve.ini
Signature · 1 line
2.34.1
#1 lore raw

Thanks a lot Junfeng!

Quoted 25 lines · Junfeng Guo

Add co-maintainers from Google team for gve (Google Virtual Ethernet).

---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)
MAINTAINERS +3 -1
index 1c9922123e..d8c1d5272b 100644
@@ -698,6 +698,9 @@ F: doc/guides/nics/features/enic.ini
 
 Google Virtual Ethernet
 M: Junfeng Guo <[email protected]>
+M: Jeroen de Borst <[email protected]>
+M: Rushil Gupta <[email protected]>
+M: Jordan Kimbrough <[email protected]>
 F: drivers/net/gve/
 F: doc/guides/nics/gve.rst
 F: doc/guides/nics/features/gve.ini
--

2.34.1

#2 lore raw

09/11/2022 20:37, Rushil Gupta:

Quoted 6 lines

Thanks a lot Junfeng!

Quoted 2 lines · Junfeng Guo

Add co-maintainers from Google team for gve (Google Virtual Ethernet).

Quoted 7 lines

MAINTAINERS F: doc/guides/nics/features/enic.ini · line 703

Quoted 7 lines

---
Google Virtual Ethernet
M: Junfeng Guo <[email protected]>

MAINTAINERS +3 -0
+M: Jeroen de Borst <[email protected]>
+M: Rushil Gupta <[email protected]>
+M: Jordan Kimbrough <[email protected]>

They were not part of the patch review process in the mailing list, why do you want them to become maintainers?
I think it would be saner to have them involved first.

#3 lore raw
Quoted 23 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, November 15, 2022 16:33
To: Guo, Junfeng <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; [email protected]; Xing, Beilei <[email protected]>; [email protected]; [email protected]; [email protected]; Zhang, Helin <[email protected]>; Rushil Gupta <[email protected]>; Jeroen de Borst <[email protected]>; Jordan Kimbrough <[email protected]>
Subject: Re: [PATCH] maintainers: update for gve

09/11/2022 20:37, Rushil Gupta:

Quoted 3 lines

Thanks a lot Junfeng!

On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <[email protected]>

Quoted 2 lines · wrote:
Quoted 2 lines

Add co-maintainers from Google team for gve (Google Virtual

Ethernet).

Quoted 1 line
Quoted 1 line
Quoted 11 lines
Quoted 7 lines

MAINTAINERS F: doc/guides/nics/features/enic.ini · line 703

Quoted 7 lines

---
Google Virtual Ethernet
M: Junfeng Guo <[email protected]>

MAINTAINERS +3 -0
+M: Jeroen de Borst <[email protected]>
+M: Rushil Gupta <[email protected]>
+M: Jordan Kimbrough <[email protected]>

They were not part of the patch review process in the mailing list, why do you want them to become maintainers?
I think it would be saner to have them involved first.

Yes, make sense! Thanks for reminding this!

Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
could you help register for [email protected]
at https://www.dpdk.org/contribute/#Mailing-Lists as well as for the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first? Then you can add more info & explanation for your maintaining plan here. Thanks!

Quoted 1 line
#4 lore raw

Done. Thanks Junfeng!

Quoted 48 lines · Junfeng
Quoted 24 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, November 15, 2022 16:33
To: Guo, Junfeng <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; [email protected]; Xing, Beilei <[email protected]>; [email protected]; [email protected]; [email protected]; Zhang, Helin <[email protected]>; Rushil Gupta <[email protected]>; Jeroen de Borst <[email protected]>; Jordan Kimbrough <[email protected]>
Subject: Re: [PATCH] maintainers: update for gve

09/11/2022 20:37, Rushil Gupta:

Quoted 3 lines

Thanks a lot Junfeng!

On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <[email protected]>

Quoted 2 lines · wrote:
Quoted 2 lines

Add co-maintainers from Google team for gve (Google Virtual

Ethernet).

Quoted 1 line
Quoted 1 line
Quoted 11 lines
Quoted 7 lines

MAINTAINERS F: doc/guides/nics/features/enic.ini · line 703

Quoted 7 lines

---
Google Virtual Ethernet
M: Junfeng Guo <[email protected]>

MAINTAINERS +3 -0
+M: Jeroen de Borst <[email protected]>
+M: Rushil Gupta <[email protected]>
+M: Jordan Kimbrough <[email protected]>

They were not part of the patch review process in the mailing list, why do you want them to become maintainers?
I think it would be saner to have them involved first.

Yes, make sense! Thanks for reminding this!

Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
could you help register for [email protected]
at https://www.dpdk.org/contribute/#Mailing-Lists as well as for the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first? Then you can add more info & explanation for your maintaining plan here. Thanks!

Quoted 1 line
#5 lore raw

I've also registered

Quoted 55 lines · Rushil Gupta

Done. Thanks Junfeng!

Quoted 48 lines · Junfeng
Quoted 24 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, November 15, 2022 16:33
To: Guo, Junfeng <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; [email protected]; Xing, Beilei <[email protected]>; [email protected]; [email protected]; [email protected]; Zhang, Helin <[email protected]>; Rushil Gupta <[email protected]>; Jeroen de Borst <[email protected]>; Jordan Kimbrough <[email protected]>
Subject: Re: [PATCH] maintainers: update for gve

09/11/2022 20:37, Rushil Gupta:

Quoted 3 lines

Thanks a lot Junfeng!

On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <[email protected]>

Quoted 2 lines · wrote:
Quoted 2 lines

Add co-maintainers from Google team for gve (Google Virtual

Ethernet).

Quoted 1 line
Quoted 1 line
Quoted 11 lines
Quoted 7 lines

MAINTAINERS F: doc/guides/nics/features/enic.ini · line 703

Quoted 7 lines

---
Google Virtual Ethernet
M: Junfeng Guo <[email protected]>

MAINTAINERS +3 -0
+M: Jeroen de Borst <[email protected]>
+M: Rushil Gupta <[email protected]>
+M: Jordan Kimbrough <[email protected]>

They were not part of the patch review process in the mailing list, why do you want them to become maintainers?
I think it would be saner to have them involved first.

Yes, make sense! Thanks for reminding this!

Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
could you help register for [email protected]
at https://www.dpdk.org/contribute/#Mailing-Lists as well as for the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first? Then you can add more info & explanation for your maintaining plan here. Thanks!

Quoted 1 line
#6 lore raw

This driver is for Google's virtual NIC and the team here at Google is working on DPDK support. We were unaware of this driver until just a few weeks ago.

There are many features missing from the driver currently released and our team intends to make sure this driver support all relevant features of our device (both current and upcoming). Since our team works closely with the team that develops the virtual device, we can proactively add (and test) features before they're made publicly available.

Some of these features are:

- Jumbo-frame support
- A new queue format (that supports out-of-order completions)
- RSS support
- Flow-steering
- Header-split

We're grateful to the original contributor of this driver and will closely collaborate with them going forward.

Regards,
Jeroen de Borst
Tech Lead for guest drivers with Google Cloud

Quoted 60 lines · Jordan Kimbrough

I've also registered

Quoted 55 lines · Rushil Gupta

Done. Thanks Junfeng!

Quoted 48 lines · Junfeng
Quoted 24 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, November 15, 2022 16:33
To: Guo, Junfeng <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; [email protected]; Xing, Beilei <[email protected]>; [email protected]; [email protected]; [email protected]; Zhang, Helin <[email protected]>; Rushil Gupta <[email protected]>; Jeroen de Borst <[email protected]>; Jordan Kimbrough <[email protected]>
Subject: Re: [PATCH] maintainers: update for gve

09/11/2022 20:37, Rushil Gupta:

Quoted 3 lines

Thanks a lot Junfeng!

On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <[email protected]>

Quoted 2 lines · wrote:
Quoted 2 lines

Add co-maintainers from Google team for gve (Google Virtual

Ethernet).

Quoted 1 line
Quoted 1 line
Quoted 11 lines
Quoted 7 lines

MAINTAINERS F: doc/guides/nics/features/enic.ini · line 703

Quoted 7 lines

---
Google Virtual Ethernet
M: Junfeng Guo <[email protected]>

MAINTAINERS +3 -0
+M: Jeroen de Borst <[email protected]>
+M: Rushil Gupta <[email protected]>
+M: Jordan Kimbrough <[email protected]>

They were not part of the patch review process in the mailing list, why do you want them to become maintainers?
I think it would be saner to have them involved first.

Yes, make sense! Thanks for reminding this!

Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
could you help register for [email protected]
at https://www.dpdk.org/contribute/#Mailing-Lists as well as for the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first? Then you can add more info & explanation for your maintaining plan here. Thanks!

Quoted 1 line
#7 lore raw

PATCH v2 1/1 net/gve: add maintainers for GVE

In reply to Junfeng Guo

Add maintainers from Google for GVE.

---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)
MAINTAINERS +3 -0
index 8df23e5099..08001751b0 100644
@@ -713,6 +713,9 @@ F: doc/guides/nics/features/enic.ini
 
 Google Virtual Ethernet
 M: Junfeng Guo <[email protected]>
+M: Jeroen de Borst <[email protected]>
+M: Rushil Gupta <[email protected]>
+M: Joshua Washington <[email protected]>
 F: drivers/net/gve/
 F: doc/guides/nics/gve.rst
 F: doc/guides/nics/features/gve.ini
Signature · 1 line
2.34.1
Acked-by on v2 1/1
#8 lore raw

Re: [PATCH v2] net/gve: add maintainers for GVE

Quoted 28 lines · Junfeng Guo

Add maintainers from Google for GVE.

---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)
MAINTAINERS +3 -1
index 8df23e5099..08001751b0 100644
@@ -713,6 +713,9 @@ F: doc/guides/nics/features/enic.ini
 
 Google Virtual Ethernet
 M: Junfeng Guo <[email protected]>
+M: Jeroen de Borst <[email protected]>
+M: Rushil Gupta <[email protected]>
+M: Joshua Washington <[email protected]>
 F: drivers/net/gve/
 F: doc/guides/nics/gve.rst
 F: doc/guides/nics/features/gve.ini
--

2.34.1

Applied
#11 lore raw

Re: [PATCH v2] net/gve: add maintainers for GVE

In reply to Rushil Gupta
Quoted 1 line
Quoted 1 line · Rushil Gupta

Moved and accumulated acks down.

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines · Junfeng Guo
Quoted 7 lines

Add maintainers from Google for GVE.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Applied to dpdk-next-net/main, thanks.