PCI: layerscape: Add the endpoint linkup notifier support
Subsystems (4)
Frank Li
maintainerPATCH v2 1/1 PCI: layerscape: Add the endpoint linkup notifier support
Layerscape has PME interrupt, which can be used as linkup notifier. Set CFG_READY bit when linkup detected.
---
Change from v1 to v2
- pme -> PME
- irq -> IRQ
- update dev_info message according to Bjorn's suggestion
- remove '.' at error message
.../pci/controller/dwc/pci-layerscape-ep.c | 104 +++++++++++++++++- 1 file changed, 103 insertions(+), 1 deletion(-)
drivers/pci/controller/dwc/pci-layerscape-ep.c +103 -1
@@ -18,6 +18,20 @@#include "pcie-designware.h" +#define PEX_PF0_CONFIG 0xC0014 +#define PEX_PF0_CFG_READY BIT(0) + +/* PEX PFa PCIE PME and message interrupt registers*/ +#define PEX_PF0_PME_MES_DR 0xC0020 +#define PEX_PF0_PME_MES_DR_LUD BIT(7) +#define PEX_PF0_PME_MES_DR_LDD BIT(9) +#define PEX_PF0_PME_MES_DR_HRD BIT(10) + +#define PEX_PF0_PME_MES_IER 0xC0028 +#define PEX_PF0_PME_MES_IER_LUDIE BIT(7) +#define PEX_PF0_PME_MES_IER_LDDIE BIT(9) +#define PEX_PF0_PME_MES_IER_HRDIE BIT(10) +#define to_ls_pcie_ep (x) dev_get_drvdata((x)->dev)struct ls_pcie_ep_drvdata {
@@ -30,8 +44,88 @@ struct ls_pcie_ep {struct dw_pcie *pci;struct pci_epc_features *ls_epc;const struct ls_pcie_ep_drvdata *drvdata; +bool big_endian; +int irq; }; +static u32 ls_lut_readl (struct ls_pcie_ep *pcie,u32 offset) +{ +struct dw_pcie *pci = pcie->pci; + +if (pcie->big_endian) +return ioread32be (pci->dbi_base + offset); +else +return ioread32 (pci->dbi_base + offset); +} + +static void ls_lut_writel (struct ls_pcie_ep *pcie,u32 offset, +u32 value) +{ +struct dw_pcie *pci = pcie->pci; + +if (pcie->big_endian) +iowrite32be (value, pci->dbi_base + offset); +else +iowrite32 (value, pci->dbi_base + offset); +} + +static irqreturn_t ls_pcie_ep_event_handler (int irq,void *dev_id) +{ +struct ls_pcie_ep *pcie = (struct ls_pcie_ep *)dev_id; +struct dw_pcie *pci = pcie->pci; +u32 val, cfg; + + val =ls_lut_readl (pcie,PEX_PF0_PME_MES_DR ); +if (!val) +return IRQ_NONE ; + +if (val &PEX_PF0_PME_MES_DR_LUD ) { + cfg =ls_lut_readl (pcie,PEX_PF0_CONFIG ); + cfg |=PEX_PF0_CFG_READY ; +ls_lut_writel (pcie,PEX_PF0_CONFIG , cfg); +dw_pcie_ep_linkup (&pci->ep); + +dev_info (pci->dev,"Link up\n" ); + }else if (val &PEX_PF0_PME_MES_DR_LDD ) { +dev_info (pci->dev,"Link down\n" ); + }else if (val &PEX_PF0_PME_MES_DR_HRD ) { +dev_info (pci->dev,"Hot reset\n" ); + } + +ls_lut_writel (pcie,PEX_PF0_PME_MES_DR , val); + +return IRQ_HANDLED ; +} + +static int ls_pcie_ep_interrupt_init (struct ls_pcie_ep *pcie, +struct platform_device *pdev) +{ +u32 val; +int ret; + + pcie->irq =platform_get_irq_byname (pdev,"pme" ); +if (pcie->irq <0 ) { +dev_err (&pdev->dev,"Can't get 'pme' IRQ\n" ); +return pcie->irq; + } + + ret =devm_request_irq (&pdev->dev, pcie->irq, + ls_pcie_ep_event_handler,IRQF_SHARED , + pdev->name, pcie); +if (ret) { +dev_err (&pdev->dev,"Can't register PCIe IRQ\n" ); +return ret; + } + +/* Enable interrupts */ + val =ls_lut_readl (pcie,PEX_PF0_PME_MES_IER ); + val |=PEX_PF0_PME_MES_IER_LDDIE |PEX_PF0_PME_MES_IER_HRDIE | +PEX_PF0_PME_MES_IER_LUDIE ; +ls_lut_writel (pcie,PEX_PF0_PME_MES_IER , val); + +return 0 ; +} +static const struct pci_epc_features *ls_pcie_ep_get_features (struct dw_pcie_ep *ep) {
@@ -125,6 +219,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)struct ls_pcie_ep *pcie;struct pci_epc_features *ls_epc;struct resource *dbi_base; +int ret; pcie =devm_kzalloc (dev,sizeof (*pcie),GFP_KERNEL );if (!pcie)
@@ -144,6 +239,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) pci->ops = pcie->drvdata->dw_pcie_ops; ls_epc->bar_fixed_64bit = (1 <<BAR_2 ) | (1 <<BAR_4 ); + ls_epc->linkup_notifier = true; pcie->pci = pci; pcie->ls_epc = ls_epc;
@@ -155,9 +251,15 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) pci->ep.ops = &ls_pcie_ep_ops; + pcie->big_endian =of_property_read_bool (dev->of_node,"big-endian" ); +platform_set_drvdata (pdev, pcie); -return dw_pcie_ep_init (&pci->ep); + ret =dw_pcie_ep_init (&pci->ep); +if (ret) +return ret; + +return ls_pcie_ep_interrupt_init (pcie, pdev); }static struct platform_driver ls_pcie_ep_driver = {
Signature · 1 line
2.34.1
Quoted 2 lines · Frank Li
Layerscape has PME interrupt, which can be used as linkup notifier. Set
CFG_READYbit when linkup detected.
Where are you setting this bit?
Quoted 48 lines
Signed-off-by Xiaowei Bao <[email protected]>Signed-off-by Frank Li <[email protected]>---
Change from v1 to v2
- pme -> PME
- irq -> IRQ
- updatedev_infomessage according to Bjorn's suggestion
- remove '.' at error message.../pci/controller/dwc/pci-layerscape-ep.c | 104 +++++++++++++++++- 1 file changed, 103 insertions(+), 1 deletion(-)drivers/pci/controller/dwc/pci-layerscape-ep.c +18
-0@@ -18,6 +18,20 @@#include "pcie-designware.h" +#define PEX_PF0_CONFIG 0xC0014 +#define PEX_PF0_CFG_READY BIT(0) + +/* PEX PFa PCIE PME and message interrupt registers*/ +#define PEX_PF0_PME_MES_DR 0xC0020 +#define PEX_PF0_PME_MES_DR_LUD BIT(7) +#define PEX_PF0_PME_MES_DR_LDD BIT(9) +#define PEX_PF0_PME_MES_DR_HRD BIT(10) + +#define PEX_PF0_PME_MES_IER 0xC0028 +#define PEX_PF0_PME_MES_IER_LUDIE BIT(7) +#define PEX_PF0_PME_MES_IER_LDDIE BIT(9) +#define PEX_PF0_PME_MES_IER_HRDIE BIT(10) +#define to_ls_pcie_ep (x) dev_get_drvdata((x)->dev)struct ls_pcie_ep_drvdata {@@ -30,8 +44,88 @@ struct ls_pcie_ep {struct dw_pcie *pci;struct pci_epc_features *ls_epc;const struct ls_pcie_ep_drvdata *drvdata; +bool big_endian; +int irq; }; +static u32 ls_lut_readl (struct ls_pcie_ep *pcie,u32 offset) +{
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 62
Quoted 10 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +10
-0+struct dw_pcie *pci = pcie->pci; + +if (pcie->big_endian) +return ioread32be (pci->dbi_base + offset); +else +return ioread32 (pci->dbi_base + offset); +} + +static void ls_lut_writel (struct ls_pcie_ep *pcie,u32 offset, +u32 value)
Above function argument could be wrapped within 80 columns.
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 74
Quoted 12 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +12
-0+{ +struct dw_pcie *pci = pcie->pci; + +if (pcie->big_endian) +iowrite32be (value, pci->dbi_base + offset); +else +iowrite32 (value, pci->dbi_base + offset); +} + +static irqreturn_t ls_pcie_ep_event_handler (int irq,void *dev_id) +{ +struct ls_pcie_ep *pcie = (struct ls_pcie_ep *)dev_id;
No need to do explicit typecase for void pointer.
Quoted 4 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +4
-0+struct dw_pcie *pci = pcie->pci; +u32 val, cfg; + + val =ls_lut_readl (pcie,PEX_PF0_PME_MES_DR );
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 88
Quoted 10 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +10
-0+if (!val) +return IRQ_NONE ; + +if (val &PEX_PF0_PME_MES_DR_LUD ) { + cfg =ls_lut_readl (pcie,PEX_PF0_CONFIG ); + cfg |=PEX_PF0_CFG_READY ; +ls_lut_writel (pcie,PEX_PF0_CONFIG , cfg); +dw_pcie_ep_linkup (&pci->ep); + +dev_info (pci->dev,"Link up\n" );
These messages could be demoted to dev_dbg() logs.
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 95
Quoted 7 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +7
-0+ }else if (val &PEX_PF0_PME_MES_DR_LDD ) { +dev_info (pci->dev,"Link down\n" ); + }else if (val &PEX_PF0_PME_MES_DR_HRD ) { +dev_info (pci->dev,"Hot reset\n" ); + } + +ls_lut_writel (pcie,PEX_PF0_PME_MES_DR , val);
You should clear the interrupts before processing.
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 108
Quoted 13 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +13
-0+ +return IRQ_HANDLED ; +} + +static int ls_pcie_ep_interrupt_init (struct ls_pcie_ep *pcie, +struct platform_device *pdev) +{ +u32 val; +int ret; + + pcie->irq =platform_get_irq_byname (pdev,"pme" ); +if (pcie->irq <0 ) { +dev_err (&pdev->dev,"Can't get 'pme' IRQ\n" );
PME
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 114
Quoted 6 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +6
-0+return pcie->irq; + } + + ret =devm_request_irq (&pdev->dev, pcie->irq, + ls_pcie_ep_event_handler,IRQF_SHARED , + pdev->name, pcie);
Again, please wrap to fit the 80 column width.
Quoted 35 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +16
-0+if (ret) { +dev_err (&pdev->dev,"Can't register PCIe IRQ\n" ); +return ret; + } + +/* Enable interrupts */ + val =ls_lut_readl (pcie,PEX_PF0_PME_MES_IER ); + val |=PEX_PF0_PME_MES_IER_LDDIE |PEX_PF0_PME_MES_IER_HRDIE | +PEX_PF0_PME_MES_IER_LUDIE ; +ls_lut_writel (pcie,PEX_PF0_PME_MES_IER , val); + +return 0 ; +} +static const struct pci_epc_features *ls_pcie_ep_get_features (struct dw_pcie_ep *ep) {@@ -125,6 +219,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)struct ls_pcie_ep *pcie;struct pci_epc_features *ls_epc;struct resource *dbi_base; +int ret; pcie =devm_kzalloc (dev,sizeof (*pcie),GFP_KERNEL );if (!pcie)@@ -144,6 +239,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) pci->ops = pcie->drvdata->dw_pcie_ops; ls_epc->bar_fixed_64bit = (1 <<BAR_2 ) | (1 <<BAR_4 ); + ls_epc->linkup_notifier = true; pcie->pci = pci; pcie->ls_epc = ls_epc;@@ -155,9 +251,15 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
drivers/pci/controller/dwc/pci-layerscape-ep.c static int __init ls_pcie_ep_probe(struct platform_device *pdev) · line 260
Quoted 10 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +5
-1pci->ep.ops = &ls_pcie_ep_ops; + pcie->big_endian =of_property_read_bool (dev->of_node,"big-endian" ); +platform_set_drvdata (pdev, pcie); -return dw_pcie_ep_init (&pci->ep); + ret =dw_pcie_ep_init (&pci->ep); +if (ret) +return ret;
Double space after return.
drivers/pci/controller/dwc/pci-layerscape-ep.c static int __init ls_pcie_ep_probe(struct platform_device *pdev) · line 262
Quoted 2 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +2
-0+ +return ls_pcie_ep_interrupt_init (pcie, pdev);
Double space after return.
- Mani
Quoted 6 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +0
-0}static struct platform_driver ls_pcie_ep_driver = {Signature · 1 line
2.34.1
Signature · 1 line
மணிவண்ணன் சதாசிவம்
Frank Li
maintainerQuoted 133 lines
-----Original Message-----
From: Manivannan Sadhasivam <[email protected]>
Sent: Saturday, May 6, 2023 2:59 AM
To: Frank Li <[email protected]>
Cc: M.H. Lian <[email protected]>; Mingkai Hu <[email protected]>; Roy Zang <[email protected]>; Lorenzo Pieralisi <[email protected]>; Rob Herring <[email protected]>; Krzysztof Wilczyński <[email protected]>; Bjorn Helgaas <[email protected]>; open list:PCI DRIVER FOR FREESCALE LAYERSCAPE <[email protected]>; open list:PCI DRIVER FOR FREESCALE LAYERSCAPE <linux- [email protected]>; moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE <[email protected]>; open list <linux- [email protected]>; [email protected]
Subject: [EXT] Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint linkup notifier supportCaution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
Quoted 2 lines · Frank Li
Layerscape has PME interrupt, which can be used as linkup notifier. Set
CFG_READYbit when linkup detected.Where are you setting this bit?
Quoted 10 lines
Signed-off-by Xiaowei Bao <[email protected]>Signed-off-by Frank Li <[email protected]>---
Change from v1 to v2
- pme -> PME
- irq -> IRQ
- updatedev_infomessage according to Bjorn's suggestion
- remove '.' at error messageReview
Quoted 4 lines
.../pci/controller/dwc/pci-layerscape-ep.c | 104 +++++++++++++++++- 1 file changed, 103 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/pci/controller/dwc/pci-layerscape-ep.cQuoted 34 lines
index
c640db60edc6..e974fbe3b6d8100644drivers/pci/controller/dwc/pci-layerscape-ep.c +18
-0@@ -18,6 +18,20 @@#include "pcie-designware.h" +#define PEX_PF0_CONFIG 0xC0014 +#define PEX_PF0_CFG_READY BIT(0) + +/* PEX PFa PCIE PME and message interrupt registers*/ +#define PEX_PF0_PME_MES_DR 0xC0020 +#define PEX_PF0_PME_MES_DR_LUD BIT(7) +#define PEX_PF0_PME_MES_DR_LDD BIT(9) +#define PEX_PF0_PME_MES_DR_HRD BIT(10) + +#define PEX_PF0_PME_MES_IER 0xC0028 +#define PEX_PF0_PME_MES_IER_LUDIE BIT(7) +#define PEX_PF0_PME_MES_IER_LDDIE BIT(9) +#define PEX_PF0_PME_MES_IER_HRDIE BIT(10) +#define to_ls_pcie_ep (x) dev_get_drvdata((x)->dev)struct ls_pcie_ep_drvdata {@@ -30,8 +44,88 @@ struct ls_pcie_ep {struct dw_pcie *pci;struct pci_epc_features *ls_epc;const struct ls_pcie_ep_drvdata *drvdata; +bool big_endian; +int irq; }; +static u32 ls_lut_readl (struct ls_pcie_ep *pcie,u32 offset) +{drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 62
Quoted 10 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +10
-0+struct dw_pcie *pci = pcie->pci; + +if (pcie->big_endian) +return ioread32be (pci->dbi_base + offset); +else +return ioread32 (pci->dbi_base + offset); +} + +static void ls_lut_writel (struct ls_pcie_ep *pcie,u32 offset, +u32 value)Above function argument could be wrapped within 80 columns.
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 74
Quoted 12 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +12
-0+{ +struct dw_pcie *pci = pcie->pci; + +if (pcie->big_endian) +iowrite32be (value, pci->dbi_base + offset); +else +iowrite32 (value, pci->dbi_base + offset); +} + +static irqreturn_t ls_pcie_ep_event_handler (int irq,void *dev_id) +{ +struct ls_pcie_ep *pcie = (struct ls_pcie_ep *)dev_id;No need to do explicit typecase for void pointer.
Quoted 4 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +4
-0+struct dw_pcie *pci = pcie->pci; +u32 val, cfg; + + val =ls_lut_readl (pcie,PEX_PF0_PME_MES_DR );drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 88
Quoted 10 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +10
-0+if (!val) +return IRQ_NONE ; + +if (val &PEX_PF0_PME_MES_DR_LUD ) { + cfg =ls_lut_readl (pcie,PEX_PF0_CONFIG ); + cfg |=PEX_PF0_CFG_READY ; +ls_lut_writel (pcie,PEX_PF0_CONFIG , cfg); +dw_pcie_ep_linkup (&pci->ep); + +dev_info (pci->dev,"Link up\n" );These messages could be demoted to
dev_dbg()logs.drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 95
Quoted 7 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +7
-0+ }else if (val &PEX_PF0_PME_MES_DR_LDD ) { +dev_info (pci->dev,"Link down\n" ); + }else if (val &PEX_PF0_PME_MES_DR_HRD ) { +dev_info (pci->dev,"Hot reset\n" ); + } + +ls_lut_writel (pcie,PEX_PF0_PME_MES_DR , val);You should clear the interrupts before processing.
Quoted 15 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 108
Quoted 13 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +13
-0+ +return IRQ_HANDLED ; +} + +static int ls_pcie_ep_interrupt_init (struct ls_pcie_ep *pcie, +struct platform_device *pdev) +{ +u32 val; +int ret; + + pcie->irq =platform_get_irq_byname (pdev,"pme" ); +if (pcie->irq <0 ) { +dev_err (&pdev->dev,"Can't get 'pme' IRQ\n" );PME
Here should be dts property pme, suppose should match platform_get_irq_byname(pdev, "pme");
Quoted 79 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 114
Quoted 7 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +6
-0+return pcie->irq; + } + + ret =devm_request_irq (&pdev->dev, pcie->irq, + ls_pcie_ep_event_handler,IRQF_SHARED , + pdev->name, pcie);Again, please wrap to fit the 80 column width.
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep {
Quoted 8 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +8
-0+if (ret) { +dev_err (&pdev->dev,"Can't register PCIe IRQ\n" ); +return ret; + } + +/* Enable interrupts */ + val =ls_lut_readl (pcie,PEX_PF0_PME_MES_IER ); + val |= PEX_PF0_PME_MES_IER_LDDIE |
PEX_PF0_PME_MES_IER_HRDIE|drivers/pci/controller/dwc/pci-layerscape-ep.c static int __init ls_pcie_ep_probe(struct
Quoted 10 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +6
-0+PEX_PF0_PME_MES_IER_LUDIE ; +ls_lut_writel (pcie,PEX_PF0_PME_MES_IER , val); + +return 0 ; +} +static const struct pci_epc_features *ls_pcie_ep_get_features (struct dw_pcie_ep *ep) {@@ -125,6 +219,7 @@ static int __init ls_pcie_ep_probe(struct
platform_device*pdev)drivers/pci/controller/dwc/pci-layerscape-ep.c static int __init ls_pcie_ep_probe(struct
Quoted 8 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +1
-0struct ls_pcie_ep *pcie;struct pci_epc_features *ls_epc;struct resource *dbi_base; +int ret; pcie =devm_kzalloc (dev,sizeof (*pcie),GFP_KERNEL );if (!pcie)@@ -144,6 +239,7 @@ static int __init ls_pcie_ep_probe(struct
platform_device*pdev)drivers/pci/controller/dwc/pci-layerscape-ep.c static int __init ls_pcie_ep_probe(struct
Quoted 8 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +1
-0pci->ops = pcie->drvdata->dw_pcie_ops; ls_epc->bar_fixed_64bit = (1 <<BAR_2 ) | (1 <<BAR_4 ); + ls_epc->linkup_notifier = true; pcie->pci = pci; pcie->ls_epc = ls_epc;@@ -155,9 +251,15 @@ static int __init ls_pcie_ep_probe(struct
platform_device*pdev)drivers/pci/controller/dwc/pci-layerscape-ep.c static int __init ls_pcie_ep_probe(struct platform_device *pdev)
Quoted 4 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +1
-0pci->ep.ops = &ls_pcie_ep_ops; + pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
drivers/pci/controller/dwc/pci-layerscape-ep.c static int __init ls_pcie_ep_probe(struct platform_device *pdev) · line 260
Quoted 7 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +4
-1+platform_set_drvdata (pdev, pcie); -return dw_pcie_ep_init (&pci->ep); + ret =dw_pcie_ep_init (&pci->ep); +if (ret) +return ret;Double space after return.
drivers/pci/controller/dwc/pci-layerscape-ep.c static int __init ls_pcie_ep_probe(struct · line 261
Quoted 2 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +2
-0+ +return ls_pcie_ep_interrupt_init (pcie, pdev);Double space after return.
- Mani
Quoted 6 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +0
-1}static struct platform_driver ls_pcie_ep_driver = { --2.34.1
--
மணிவண்ணன் சதாசிவம்
Quoted 7 lines · Frank Li
Quoted 7 lines
-----Original Message-----
From: Manivannan Sadhasivam <[email protected]>
Sent: Saturday, May 6, 2023 2:59 AM
To: Frank Li <[email protected]>
Cc: M.H. Lian <[email protected]>; Mingkai Hu <[email protected]>; Roy Zang <[email protected]>; Lorenzo Pieralisi <[email protected]>; Rob Herring <[email protected]>; Krzysztof
Quoted 8 lines
Quoted 8 lines
Wilczyński <[email protected]>; Bjorn Helgaas <[email protected]>; open list:PCI DRIVER FOR FREESCALE LAYERSCAPE <[email protected]>; open list:PCI DRIVER FOR FREESCALE LAYERSCAPE <linux- [email protected]>; moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE <[email protected]>; open list <linux- [email protected]>; [email protected]
Subject: [EXT] Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint linkup notifier support
All these quoted headers are redundant clutter since we've already seen them when Manivannan sent his comments. It would be nice if your mailer could be configured to omit them.
Quoted 12 lines
Quoted 11 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 108
Quoted 9 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +9
-0+static int ls_pcie_ep_interrupt_init (struct ls_pcie_ep *pcie, +struct platform_device *pdev) +{ +u32 val; +int ret; + + pcie->irq =platform_get_irq_byname (pdev,"pme" ); +if (pcie->irq <0 ) { +dev_err (&pdev->dev,"Can't get 'pme' IRQ\n" );PME
Quoted 2 lines
Here should be dts property
pme, suppose should matchplatform_get_irq_byname(pdev, "pme");
You can also edit out all the other context and questions if you're not responding to them.
There were a lot of other comments that were useful but are not relevant to this reply.
Bjorn
Frank Li
maintainerQuoted 7 lines
Quoted 1 line
Quoted 1 line
Subject: [EXT] Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint
linkup
Quoted 1 line
Quoted 1 line
notifier support
All these quoted headers are redundant clutter since we've already seen them when Manivannan sent his comments. It would be nice if your mailer could be configured to omit them.
Our email client quite stupid.
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c struct ls_pcie_ep { · line 108
Quoted 10 lines
drivers/pci/controller/dwc/pci-layerscape-ep.c +9
-0+static int ls_pcie_ep_interrupt_init (struct ls_pcie_ep *pcie, +struct platform_device *pdev) +{ +u32 val; +int ret; + + pcie->irq =platform_get_irq_byname (pdev,"pme" ); +if (pcie->irq <0 ) { +dev_err (&pdev->dev,"Can't get 'pme' IRQ\n" );PME
Quoted 8 lines
Quoted 2 lines
Here should be dts property
pme, suppose should matchplatform_get_irq_byname(pdev, "pme");You can also edit out all the other context and questions if you're not responding to them.
There were a lot of other comments that were useful but are not relevant to this reply.
Okay, I found I mess up patch version number.
Quoted 2 lines
Bjorn
Quoted 9 lines · Frank Li
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Subject: [EXT] Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint
linkup
Quoted 1 line
Quoted 1 line
notifier support
All these quoted headers are redundant clutter since we've already seen them when Manivannan sent his comments. It would be nice if your mailer could be configured to omit them.
Our email client quite stupid.
Yeah, sometimes those are really hard to work around.
Bjorn