hwmon: (core) Finish renaming groups parameter in API to extra_groups
PATCH 1/1 hwmon: (core) Finish renaming groups parameter in API to extra_groups
Commit 848ba0a2f20dc121a3ef5272a24641d2bd963d8b renames the 'groups' parameter of devm_hwmon_device_register_with_info() to 'extra_groups' in hwmon-kernel-api.txt (later .rst) and hwmon.h, but this change was not propagated to the function code itself in hwmon.c. Finish the job.
Note that hwmon_device_register_with_info() has the same parameter, and the name of that parameter was changed in all three files. Harmonizing the name between these related functions also removes a potential source of confusion.
Signed-off-by James Seo <[email protected]>
---
Changes from RFC:
* Rewrote commit message
History:
RFC: https://lore.kernel.org/linux-hwmon/[email protected]/
--- drivers/hwmon/hwmon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hwmon/hwmon.c +3 -3
@@ -1029,7 +1029,7 @@ EXPORT_SYMBOL_GPL(devm_hwmon_device_register_with_groups);* @name: hwmon name attribute * @drvdata: driver data to attach to created device * @chip: pointer to hwmon chip information -* @groups: pointer to list of driver specific attribute groups +* @extra_groups: pointer to list of driver specific attribute groups * * Returns the pointer to the new device. The new device is automatically * unregistered with the parent device.
@@ -1038,7 +1038,7 @@ struct device * devm_hwmon_device_register_with_info(struct device *dev, const char *name, void *drvdata, const struct hwmon_chip_info *chip, - const struct attribute_group **groups) + const struct attribute_group **extra_groups) { struct device **ptr, *hwdev;
@@ -1050,7 +1050,7 @@ devm_hwmon_device_register_with_info(struct device *dev, const char *name,return ERR_PTR (-ENOMEM ); hwdev =hwmon_device_register_with_info (dev, name, drvdata, chip, - groups); + extra_groups);if (IS_ERR (hwdev)) goto error;
Signature · 1 line
2.34.1