Skip to contentSkip to conversation

io_uring: add dummy io_uring_sqe_cmd() helper

PATCH In review Arnd Bergmann 3 participants 3 messages May 8, 2023 io_uring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 io_uring: add dummy io_uring_sqe_cmd() helper

From: Arnd Bergmann <[email protected]>

When CONFIG_IO_URING is disabled, the NVMe host support fails to build:

drivers/nvme/host/ioctl.c: In function 'nvme_uring_cmd_io':
drivers/nvme/host/ioctl.c:555:44: error: implicit declaration of function 'io_uring_sqe_cmd'; did you mean 'io_uring_free'? [-Werror=implicit-function-declaration]

  555 |         const struct nvme_uring_cmd *cmd = io_uring_sqe_cmd(ioucmd->sqe);
      |                                            ^~~~~~~~~~~~~~~~
      |                                            io_uring_free

Add a dummy function like the other interfaces for this configuration.

Fixes fd9b8547bc5c ("io_uring: Pass whole sqe to commands")
---
 include/linux/io_uring.h | 4 ++++
 1 file changed, 4 insertions(+)
include/linux/io_uring.h +4 -0
index 3399d979ee1c..ec1dbd9e2599 100644
@@ -102,6 +102,10 @@ static inline const char *io_uring_get_opcode(u8 opcode)
 {
 	return "";
 }
+static inline const void *io_uring_sqe_cmd(const struct io_uring_sqe *sqe)
+{
+	return NULL;
+}
 #endif
 
 #endif
Signature · 1 line
2.39.2
#1 lore raw
Quoted 1 line · Arnd Bergmann

Add a dummy function like the other interfaces for this configuration.

Why do we need a separate dummy? The structure is unconditionally defined, so we can just unconditionally define the helper.

maintainer
#2 lore raw
Quoted 5 lines · Christoph Hellwig
Quoted 1 line · Arnd Bergmann

Add a dummy function like the other interfaces for this configuration.

Why do we need a separate dummy? The structure is unconditionally defined, so we can just unconditionally define the helper.

Yeah, no reason for a special one. I'll send one out.

Signature · 1 line
Jens Axboe