Skip to contentSkip to conversation

i2c-atr and FPDLink

PATCH Superseded Tomi Valkeinen 4 participants 18 messages Apr 21, 2023 – May 8, 2023

Subsystems (7)

v11 of 15 Superseded Latest is v15 →

lore
Share & tools
lore

Tomi Valkeinen

author maintainer
#0 lore raw

v11 cover i2c-atr and FPDLink

Hi,

You can find v10 from:

https://lore.kernel.org/all/[email protected]/

Diff to v10 included below.

Changes in v11:
- Rename Documentation/i2c/muxes/i2c-atr.rst to Documentation/i2c/i2c-address-translators.rst
- Change documentation according to reviews
- Minor fixes for the issues reported in reviews
- Rename i2c_atr_cli2alias_pair to i2c_atr_alias_pair
- Added Documentation/devicetree/bindings/i2c/i2c-atr.yaml
- i2c-alias-pool is now handled in i2c-atr. i2c-atr reads the pool from
DT and manages the reservation of aliases.

Tomi

Luca Ceresoli (1):
i2c: add I2C Address Translator (ATR) support

Tomi Valkeinen (6):
dt-bindings: media: add TI DS90UB913 FPD-Link III Serializer
dt-bindings: media: add TI DS90UB953 FPD-Link III Serializer
dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer
media: i2c: add DS90UB960 driver
media: i2c: add DS90UB913 driver
media: i2c: add DS90UB953 driver

 .../devicetree/bindings/i2c/i2c-atr.yaml      |   34 +
 .../bindings/media/i2c/ti,ds90ub913.yaml      |  133 +
 .../bindings/media/i2c/ti,ds90ub953.yaml      |  134 +
 .../bindings/media/i2c/ti,ds90ub960.yaml      |  423 ++
 Documentation/i2c/i2c-address-translators.rst |   96 +
 Documentation/i2c/index.rst                   |    1 +
 MAINTAINERS                                   |   16 +
 drivers/i2c/Kconfig                           |    9 +
 drivers/i2c/Makefile                          |    1 +
 drivers/i2c/i2c-atr.c                         |  684 +++
 drivers/media/i2c/Kconfig                     |   47 +
 drivers/media/i2c/Makefile                    |    3 +
 drivers/media/i2c/ds90ub913.c                 |  906 ++++
 drivers/media/i2c/ds90ub953.c                 | 1400 ++++++
 drivers/media/i2c/ds90ub960.c                 | 4049 +++++++++++++++++
 include/linux/i2c-atr.h                       |  116 +
 include/media/i2c/ds90ub9xx.h                 |   22 +
 17 files changed, 8074 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-atr.yaml
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
 create mode 100644 Documentation/i2c/i2c-address-translators.rst
 create mode 100644 drivers/i2c/i2c-atr.c
 create mode 100644 drivers/media/i2c/ds90ub913.c
 create mode 100644 drivers/media/i2c/ds90ub953.c
 create mode 100644 drivers/media/i2c/ds90ub960.c
 create mode 100644 include/linux/i2c-atr.h
 create mode 100644 include/media/i2c/ds90ub9xx.h

Interdiff against v10:

Documentation/devicetree/bindings/i2c/i2c-atr.yaml new file +34 -0
new file mode 100644
index 000000000000..d7f73d98110d
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/i2c-atr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Common i2c address translator properties.
+
+maintainers:
+  - Tomi Valkeinen <[email protected]>
+
+description:
+  An I2C Address Translator (ATR) is a device with an I2C slave parent
+  ("upstream") port and N I2C master child ("downstream") ports, and
+  forwards transactions from upstream to the appropriate downstream port
+  with a modified slave address. The address used on the parent bus is
+  called the "alias" and is (potentially) different from the physical
+  slave address of the child bus. Address translation is done by the
+  hardware.
+
+properties:
+  i2c-alias-pool:
+    $ref: /schemas/types.yaml#/definitions/uint16-array
+    description:
+      I2C alias pool is a pool of I2C addresses on the main I2C bus that can be
+      used to access the remote peripherals on the serializer's I2C bus. The
+      addresses must be available, not used by any other peripheral. Each
+      remote peripheral is assigned an alias from the pool, and transactions to
+      that address will be forwarded to the remote peripheral, with the address
+      translated to the remote peripheral's real address. This property is not
+      needed if there are no I2C addressable remote peripherals.
+
+additionalProperties: true
+...
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml +1 -9
index bb921caa85a7..1d5362bea09a 100644
@@ -37,15 +37,7 @@ properties:
       Specifier for the GPIO connected to the PDB pin.
 
   i2c-alias-pool:
-    $ref: /schemas/types.yaml#/definitions/uint16-array
-    description:
-      I2C alias pool is a pool of I2C addresses on the main I2C bus that can be
-      used to access the remote peripherals on the serializer's I2C bus. The
-      addresses must be available, not used by any other peripheral. Each
-      remote peripheral is assigned an alias from the pool, and transactions to
-      that address will be forwarded to the remote peripheral, with the address
-      translated to the remote peripheral's real address. This property is not
-      needed if there are no I2C addressable remote peripherals.
+    $ref: /schemas/i2c/i2c-atr.yaml#/properties/i2c-alias-pool
 
   links:
     type: object
Documentation/i2c/i2c-address-translators.rst renamed from Documentation/i2c/muxes/i2c-atr.rst +11 -12
similarity index 82%
rename from Documentation/i2c/muxes/i2c-atr.rst
rename to Documentation/i2c/i2c-address-translators.rst
index da226fd4de63..b22ce9f41ecf 100644
@@ -1,8 +1,8 @@
 .. SPDX-License-Identifier: GPL-2.0
 
-=====================
-Kernel driver i2c-atr
-=====================
+=======================
+I2C Address Translators
+=======================
 
 Author: Luca Ceresoli <[email protected]>
 Author: Tomi Valkeinen <[email protected]>
@@ -23,15 +23,14 @@ An ATR looks similar to an i2c-mux except:
  - there is normally no need to select the child port; the alias used on the
    parent bus implies it
 
-The ATR functionality can be provided by a chip with many other
-features. This file provides a helper to implement an ATR within your
-driver.
+The ATR functionality can be provided by a chip with many other features.
+The kernel i2c-atr provides a helper to implement an ATR within a driver.
 
 The ATR creates a new I2C "child" adapter on each child bus. Adding
 devices on the child bus ends up in invoking the driver code to select
 an available alias. Maintaining an appropriate pool of available aliases
 and picking one for each new device is up to the driver implementer. The
-ATR maintains an table of currently assigned alias and uses it to modify
+ATR maintains a table of currently assigned alias and uses it to modify
 all I2C transactions directed to devices on the child buses.
 
 A typical example follows.
@@ -66,7 +65,7 @@ Alias table:
 
 Transaction:
 
- - Slave X driver sends a transaction (on adapter B), slave address 0x10
+ - Slave X driver requests a transaction (on adapter B), slave address 0x10
  - ATR driver finds slave X is on bus B and has alias 0x20, rewrites
    messages with address 0x20, forwards to adapter A
  - Physical I2C transaction on bus A, slave address 0x20
@@ -83,13 +82,13 @@ Transaction:
 
 Usage:
 
- 1. In your driver (typically in the probe function) add an ATR by
-    calling i2c_atr_new() passing your attach/detach callbacks
+ 1. In the driver (typically in the probe function) add an ATR by
+    calling i2c_atr_new() passing attach/detach callbacks
  2. When the attach callback is called pick an appropriate alias,
-    configure it in your chip and return the chosen alias in the
+    configure it in the chip and return the chosen alias in the
     alias_id parameter
  3. When the detach callback is called, deconfigure the alias from
-    your chip and put it back in the pool for later usage
+    the chip and put the alias back in the pool for later usage
 
 I2C ATR functions and data structures
 -------------------------------------
Documentation/i2c/index.rst +1 -1
index aaf33d1315f4..2b213d4ce89c 100644
@@ -16,9 +16,9 @@ Introduction
    instantiating-devices
    busses/index
    i2c-topology
-   muxes/i2c-atr
    muxes/i2c-mux-gpio
    i2c-sysfs
+   i2c-address-translators
 
 Writing device drivers
 ======================
drivers/i2c/i2c-atr.c +158 -22

322 lines not on this page · raw message

drivers/media/i2c/ds90ub953.c +1 -1
index a77908da5c38..1e3827a60029 100644
@@ -600,7 +600,7 @@ static int ub953_log_status(struct v4l2_subdev *sd)
 	for (i = 0; i < sizeof(id); i++)
 		ub953_read(priv, UB953_REG_FPD3_RX_ID(i), &id[i]);
 
-	dev_info(dev, "ID '%.*s'\n", sizeof(id), id);
+	dev_info(dev, "ID '%.*s'\n", (int)sizeof(id), id);
 
 	ub953_read(priv, UB953_REG_GENERAL_STATUS, &v);
 	dev_info(dev, "GENERAL_STATUS %#02x\n", v);
drivers/media/i2c/ds90ub960.c +31 -154

312 lines not on this page · raw message

include/linux/i2c-atr.h +4 -4
index 7596f70ce1ab..4d5da161c225 100644
@@ -21,8 +21,8 @@ struct i2c_atr;
 /**
  * struct i2c_atr_ops - Callbacks from ATR to the device driver.
  * @attach_client: Notify the driver of a new device connected on a child
- *                 bus. The driver must choose an I2C alias, configure the
- *                 hardware to use it and return it in `alias_id`.
+ *                 bus, with the alias assigned to it. The driver must
+ *                 configure the hardware to use the alias.
  * @detach_client: Notify the driver of a device getting disconnected. The
  *                 driver must configure the hardware to stop using the
  *                 alias.
@@ -31,7 +31,7 @@ struct i2c_atr;
  */
 struct i2c_atr_ops {
 	int (*attach_client)(struct i2c_atr *atr, u32 chan_id,
-			     const struct i2c_client *client, u16 *alias_id);
+			     const struct i2c_client *client, u16 alias);
 	void (*detach_client)(struct i2c_atr *atr, u32 chan_id,
 			      const struct i2c_client *client);
 };
@@ -57,7 +57,7 @@ struct i2c_atr *i2c_atr_new(struct i2c_adapter *parent, struct device *dev,
  * i2c_atr_delete - Delete an I2C ATR helper.
  * @atr: I2C ATR helper to be deleted.
  *
- * Precondition: all the adapters added with i2c_atr_add_adapter() mumst be
+ * Precondition: all the adapters added with i2c_atr_add_adapter() must be
  * removed by calling i2c_atr_del_adapter().
  */
 void i2c_atr_delete(struct i2c_atr *atr);
Signature · 1 line
2.34.1
author maintainer
#1 lore raw

PATCH v11 1/7 i2c: add I2C Address Translator (ATR) support

From: Luca Ceresoli <[email protected]>

An ATR is a device that looks similar to an i2c-mux: it has an I2C slave "upstream" port and N master "downstream" ports, and forwards transactions from upstream to the appropriate downstream port. But it is different in that the forwarded transaction has a different slave address. The address used on the upstream bus is called the "alias" and is (potentially) different from the physical slave address of the downstream chip.

Add a helper file (just like i2c-mux.c for a mux or switch) to allow implementing ATR features in a device driver. The helper takes care or adapter creation/destruction and translates addresses at each transaction.

---
 .../devicetree/bindings/i2c/i2c-atr.yaml      |  34 +
 Documentation/i2c/i2c-address-translators.rst |  96 +++
 Documentation/i2c/index.rst                   |   1 +
 MAINTAINERS                                   |   8 +
 drivers/i2c/Kconfig                           |   9 +
 drivers/i2c/Makefile                          |   1 +
 drivers/i2c/i2c-atr.c                         | 684 ++++++++++++++++++
 include/linux/i2c-atr.h                       | 116 +++
 8 files changed, 949 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-atr.yaml
 create mode 100644 Documentation/i2c/i2c-address-translators.rst
 create mode 100644 drivers/i2c/i2c-atr.c
 create mode 100644 include/linux/i2c-atr.h
Documentation/devicetree/bindings/i2c/i2c-atr.yaml new file +34 -0
new file mode 100644
index 000000000000..d7f73d98110d
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/i2c-atr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Common i2c address translator properties.
+
+maintainers:
+  - Tomi Valkeinen <[email protected]>
+
+description:
+  An I2C Address Translator (ATR) is a device with an I2C slave parent
+  ("upstream") port and N I2C master child ("downstream") ports, and
+  forwards transactions from upstream to the appropriate downstream port
+  with a modified slave address. The address used on the parent bus is
+  called the "alias" and is (potentially) different from the physical
+  slave address of the child bus. Address translation is done by the
+  hardware.
+
+properties:
+  i2c-alias-pool:
+    $ref: /schemas/types.yaml#/definitions/uint16-array
+    description:
+      I2C alias pool is a pool of I2C addresses on the main I2C bus that can be
+      used to access the remote peripherals on the serializer's I2C bus. The
+      addresses must be available, not used by any other peripheral. Each
+      remote peripheral is assigned an alias from the pool, and transactions to
+      that address will be forwarded to the remote peripheral, with the address
+      translated to the remote peripheral's real address. This property is not
+      needed if there are no I2C addressable remote peripherals.
+
+additionalProperties: true
+...
Documentation/i2c/i2c-address-translators.rst new file +96 -0

96 lines not on this page · raw message

Documentation/i2c/index.rst +1 -0
index 6270f1fd7d4e..2b213d4ce89c 100644
@@ -18,6 +18,7 @@ Introduction
    i2c-topology
    muxes/i2c-mux-gpio
    i2c-sysfs
+   i2c-address-translators
 
 Writing device drivers
 ======================
MAINTAINERS +8 -0
index e25ebb7c781b..348bc924a56f 100644
@@ -9559,6 +9559,14 @@ L:	[email protected]
 S:	Maintained
 F:	drivers/i2c/i2c-core-acpi.c
 
+I2C ADDRESS TRANSLATOR (ATR)
+M:	Tomi Valkeinen <[email protected]>
+R:	Luca Ceresoli <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	drivers/i2c/i2c-atr.c
+F:	include/linux/i2c-atr.h
+
 I2C CONTROLLER DRIVER FOR NVIDIA GPU
 M:	Ajay Gupta <[email protected]>
 L:	[email protected]
drivers/i2c/Kconfig +9 -0
index 438905e2a1d0..c6d1a345ea6d 100644
@@ -71,6 +71,15 @@ config I2C_MUX
 
 source "drivers/i2c/muxes/Kconfig"
 
+config I2C_ATR
+	tristate "I2C Address Translator (ATR) support"
+	help
+	  Enable support for I2C Address Translator (ATR) chips.
+
+	  An ATR allows accessing multiple I2C busses from a single
+	  physical bus via address translation instead of bus selection as
+	  i2c-muxes do.
+
 config I2C_HELPER_AUTO
 	bool "Autoselect pertinent helper modules"
 	default y
drivers/i2c/Makefile +1 -0
index c1d493dc9bac..3f71ce4711e3 100644
@@ -13,6 +13,7 @@ i2c-core-$(CONFIG_OF) 		+= i2c-core-of.o
 obj-$(CONFIG_I2C_SMBUS)		+= i2c-smbus.o
 obj-$(CONFIG_I2C_CHARDEV)	+= i2c-dev.o
 obj-$(CONFIG_I2C_MUX)		+= i2c-mux.o
+obj-$(CONFIG_I2C_ATR)		+= i2c-atr.o
 obj-y				+= algos/ busses/ muxes/
 obj-$(CONFIG_I2C_STUB)		+= i2c-stub.o
 obj-$(CONFIG_I2C_SLAVE_EEPROM)	+= i2c-slave-eeprom.o
drivers/i2c/i2c-atr.c new file +684 -0

684 lines not on this page · raw message

include/linux/i2c-atr.h new file +116 -0

116 lines not on this page · raw message

Signature · 1 line
2.34.1
Acked-by on v11 1/7
#2 lore raw

Re: [PATCH v11 1/7] i2c: add I2C Address Translator (ATR) support

Quoted 10 lines · Tomi Valkeinen

From: Luca Ceresoli <[email protected]>

An ATR is a device that looks similar to an i2c-mux: it has an I2C slave "upstream" port and N master "downstream" ports, and forwards transactions from upstream to the appropriate downstream port. But it is different in that the forwarded transaction has a different slave address. The address used on the upstream bus is called the "alias" and is (potentially) different from the physical slave address of the downstream chip.

Quoted 7 lines

Add a helper file (just like i2c-mux.c for a mux or switch) to allow implementing ATR features in a device driver. The helper takes care or adapter creation/destruction and translates addresses at each transaction.

This looks good to me. Dunno if the DT folks want the binding as a seperate patch, but this is good to go as far as I am concerned. Everything else can be fixed incrementally, I think. Also, this can go in via the media-tree, there shouldn't be any conflicts.

Thanks for keeping at it!

author maintainer
#3 lore raw

Re: [PATCH v11 1/7] i2c: add I2C Address Translator (ATR) support

Quoted 15 lines · Wolfram Sang
Quoted 14 lines · Tomi Valkeinen

From: Luca Ceresoli <[email protected]>

An ATR is a device that looks similar to an i2c-mux: it has an I2C slave "upstream" port and N master "downstream" ports, and forwards transactions from upstream to the appropriate downstream port. But it is different in that the forwarded transaction has a different slave address. The address used on the upstream bus is called the "alias" and is (potentially) different from the physical slave address of the downstream chip.

Add a helper file (just like i2c-mux.c for a mux or switch) to allow implementing ATR features in a device driver. The helper takes care or adapter creation/destruction and translates addresses at each transaction.

Quoted 6 lines
Quoted 3 lines

This looks good to me. Dunno if the DT folks want the binding as a seperate patch, but this is good to go as far as I am concerned.

Ah, right. I'll resend with the DT bindings separate.

Tomi

author maintainer
#4 lore raw

Re: [PATCH v11 1/7] i2c: add I2C Address Translator (ATR) support

Quoted 16 lines · Tomi Valkeinen
Quoted 15 lines · Wolfram Sang
Quoted 14 lines · Tomi Valkeinen

From: Luca Ceresoli <[email protected]>

An ATR is a device that looks similar to an i2c-mux: it has an I2C slave "upstream" port and N master "downstream" ports, and forwards transactions from upstream to the appropriate downstream port. But it is different in that the forwarded transaction has a different slave address. The address used on the upstream bus is called the "alias" and is (potentially) different from the physical slave address of the downstream chip.

Add a helper file (just like i2c-mux.c for a mux or switch) to allow implementing ATR features in a device driver. The helper takes care or adapter creation/destruction and translates addresses at each transaction.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

This looks good to me. Dunno if the DT folks want the binding as a seperate patch, but this is good to go as far as I am concerned.

Ah, right. I'll resend with the DT bindings separate.

Also, looks like I forgot to remove the namespaces for export symbols.

Tomi

#5 lore raw

Re: [PATCH v11 1/7] i2c: add I2C Address Translator (ATR) support

Quoted 4 lines
Quoted 2 lines

Ah, right. I'll resend with the DT bindings separate.

Also, looks like I forgot to remove the namespaces for export symbols.

And why not keeping them? I understand ATR would be the first user in the Linux I2C world, but someone has to start it...

author maintainer
#6 lore raw

Re: [PATCH v11 1/7] i2c: add I2C Address Translator (ATR) support

Quoted 7 lines · Wolfram Sang
Quoted 4 lines
Quoted 2 lines

Ah, right. I'll resend with the DT bindings separate.

Also, looks like I forgot to remove the namespaces for export symbols.

And why not keeping them? I understand ATR would be the first user in the Linux I2C world, but someone has to start it...

Well, you requested to remove them =). I originally didn't have them, but added them on Andy's request. I personally don't mind either way.

Tomi

#7 lore raw

Re: [PATCH v11 1/7] i2c: add I2C Address Translator (ATR) support

Quoted 2 lines

Well, you requested to remove them =)

Oh my...

Quoted 1 line

I originally didn't have them, but added them on Andy's request.

Oh my oh my, what a journey...

Quoted 1 line

I personally don't mind either way.

... just keep them and we are done with it :D

maintainer
#8 lore raw

Re: [PATCH v11 1/7] i2c: add I2C Address Translator (ATR) support

In reply to Tomi Valkeinen
Quoted 38 lines · Tomi Valkeinen

From: Luca Ceresoli <[email protected]>

An ATR is a device that looks similar to an i2c-mux: it has an I2C slave "upstream" port and N master "downstream" ports, and forwards transactions from upstream to the appropriate downstream port. But it is different in that the forwarded transaction has a different slave address. The address used on the upstream bus is called the "alias" and is (potentially) different from the physical slave address of the downstream chip.

Add a helper file (just like i2c-mux.c for a mux or switch) to allow implementing ATR features in a device driver. The helper takes care or adapter creation/destruction and translates addresses at each transaction.

---
 .../devicetree/bindings/i2c/i2c-atr.yaml      |  34 +
 Documentation/i2c/i2c-address-translators.rst |  96 +++
 Documentation/i2c/index.rst                   |   1 +
 MAINTAINERS                                   |   8 +
 drivers/i2c/Kconfig                           |   9 +
 drivers/i2c/Makefile                          |   1 +
 drivers/i2c/i2c-atr.c                         | 684 ++++++++++++++++++
 include/linux/i2c-atr.h                       | 116 +++
 8 files changed, 949 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-atr.yaml
 create mode 100644 Documentation/i2c/i2c-address-translators.rst
 create mode 100644 drivers/i2c/i2c-atr.c
 create mode 100644 include/linux/i2c-atr.h
Documentation/devicetree/bindings/i2c/i2c-atr.yaml new file +0 -0
new file mode 100644
index 000000000000..d7f73d98110d

Documentation/devicetree/bindings/i2c/i2c-atr.yaml line 1

Quoted 1 line
Documentation/devicetree/bindings/i2c/i2c-atr.yaml new file +1 -0
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: GPL-2.0

Dual license.

Documentation/devicetree/bindings/i2c/i2c-atr.yaml line 7

Quoted 6 lines
Documentation/devicetree/bindings/i2c/i2c-atr.yaml new file +6 -0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/i2c-atr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Common i2c address translator properties.

Drop hard stop.

Quoted 6 lines
Documentation/devicetree/bindings/i2c/i2c-atr.yaml new file +6 -0
+
+maintainers:
+  - Tomi Valkeinen <[email protected]>
+
+description:
+  An I2C Address Translator (ATR) is a device with an I2C slave parent

Documentation/devicetree/bindings/i2c/i2c-atr.yaml line 23

Quoted 10 lines
Documentation/devicetree/bindings/i2c/i2c-atr.yaml new file +10 -0
+  ("upstream") port and N I2C master child ("downstream") ports, and
+  forwards transactions from upstream to the appropriate downstream port
+  with a modified slave address. The address used on the parent bus is
+  called the "alias" and is (potentially) different from the physical
+  slave address of the child bus. Address translation is done by the
+  hardware.
+
+properties:
+  i2c-alias-pool:
+    $ref: /schemas/types.yaml#/definitions/uint16-array

We do support some flags in the upper 16-bits of I2C addresses. Any of those possibly needed here?

Quoted 11 lines
Documentation/devicetree/bindings/i2c/i2c-atr.yaml new file +11 -0
+    description:
+      I2C alias pool is a pool of I2C addresses on the main I2C bus that can be
+      used to access the remote peripherals on the serializer's I2C bus. The
+      addresses must be available, not used by any other peripheral. Each
+      remote peripheral is assigned an alias from the pool, and transactions to
+      that address will be forwarded to the remote peripheral, with the address
+      translated to the remote peripheral's real address. This property is not
+      needed if there are no I2C addressable remote peripherals.
+
+additionalProperties: true
+...
#9 lore raw

Re: [PATCH v11 1/7] i2c: add I2C Address Translator (ATR) support

Quoted 3 lines

We do support some flags in the upper 16-bits of I2C addresses. Any of those possibly needed here?

I2C_OWN_SLAVE_ADDRESS definately not. ATR is only for addresses on the remote bus while our own address is on the local bus.

I2C_TEN_BIT_ADDRESS, only in theory. I have never seen a 10-bit address in the wild, so extremely unlikely that ATR hardware does support it.

But then again, there is a slight chance that we add more flags in the future which might be relevant for ATR? So, u32 is probably a good thing to use nonetheless.

author maintainer
#10 lore raw

PATCH v11 2/7 dt-bindings: media: add TI DS90UB913 FPD-Link III Serializer

In reply to Tomi Valkeinen

Add DT bindings for TI DS90UB913 FPD-Link III Serializer.

---
 .../bindings/media/i2c/ti,ds90ub913.yaml      | 133 ++++++++++++++++++
 1 file changed, 133 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml new file +133 -0
new file mode 100644
index 000000000000..f6612bb0f667
@@ -0,0 +1,133 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ti,ds90ub913.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments DS90UB913 FPD-Link III Serializer
+
+maintainers:
+  - Tomi Valkeinen <[email protected]>
+
+description:
+  The TI DS90UB913 is an FPD-Link III video serializer for parallel video.
+
+properties:
+  compatible:
+    enum:
+      - ti,ds90ub913a-q1
+
+  '#gpio-cells':
+    const: 2
+    description:
+      First cell is the GPO pin number, second cell is the flags. The GPO pin
+      number must be in range of [0, 3]. Note that GPOs 2 and 3 are not
+      available in external oscillator mode.
+
+  gpio-controller: true
+
+  clocks:
+    maxItems: 1
+    description:
+      Reference clock connected to the CLKIN pin.
+
+  clock-names:
+    items:
+      - const: clkin
+
+  '#clock-cells':
+    const: 0
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+
+    properties:
+      port@0:
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
+        description: Parallel input port
+
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+
+            required:
+              - pclk-sample
+
+      port@1:
+        $ref: /schemas/graph.yaml#/properties/port
+        unevaluatedProperties: false
+        description: FPD-Link III output port
+
+    required:
+      - port@0
+      - port@1
+
+  i2c:
+    $ref: /schemas/i2c/i2c-controller.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - '#gpio-cells'
+  - gpio-controller
+  - '#clock-cells'
+  - ports
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    serializer {
+      compatible = "ti,ds90ub913a-q1";
+
+      gpio-controller;
+      #gpio-cells = <2>;
+
+      clocks = <&clk_cam_48M>;
+      clock-names = "clkin";
+
+      #clock-cells = <0>;
+
+      ports {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        port@0 {
+          reg = <0>;
+          ub913_in: endpoint {
+            remote-endpoint = <&sensor_out>;
+            pclk-sample = <1>;
+          };
+        };
+
+        port@1 {
+          reg = <1>;
+          endpoint {
+            remote-endpoint = <&deser_fpd_in>;
+          };
+        };
+      };
+
+      i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sensor@48 {
+          compatible = "aptina,mt9v111";
+          reg = <0x48>;
+
+          clocks = <&fixed_clock>;
+
+          port {
+            sensor_out: endpoint {
+              remote-endpoint = <&ub913_in>;
+            };
+          };
+        };
+      };
+    };
+...
Signature · 1 line
2.34.1
author maintainer
#11 lore raw

PATCH v11 3/7 dt-bindings: media: add TI DS90UB953 FPD-Link III Serializer

In reply to Tomi Valkeinen

Add DT bindings for TI DS90UB953 FPD-Link III Serializer.

---
 .../bindings/media/i2c/ti,ds90ub953.yaml      | 134 ++++++++++++++++++
 1 file changed, 134 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml new file +134 -0
new file mode 100644
index 000000000000..2030366994d1
@@ -0,0 +1,134 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ti,ds90ub953.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments DS90UB953 FPD-Link III Serializer
+
+maintainers:
+  - Tomi Valkeinen <[email protected]>
+
+description:
+  The TI DS90UB953 is an FPD-Link III video serializer for MIPI CSI-2.
+
+properties:
+  compatible:
+    enum:
+      - ti,ds90ub953-q1
+      - ti,ds90ub971-q1
+
+  '#gpio-cells':
+    const: 2
+    description:
+      First cell is the GPIO pin number, second cell is the flags. The GPIO pin
+      number must be in range of [0, 3].
+
+  gpio-controller: true
+
+  clocks:
+    maxItems: 1
+    description:
+      Reference clock connected to the CLKIN pin.
+
+  clock-names:
+    items:
+      - const: clkin
+
+  '#clock-cells':
+    const: 0
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+
+    properties:
+      port@0:
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
+        description: CSI-2 input port
+
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+
+            required:
+              - data-lanes
+
+      port@1:
+        $ref: /schemas/graph.yaml#/properties/port
+        unevaluatedProperties: false
+        description: FPD-Link III output port
+
+    required:
+      - port@0
+      - port@1
+
+  i2c:
+    $ref: /schemas/i2c/i2c-controller.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - '#gpio-cells'
+  - gpio-controller
+  - '#clock-cells'
+  - ports
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    serializer {
+      compatible = "ti,ds90ub953-q1";
+
+      gpio-controller;
+      #gpio-cells = <2>;
+
+      #clock-cells = <0>;
+
+      ports {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        port@0 {
+          reg = <0>;
+          ub953_in: endpoint {
+            clock-lanes = <0>;
+            data-lanes = <1 2 3 4>;
+            remote-endpoint = <&sensor_out>;
+          };
+        };
+
+        port@1 {
+          reg = <1>;
+          endpoint {
+            remote-endpoint = <&deser_fpd_in>;
+          };
+        };
+      };
+
+      i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sensor@1a {
+          compatible = "sony,imx274";
+          reg = <0x1a>;
+
+          reset-gpios = <&serializer 0 GPIO_ACTIVE_LOW>;
+
+          clocks = <&serializer>;
+          clock-names = "inck";
+
+          port {
+            sensor_out: endpoint {
+              remote-endpoint = <&ub953_in>;
+            };
+          };
+        };
+      };
+    };
+...
Signature · 1 line
2.34.1
author maintainer
#12 lore raw

PATCH v11 4/7 dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer

In reply to Tomi Valkeinen

Add DT bindings for TI DS90UB960 FPD-Link III Deserializer.

---
 .../bindings/media/i2c/ti,ds90ub960.yaml      | 423 ++++++++++++++++++
 1 file changed, 423 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml new file +423 -0
new file mode 100644
index 000000000000..1d5362bea09a
@@ -0,0 +1,423 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ti,ds90ub960.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments DS90UB9XX Family FPD-Link Deserializer Hubs
+
+maintainers:
+  - Tomi Valkeinen <[email protected]>
+
+description:
+  The TI DS90UB9XX devices are FPD-Link video deserializers with I2C and GPIO
+  forwarding.
+
+properties:
+  compatible:
+    enum:
+      - ti,ds90ub960-q1
+      - ti,ds90ub9702-q1
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+    description:
+      Reference clock connected to the REFCLK pin.
+
+  clock-names:
+    items:
+      - const: refclk
+
+  powerdown-gpios:
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the PDB pin.
+
+  i2c-alias-pool:
+    $ref: /schemas/i2c/i2c-atr.yaml#/properties/i2c-alias-pool
+
+  links:
+    type: object
+    additionalProperties: false
+
+    properties:
+      '#address-cells':
+        const: 1
+
+      '#size-cells':
+        const: 0
+
+      ti,manual-strobe:
+        type: boolean
+        description:
+          Enable manual strobe position and EQ level
+
+    patternProperties:
+      '^link@[0-3]$':
+        type: object
+        additionalProperties: false
+        properties:
+          reg:
+            description: The link number
+            maxItems: 1
+
+          i2c-alias:
+            description:
+              The I2C address used for the serializer. Transactions to this
+              address on the I2C bus where the deserializer resides are
+              forwarded to the serializer.
+
+          ti,rx-mode:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            enum:
+              - 0 # RAW10
+              - 1 # RAW12 HF
+              - 2 # RAW12 LF
+              - 3 # CSI2 SYNC
+              - 4 # CSI2 NON-SYNC
+            description:
+              FPD-Link Input Mode. This should reflect the hardware and the
+              default mode of the connected device.
+
+          ti,cdr-mode:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            enum:
+              - 0 # FPD-Link III
+              - 1 # FPD-Link IV
+            description:
+              FPD-Link CDR Mode. This should reflect the hardware and the
+              default mode of the connected device.
+
+          ti,strobe-pos:
+            $ref: /schemas/types.yaml#/definitions/int32
+            minimum: -13
+            maximum: 13
+            description: Manual strobe position
+
+          ti,eq-level:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            maximum: 14
+            description: Manual EQ level
+
+          serializer:
+            type: object
+            description: FPD-Link Serializer node
+
+        required:
+          - reg
+          - i2c-alias
+          - ti,rx-mode
+          - serializer
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+
+    properties:
+      port@0:
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
+        description: FPD-Link input 0
+
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+            description:
+              Endpoint for FPD-Link port. If the RX mode for this port is RAW,
+              hsync-active and vsync-active must be defined.
+
+      port@1:
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
+        description: FPD-Link input 1
+
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+            description:
+              Endpoint for FPD-Link port. If the RX mode for this port is RAW,
+              hsync-active and vsync-active must be defined.
+
+      port@2:
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
+        description: FPD-Link input 2
+
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+            description:
+              Endpoint for FPD-Link port. If the RX mode for this port is RAW,
+              hsync-active and vsync-active must be defined.
+
+      port@3:
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
+        description: FPD-Link input 3
+
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+            description:
+              Endpoint for FPD-Link port. If the RX mode for this port is RAW,
+              hsync-active and vsync-active must be defined.
+
+      port@4:
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
+        description: CSI-2 Output 0
+
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+
+            properties:
+              data-lanes:
+                minItems: 1
+                maxItems: 4
+              link-frequencies:
+                maxItems: 1
+
+            required:
+              - data-lanes
+              - link-frequencies
+
+      port@5:
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
+        description: CSI-2 Output 1
+
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+
+            properties:
+              data-lanes:
+                minItems: 1
+                maxItems: 4
+              link-frequencies:
+                maxItems: 1
+
+            required:
+              - data-lanes
+              - link-frequencies
+
+    required:
+      - port@0
+      - port@1
+      - port@2
+      - port@3
+      - port@4
+      - port@5
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - ports
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+      clock-frequency = <400000>;
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      deser@3d {
+        compatible = "ti,ds90ub960-q1";
+        reg = <0x3d>;
+
+        clock-names = "refclk";
+        clocks = <&fixed_clock>;
+
+        powerdown-gpios = <&pca9555 7 GPIO_ACTIVE_LOW>;
+
+        i2c-alias-pool = /bits/ 16 <0x4a 0x4b 0x4c 0x4d 0x4e 0x4f>;
+
+        ports {
+          #address-cells = <1>;
+          #size-cells = <0>;
+
+          /* Port 0, Camera 0 */
+          port@0 {
+            reg = <0>;
+
+            ub960_fpd3_1_in: endpoint {
+              remote-endpoint = <&ub953_1_out>;
+            };
+          };
+
+          /* Port 1, Camera 1 */
+          port@1 {
+            reg = <1>;
+
+            ub960_fpd3_2_in: endpoint {
+              remote-endpoint = <&ub913_2_out>;
+              hsync-active = <0>;
+              vsync-active = <1>;
+            };
+          };
+
+          /* Port 2, unconnected */
+          port@2 {
+            reg = <2>;
+          };
+
+          /* Port 3, unconnected */
+          port@3 {
+            reg = <3>;
+          };
+
+          /* Port 4, CSI-2 TX */
+          port@4 {
+            reg = <4>;
+            ds90ub960_0_csi_out: endpoint {
+              data-lanes = <1 2 3 4>;
+              link-frequencies = /bits/ 64 <800000000>;
+              remote-endpoint = <&csi2_phy0>;
+            };
+          };
+
+          /* Port 5, unconnected */
+          port@5 {
+            reg = <5>;
+          };
+        };
+
+        links {
+          #address-cells = <1>;
+          #size-cells = <0>;
+
+          /* Link 0 has DS90UB953 serializer and IMX274 sensor */
+
+          link@0 {
+            reg = <0>;
+            i2c-alias = <0x44>;
+
+            ti,rx-mode = <3>;
+
+            serializer1: serializer {
+              compatible = "ti,ds90ub953-q1";
+
+              gpio-controller;
+              #gpio-cells = <2>;
+
+              #clock-cells = <0>;
+
+              ports {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                port@0 {
+                  reg = <0>;
+                  ub953_1_in: endpoint {
+                    data-lanes = <1 2 3 4>;
+                    remote-endpoint = <&sensor_1_out>;
+                  };
+                };
+
+                port@1 {
+                  reg = <1>;
+
+                  ub953_1_out: endpoint {
+                    remote-endpoint = <&ub960_fpd3_1_in>;
+                  };
+                };
+              };
+
+              i2c {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                sensor@1a {
+                  compatible = "sony,imx274";
+                  reg = <0x1a>;
+
+                  reset-gpios = <&serializer1 0 GPIO_ACTIVE_LOW>;
+
+                  port {
+                    sensor_1_out: endpoint {
+                      remote-endpoint = <&ub953_1_in>;
+                    };
+                  };
+                };
+              };
+            };
+          };  /* End of link@0 */
+
+          /* Link 1 has DS90UB913 serializer and MT9V111 sensor */
+
+          link@1 {
+            reg = <1>;
+            i2c-alias = <0x45>;
+
+            ti,rx-mode = <0>;
+
+            serializer2: serializer {
+              compatible = "ti,ds90ub913a-q1";
+
+              gpio-controller;
+              #gpio-cells = <2>;
+
+              clocks = <&clk_cam_48M>;
+              clock-names = "clkin";
+
+              #clock-cells = <0>;
+
+              ports {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                port@0 {
+                  reg = <0>;
+                  ub913_2_in: endpoint {
+                    remote-endpoint = <&sensor_2_out>;
+                    pclk-sample = <1>;
+                  };
+                };
+
+                port@1 {
+                  reg = <1>;
+
+                  ub913_2_out: endpoint {
+                    remote-endpoint = <&ub960_fpd3_2_in>;
+                  };
+                };
+              };
+
+              i2c {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                sensor@48 {
+                  compatible = "aptina,mt9v111";
+                  reg = <0x48>;
+
+                  clocks = <&serializer2>;
+
+                  port {
+                    sensor_2_out: endpoint {
+                      remote-endpoint = <&ub913_2_in>;
+                    };
+                  };
+                };
+              };
+            };
+          }; /* End of link@1 */
+        };
+      };
+    };
+...
Signature · 1 line
2.34.1
maintainer
#13 lore raw

Re: [PATCH v11 4/7] dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer

Quoted 46 lines · Tomi Valkeinen

Add DT bindings for TI DS90UB960 FPD-Link III Deserializer.

---
 .../bindings/media/i2c/ti,ds90ub960.yaml      | 423 ++++++++++++++++++
 1 file changed, 423 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml new file +30 -0
new file mode 100644
index 000000000000..1d5362bea09a
@@ -0,0 +1,423 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ti,ds90ub960.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments DS90UB9XX Family FPD-Link Deserializer Hubs
+
+maintainers:
+  - Tomi Valkeinen <[email protected]>
+
+description:
+  The TI DS90UB9XX devices are FPD-Link video deserializers with I2C and GPIO
+  forwarding.
+
+properties:
+  compatible:
+    enum:
+      - ti,ds90ub960-q1
+      - ti,ds90ub9702-q1
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+    description:
+      Reference clock connected to the REFCLK pin.
+
+  clock-names:

Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml line 40

Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml new file +10 -0
+    items:
+      - const: refclk
+
+  powerdown-gpios:
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the PDB pin.
+
+  i2c-alias-pool:
+    $ref: /schemas/i2c/i2c-atr.yaml#/properties/i2c-alias-pool

This is not how we handle common properties (usually). Just reference '/schemas/i2c/i2c-atr.yaml#' at the top level and use unevaluatedProperties.

Is there a limit to the number of entries for this device? If so, add that here.

Rob

author maintainer
#14 lore raw

PATCH v11 5/7 media: i2c: add DS90UB960 driver

In reply to Tomi Valkeinen

Add driver for TI DS90UB960 FPD-Link III Deserializer.

---
 MAINTAINERS                   |    8 +
 drivers/media/i2c/Kconfig     |   21 +
 drivers/media/i2c/Makefile    |    1 +
 drivers/media/i2c/ds90ub960.c | 4049 +++++++++++++++++++++++++++++++++
 include/media/i2c/ds90ub9xx.h |   22 +
 5 files changed, 4101 insertions(+)
 create mode 100644 drivers/media/i2c/ds90ub960.c
 create mode 100644 include/media/i2c/ds90ub9xx.h
MAINTAINERS +8 -0
index 348bc924a56f..22e8d1bf148e 100644
@@ -20929,6 +20929,14 @@ F:	drivers/misc/tifm*
 F:	drivers/mmc/host/tifm_sd.c
 F:	include/linux/tifm.h
 
+TI FPD-LINK DRIVERS
+M:	Tomi Valkeinen <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/devicetree/bindings/media/i2c/ti,ds90*
+F:	drivers/media/i2c/ds90*
+F:	include/media/i2c/ds90*
+
 TI KEYSTONE MULTICORE NAVIGATOR DRIVERS
 M:	Nishanth Menon <[email protected]>
 M:	Santosh Shilimkar <[email protected]>
drivers/media/i2c/Kconfig +21 -0
index 256d55bb2b1d..80de6c3a6492 100644
@@ -1611,4 +1611,25 @@ config VIDEO_THS7303
 
 endmenu
 
+#
+# Video serializers and deserializers (e.g. FPD-Link)
+#
+
+menu "Video serializers and deserializers"
+
+config VIDEO_DS90UB960
+	tristate "TI FPD-Link III/IV Deserializers"
+	depends on OF && I2C && VIDEO_DEV
+	select I2C_ATR
+	select MEDIA_CONTROLLER
+	select OF_GPIO
+	select REGMAP_I2C
+	select V4L2_FWNODE
+	select VIDEO_V4L2_SUBDEV_API
+	help
+	  Device driver for the Texas Instruments DS90UB960
+	  FPD-Link III Deserializer and DS90UB9702 FPD-Link IV Deserializer.
+
+endmenu
+
 endif # VIDEO_DEV
drivers/media/i2c/Makefile +1 -0
index b44dacf935f4..4458df54db64 100644
@@ -28,6 +28,7 @@ obj-$(CONFIG_VIDEO_CS3308) += cs3308.o
 obj-$(CONFIG_VIDEO_CS5345) += cs5345.o
 obj-$(CONFIG_VIDEO_CS53L32A) += cs53l32a.o
 obj-$(CONFIG_VIDEO_CX25840) += cx25840/
+obj-$(CONFIG_VIDEO_DS90UB960) += ds90ub960.o
 obj-$(CONFIG_VIDEO_DW9714) += dw9714.o
 obj-$(CONFIG_VIDEO_DW9768) += dw9768.o
 obj-$(CONFIG_VIDEO_DW9807_VCM) += dw9807-vcm.o
drivers/media/i2c/ds90ub960.c new file +4049 -0

2,954 lines not on this page · raw message

include/media/i2c/ds90ub9xx.h new file +22 -0
new file mode 100644
index 000000000000..0245198469ec

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.34.1

Part of the diff is not shown here. View the raw message.

author maintainer
#15 lore raw

PATCH v11 6/7 media: i2c: add DS90UB913 driver

In reply to Tomi Valkeinen

Add driver for TI DS90UB913 FPD-Link III Serializer.

---
 drivers/media/i2c/Kconfig     |  13 +
 drivers/media/i2c/Makefile    |   1 +
 drivers/media/i2c/ds90ub913.c | 906 ++++++++++++++++++++++++++++++++++
 3 files changed, 920 insertions(+)
 create mode 100644 drivers/media/i2c/ds90ub913.c
drivers/media/i2c/Kconfig +13 -0
index 80de6c3a6492..bbcbf599a3f8 100644
@@ -1617,6 +1617,19 @@ endmenu
 
 menu "Video serializers and deserializers"
 
+config VIDEO_DS90UB913
+	tristate "TI DS90UB913 FPD-Link III Serializer"
+	depends on OF && I2C && VIDEO_DEV
+	select I2C_ATR
+	select MEDIA_CONTROLLER
+	select OF_GPIO
+	select REGMAP_I2C
+	select V4L2_FWNODE
+	select VIDEO_V4L2_SUBDEV_API
+	help
+	  Device driver for the Texas Instruments DS90UB913
+	  FPD-Link III Serializer.
+
 config VIDEO_DS90UB960
 	tristate "TI FPD-Link III/IV Deserializers"
 	depends on OF && I2C && VIDEO_DEV
drivers/media/i2c/Makefile +1 -0
index 4458df54db64..2ae5256bb585 100644
@@ -28,6 +28,7 @@ obj-$(CONFIG_VIDEO_CS3308) += cs3308.o
 obj-$(CONFIG_VIDEO_CS5345) += cs5345.o
 obj-$(CONFIG_VIDEO_CS53L32A) += cs53l32a.o
 obj-$(CONFIG_VIDEO_CX25840) += cx25840/
+obj-$(CONFIG_VIDEO_DS90UB913) += ds90ub913.o
 obj-$(CONFIG_VIDEO_DS90UB960) += ds90ub960.o
 obj-$(CONFIG_VIDEO_DW9714) += dw9714.o
 obj-$(CONFIG_VIDEO_DW9768) += dw9768.o
drivers/media/i2c/ds90ub913.c new file +906 -0

906 lines not on this page · raw message

Signature · 1 line
2.34.1
#16 lore raw

Re: [PATCH v11 6/7] media: i2c: add DS90UB913 driver

kernel test robot noticed the following build errors:

Hi Tomi,

kernel test robot noticed the following build errors:

[auto build test ERROR on media-tree/master]
[also build test ERROR on wsa/i2c/for-next linus/master sailus-media-tree/streams v6.4-rc1 next-20230505] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tomi-Valkeinen/i2c-add-I2C-Address-Translator-ATR-support/20230421-182249
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230421101833.345984-7-tomi.valkeinen%40ideasonboard.com
patch subject: [PATCH v11 6/7] media: i2c: add DS90UB913 driver
config: mips-randconfig-c004-20230508 (https://download.01.org/0day-ci/archive/20230508/[email protected]/config)
compiler: mips-linux-gcc (GCC) 12.1.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/3aca9704bbf3d069accf3a026b749ec6f10745d4
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Tomi-Valkeinen/i2c-add-I2C-Address-Translator-ATR-support/20230421-182249 git checkout 3aca9704bbf3d069accf3a026b749ec6f10745d4
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> ERROR: modpost: "__clk_get_name" [drivers/media/i2c/ds90ub913.ko] undefined!
>> ERROR: modpost: "devm_clk_hw_register_fixed_factor" [drivers/media/i2c/ds90ub913.ko] undefined!
>> ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/ds90ub913.ko] undefined!
>> ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/media/i2c/ds90ub913.ko] undefined!
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
author maintainer
#17 lore raw

PATCH v11 7/7 media: i2c: add DS90UB953 driver

In reply to Tomi Valkeinen

Add driver for TI DS90UB953 FPD-Link III Serializer.

---
 drivers/media/i2c/Kconfig     |   13 +
 drivers/media/i2c/Makefile    |    1 +
 drivers/media/i2c/ds90ub953.c | 1400 +++++++++++++++++++++++++++++++++
 3 files changed, 1414 insertions(+)
 create mode 100644 drivers/media/i2c/ds90ub953.c
drivers/media/i2c/Kconfig +13 -0
index bbcbf599a3f8..461df425c163 100644
@@ -1630,6 +1630,19 @@ config VIDEO_DS90UB913
 	  Device driver for the Texas Instruments DS90UB913
 	  FPD-Link III Serializer.
 
+config VIDEO_DS90UB953
+	tristate "TI FPD-Link III/IV CSI-2 Serializers"
+	depends on OF && I2C && VIDEO_DEV
+	select I2C_ATR
+	select MEDIA_CONTROLLER
+	select OF_GPIO
+	select REGMAP_I2C
+	select V4L2_FWNODE
+	select VIDEO_V4L2_SUBDEV_API
+	help
+	  Device driver for the Texas Instruments DS90UB953
+	  FPD-Link III Serializer and DS90UB971 FPD-Link IV Serializer.
+
 config VIDEO_DS90UB960
 	tristate "TI FPD-Link III/IV Deserializers"
 	depends on OF && I2C && VIDEO_DEV
drivers/media/i2c/Makefile +1 -0
index 2ae5256bb585..88e5ba3e5c39 100644
@@ -29,6 +29,7 @@ obj-$(CONFIG_VIDEO_CS5345) += cs5345.o
 obj-$(CONFIG_VIDEO_CS53L32A) += cs53l32a.o
 obj-$(CONFIG_VIDEO_CX25840) += cx25840/
 obj-$(CONFIG_VIDEO_DS90UB913) += ds90ub913.o
+obj-$(CONFIG_VIDEO_DS90UB953) += ds90ub953.o
 obj-$(CONFIG_VIDEO_DS90UB960) += ds90ub960.o
 obj-$(CONFIG_VIDEO_DW9714) += dw9714.o
 obj-$(CONFIG_VIDEO_DW9768) += dw9768.o
drivers/media/i2c/ds90ub953.c new file +1400 -0

1,400 lines not on this page · raw message

Signature · 1 line
2.34.1