Skip to contentSkip to conversation

Input: adxl34x - do not hardcode interrupt trigger type

PATCH Applied Marek Vasut 3 participants 3 messages May 9, 2023 – May 11, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: adxl34x - do not hardcode interrupt trigger type

Instead of hardcoding IRQ trigger type to IRQF_TRIGGER_HIGH, let's respect the settings specified in the firmware description.

Fixes e27c729219ad2 ("Input: add driver for ADXL345/346 Digital Accelerometers")

---
Cc: Dmitry Torokhov <[email protected]>
Cc: Michael Hennerich <[email protected]>
Cc: [email protected]

---
 drivers/input/misc/adxl34x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/input/misc/adxl34x.c +1 -2
index eecca671b5884..a3f45e0ee0c75 100644
@@ -817,8 +817,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
 	AC_WRITE(ac, POWER_CTL, 0);
 
 	err = request_threaded_irq(ac->irq, NULL, adxl34x_irq,
-				   IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
-				   dev_name(dev), ac);
+				   IRQF_ONESHOT, dev_name(dev), ac);
 	if (err) {
 		dev_err(dev, "irq %d busy?\n", ac->irq);
 		goto err_free_mem;
Signature · 1 line
2.39.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Dienstag, 9. Mai 2023 22:36
To: [email protected]
Cc: Marek Vasut <[email protected]>; Dmitry Torokhov <[email protected]>; Hennerich, Michael <[email protected]>
Subject: [PATCH] Input: adxl34x - do not hardcode interrupt trigger type

Instead of hardcoding IRQ trigger type to IRQF_TRIGGER_HIGH, let's respect the settings specified in the firmware description.

Quoted 7 lines
Fixes e27c729219ad2 ("Input: add driver for ADXL345/346 Digital

Accelerometers")

---
Cc: Dmitry Torokhov <[email protected]>
Cc: Michael Hennerich <[email protected]>
Cc: [email protected]

Quoted 21 lines
---
 drivers/input/misc/adxl34x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/input/misc/adxl34x.c index renamed from drivers/input/misc/adxl34x.c +0 -0

eecca671b5884..a3f45e0ee0c75 100644

drivers/input/misc/adxl34x.c +1 -2
@@ -817,8 +817,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int
 irq,
 	AC_WRITE(ac, POWER_CTL, 0);
 
 	err = request_threaded_irq(ac->irq, NULL, adxl34x_irq,
-				   IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
-				   dev_name(dev), ac);
+				   IRQF_ONESHOT, dev_name(dev), ac);
 	if (err) {
 		dev_err(dev, "irq %d busy?\n", ac->irq);

goto err_free_mem;
--
2.39.2

maintainer Applied
#2 lore raw
In reply to Marek Vasut
Quoted 5 lines · Marek Vasut

Instead of hardcoding IRQ trigger type to IRQF_TRIGGER_HIGH, let's respect the settings specified in the firmware description.

Fixes e27c729219ad2 ("Input: add driver for ADXL345/346 Digital Accelerometers")

Applied, thank you.

Signature · 1 line
Dmitry