Input: adxl34x - do not hardcode interrupt trigger type
PATCH 1/1 Input: adxl34x - do not hardcode interrupt trigger type
Instead of hardcoding IRQ trigger type to IRQF_TRIGGER_HIGH, let's respect the settings specified in the firmware description.
---
Cc: Dmitry Torokhov <[email protected]>
Cc: Michael Hennerich <[email protected]>
Cc: [email protected]
--- drivers/input/misc/adxl34x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/input/misc/adxl34x.c +1 -2
@@ -817,8 +817,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,AC_WRITE (ac,POWER_CTL ,0 ); err =request_threaded_irq (ac->irq,NULL , adxl34x_irq, -IRQF_TRIGGER_HIGH |IRQF_ONESHOT , -dev_name (dev), ac); +IRQF_ONESHOT ,dev_name (dev), ac);if (err) {dev_err (dev,"irq %d busy?\n" , ac->irq); goto err_free_mem;
Signature · 1 line
2.39.2
Quoted 14 lines
-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Dienstag, 9. Mai 2023 22:36
To: [email protected]
Cc: Marek Vasut <[email protected]>; Dmitry Torokhov <[email protected]>; Hennerich, Michael <[email protected]>
Subject: [PATCH] Input: adxl34x - do not hardcode interrupt trigger typeInstead of hardcoding IRQ trigger type to
IRQF_TRIGGER_HIGH, let's respect the settings specified in the firmware description.
Quoted 7 lines
Fixes e27c729219ad2 ("Input: add driver for ADXL345/346 DigitalAccelerometers")
Signed-off-by Marek Vasut <[email protected]>---
Cc: Dmitry Torokhov <[email protected]>
Cc: Michael Hennerich <[email protected]>
Cc: [email protected]
Quoted 21 lines
--- drivers/input/misc/adxl34x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/input/misc/adxl34x.c index renamed from drivers/input/misc/adxl34x.c +0
-0
eecca671b5884..a3f45e0ee0c75100644drivers/input/misc/adxl34x.c +1
-2@@ -817,8 +817,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,AC_WRITE (ac,POWER_CTL ,0 ); err =request_threaded_irq (ac->irq,NULL , adxl34x_irq, -IRQF_TRIGGER_HIGH |IRQF_ONESHOT , -dev_name (dev), ac); +IRQF_ONESHOT ,dev_name (dev), ac);if (err) {dev_err (dev,"irq %d busy?\n" , ac->irq);goto
err_free_mem;
--
2.39.2
Quoted 5 lines · Marek Vasut
Instead of hardcoding IRQ trigger type to
IRQF_TRIGGER_HIGH, let's respect the settings specified in the firmware description.Fixes e27c729219ad2 ("Input: add driver for ADXL345/346 Digital Accelerometers")Signed-off-by Marek Vasut <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry