Skip to contentSkip to conversation

firmware: ti_sci: Add missing LF in error message

PATCH In review Andreas Dannenberg 3 participants 5 messages May 10, 2023 – Jun 1, 2023 Texas instruments' system control interface (TISCI) protocol driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: ti_sci: Add missing LF in error message

The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:

"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"

Fix ths by adding the missing linefeed character.

---
 drivers/firmware/ti_sci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/ti_sci.c +1 -1
index bd7379ae55..72f572d824 100644
@@ -265,7 +265,7 @@ static int ti_sci_do_xfer(struct ti_sci_info *info,
 	if (xfer->rx_len) {
 		ret = ti_sci_get_response(info, xfer, &info->chan_rx);
 		if (!ti_sci_is_response_ack(xfer->tx_message.buf)) {
-			dev_err(info->dev, "Message not acknowledged");
+			dev_err(info->dev, "Message not acknowledged\n");
 			ret = -ENODEV;
 		}
 	}
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Andreas Dannenberg

The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:

"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"

Fix ths by adding the missing linefeed character.

s/ths/this

Quoted 3 lines

---

Good find,

Quoted 16 lines
  drivers/firmware/ti_sci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/ti_sci.c +1 -1
index bd7379ae55..72f572d824 100644
@@ -265,7 +265,7 @@ static int ti_sci_do_xfer(struct ti_sci_info *info,
  	if (xfer->rx_len) {
  		ret = ti_sci_get_response(info, xfer, &info->chan_rx);
  		if (!ti_sci_is_response_ack(xfer->tx_message.buf)) {
-			dev_err(info->dev, "Message not acknowledged");
+			dev_err(info->dev, "Message not acknowledged\n");
  			ret = -ENODEV;
  		}
  	}
#2 lore raw
Quoted 9 lines · Andrew Davis
Quoted 7 lines · Andreas Dannenberg

The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:

"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"

Fix ths by adding the missing linefeed character.

Quoted 7 lines

s/ths/this

Quoted 3 lines

---

Good find,

I'll do my best to remember to fix this before pushing (checkpatch will remind me, I think), no need to v2.

Signature · 1 line
Tom
#3 lore raw
Quoted 11 lines · Tom Rini
Quoted 10 lines · Andrew Davis
Quoted 7 lines · Andreas Dannenberg

The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:

"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"

Fix ths by adding the missing linefeed character.

s/ths/this

This slipped through the cracks on my end...

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines

---

Good find,

I'll do my best to remember to fix this before pushing (checkpatch will remind me, I think), no need to v2.

Thanks Tom, I appreciate it.

--
Andreas Dannenberg
Texas Instruments Inc

Quoted 3 lines
Signature · 2 lines
-- 
Tom
#4 lore raw
In reply to Andreas Dannenberg
Quoted 10 lines · Andreas Dannenberg

The "Message not acknowledged" error message is missing a line feed, leading to the console log getting garbled and joined together with whatever the next output is in case this error happens:

"ti_sci system-controller@44043000: Message not acknowledgedAuthentication failed!"

Fix ths by adding the missing linefeed character.

Applied to u-boot/next, thanks!

Signature · 1 line
Tom