Skip to contentSkip to conversation

tpm/tpm_tis: Disable interrupts for more Lenovo devices

PATCH In review Jerry Snitselaar 1 participant 2 messages May 11, 2023 – May 18, 2023

Subsystems (3)
Stable branch Keys-trusted TPM device driver
lore
Share & tools
lore

Jerry Snitselaar

author
#0 lore raw

PATCH 1/1 tpm/tpm_tis: Disable interrupts for more Lenovo devices

The P360 Tiny suffers from an irq storm issue like the T490s, so add an entry for it to tpm_tis_dmi_table, and force polling. There also previously was a report from the previous attempt to enable interrupts that involved a ThinkPad L490. So an entry is added for it as well.

Reported-by Peter Zijlstra <[email protected]> # P360 Tiny
Closes https://lore.kernel.org/linux-integrity/[email protected]/ open here
Cc [email protected] # 6.2
Cc Peter Huewe <[email protected]>
Cc Jarkko Sakkinen <[email protected]>
Cc Jason Gunthorpe <[email protected]>
Signed-off-by Jerry Snitselaar <[email protected]>
---
 drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/char/tpm/tpm_tis.c +16 -0
index 7af389806643..709b4e13bd6e 100644
@@ -122,6 +122,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"),
 		},
 	},
+	{
+		.callback = tpm_tis_disable_irq,
+		.ident = "ThinkStation P360 Tiny",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkStation P360 Tiny"),
+		},
+	},
+	{
+		.callback = tpm_tis_disable_irq,
+		.ident = "ThinkPad L490",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"),
+		},
+	},
 	{}
 };
Signature · 1 line
2.38.1
author
#1 lore raw
Quoted 8 lines · Jerry Snitselaar

The P360 Tiny suffers from an irq storm issue like the T490s, so add an entry for it to tpm_tis_dmi_table, and force polling. There also previously was a report from the previous attempt to enable interrupts that involved a ThinkPad L490. So an entry is added for it as well.

Reported-by Peter Zijlstra <[email protected]> # P360 Tiny
Closes https://lore.kernel.org/linux-integrity/[email protected]/ open here
Cc [email protected] # 6.2

For the stable folks this can be ignored though it won't hurt anything if someone does backport it. The code enabling interrupts went into 6.4-rc1, not 6.2.

Regards,
Jerry