Skip to contentSkip to conversation

Fix libclang version check for out-of-tree builds

PATCH New Ethan D. Twardy 1 participant 1 message May 13, 2023 Rust

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix libclang version check for out-of-tree builds

During out-of-tree builds where the path to the kernel source tree contains a version string, scripts/rust_is_available.sh incorrectly parses the version string of libclang, resulting in CONFIG_RUST_IS_AVAILABLE erroneously set to 'n'.

To reproduce:

    $ cd ~/build && make -C ~/linux-6.4.0-rc1 O=$PWD rustavailable
---
 scripts/rust_is_available.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/rust_is_available.sh +2 -2
index aebbf1913970..e8a1439be9f8 100755
@@ -102,8 +102,8 @@ fi
 # Check that the `libclang` used by the Rust bindings generator is suitable.
 bindgen_libclang_version=$( \
 	LC_ALL=C "$BINDGEN" $(dirname $0)/rust_is_available_bindgen_libclang.h 2>&1 >/dev/null \
-		| grep -F 'clang version ' \
-		| grep -oE '[0-9]+\.[0-9]+\.[0-9]+' \
+		| grep -oE 'clang version [0-9]+\.[0-9]+\.[0-9]+' \
+		| cut -d' ' -f3 \
 		| head -n 1 \
 )
 bindgen_libclang_min_version=$($min_tool_version llvm)

base-commit: ac9a78681b921877518763ba0e89202254349d1b

Signature · 1 line
2.40.1